From: Libor Vanek <libor@conet.cz>
To: Andi Kleen <ak@muc.de>
Cc: linux-kernel@vger.kernel.org, viro@parcelfarce.linux.theplanet.co.uk
Subject: Re: 2.6.0-mm1 - kernel panic (VFS bug?)
Date: Tue, 06 Jan 2004 13:35:29 +0100 [thread overview]
Message-ID: <3FFAAB91.6090207@conet.cz> (raw)
In-Reply-To: <m3znd139ur.fsf@averell.firstfloor.org>
Andi Kleen wrote:
>Libor Vanek <libor@conet.cz> writes:
>
>
>>...
>>asmlinkage long sys_open(const char __user * filename, int flags, int mode)
>>{
>> char * tmp;
>> int fd, error;
>> char tmp_path[PATH_MAX],tmp2_path[PATH_MAX];
>>
>>
>PATH_MAX is 4096. The i386 stack is only 6k. You already overflowed it.
>You're lucky if your machine only panics, much worse things can happen
>with kernel stack overflows.
>
>
OK - what's correct implementation? Do a "char * tmp_path" and kmalloc it?
--
Libor Vanek
next prev parent reply other threads:[~2004-01-06 12:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1aQy3-2y1-7@gated-at.bofh.it>
2004-01-06 5:49 ` 2.6.0-mm1 - kernel panic (VFS bug?) Andi Kleen
2004-01-06 12:35 ` Libor Vanek [this message]
2004-01-06 12:39 ` Andi Kleen
2004-01-06 12:43 ` Libor Vanek
2004-01-06 13:19 ` Muli Ben-Yehuda
2004-01-06 3:52 Libor Vanek
2004-01-06 4:09 ` Nick Piggin
2004-01-06 4:12 ` Valdis.Kletnieks
2004-01-06 4:24 ` Libor Vanek
2004-01-06 4:35 ` Valdis.Kletnieks
2004-01-06 4:30 ` viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3FFAAB91.6090207@conet.cz \
--to=libor@conet.cz \
--cc=ak@muc.de \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.