From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E4661C4708D for ; Fri, 6 Jan 2023 12:41:37 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id DC5D985576; Fri, 6 Jan 2023 13:41:34 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.b="p1bcrpb9"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id ADD2C854DD; Fri, 6 Jan 2023 13:41:32 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2057.outbound.protection.outlook.com [40.107.243.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 06E1B85408 for ; Fri, 6 Jan 2023 13:41:30 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=michal.simek@amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a/MJJuL5OvVTJc5vRhyIHMP3mNPZkHwER+zW1LHEUqdEoI+FvsesJDrao45nli1I7a1Q49YBH3ml7nrc2KFFIsyiALpSbYdWjWNzvLr0QYIkOcDd/wmtHirg31VbsDxENG/vCZncRgIy8ZTw3RYJGDkfqtvAKEp6rSKP6BzFhotx+IMxJIWYGqpbfom6rZiZxWItEhDoUxxTTsXqMshmvSVSILEEozvsICPFrDnT12zhyUmBr2B+3IRQVNae1m7mgjQ5SZ0SobeM3wF5QEEjIq92UlV3CFYiDDLw6sMa1r+AUaqLcbASVXlUZxWcpDc4Q5NFMGCR+qoU8mPlkRGwng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g4uBtNj2ORporEH+4Nzg01sRPxcqaXGzBk0dQbMqzcA=; b=T/Zwe05esHKVPsdHxICkT44YkTMg09uuAqiY1mui4Fy5kJFYe5i3FoM0JgP2i5zg//7zhyNWIGLEsIKe9k0IQqr3qB6fcOIlDgy3MLEfi0jfXAkg8TZ/o9XLyaiLzmDTGMb/Dtc7wNQllwlOHGHYTdEV4n+mN6Nam935/pyGQhqFDJYEhOn8SZafX96YCBcU6Ctf7psFqX5vpRKpkRWj3n2+j2nywH7jk61Y6p2AnfFC5vi2lm8Msu7DzGhb6xdo735waaWdWJAiB+azPEqMhiTN5hdndVxy0Mrz3hIUPgpncMZ02ryDNKpJq3PbBgmBjbqO/QA9R2VPhyR5AqV4/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.denx.de smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g4uBtNj2ORporEH+4Nzg01sRPxcqaXGzBk0dQbMqzcA=; b=p1bcrpb9vElVW0toOxoujug3xv0j+5xeTupquMOdPhX0LegWmXs53GxF/R95XlO0rNSRaCKFMq8FZQCbWpUhXdzLq3Tr0qNlnIMv1qZq7rmc/Qk9idlK77H7NffaMTNtYEqBU8/VvFueZLFYj6i9msG/TjiizysqeyF+SKw7r5w= Received: from DM6PR02CA0093.namprd02.prod.outlook.com (2603:10b6:5:1f4::34) by BN9PR12MB5049.namprd12.prod.outlook.com (2603:10b6:408:132::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Fri, 6 Jan 2023 12:41:25 +0000 Received: from DM6NAM11FT060.eop-nam11.prod.protection.outlook.com (2603:10b6:5:1f4:cafe::7e) by DM6PR02CA0093.outlook.office365.com (2603:10b6:5:1f4::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.15 via Frontend Transport; Fri, 6 Jan 2023 12:41:25 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT060.mail.protection.outlook.com (10.13.173.63) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5986.14 via Frontend Transport; Fri, 6 Jan 2023 12:41:24 +0000 Received: from [10.254.241.50] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 6 Jan 2023 06:41:22 -0600 Message-ID: <3a1697d2-54c7-dff0-b149-e14f31c06e65@amd.com> Date: Fri, 6 Jan 2023 13:41:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 4/4] drivers: mmc: Change datatype to fix a warning Content-Language: en-US To: Ashok Reddy Soma , CC: , , Algapally Santosh Sagar References: <20230106120035.2183-1-ashok.reddy.soma@amd.com> <20230106120035.2183-5-ashok.reddy.soma@amd.com> From: Michal Simek In-Reply-To: <20230106120035.2183-5-ashok.reddy.soma@amd.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT060:EE_|BN9PR12MB5049:EE_ X-MS-Office365-Filtering-Correlation-Id: b4ef0499-3274-4109-31b5-08daefe3525f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: u7fkP5W4sqs2o1g9QB/pAy9m4mfyg3pavxPNqy7EjZf+tLaCOjJo+HhPqRUXtaXwTxyxAWqxWU00MIlel2vrJrXOKmPTcgdW1d2z12vjrsGSb37MJWJEFD8BQAdZBQEizbUaCBy0gxYFkD8NJtctM5XvanTRNg0wr1i9hApOPixctliyKH1pZDgjen8U9e6hpkYPsAvafRGLL8M1s3I7+5f/a41qFmTHdD0Sx6KiqWRau+KyA31QxA74joGzYTKu4Xh1Pin4Tvm5wWfvJ53e7o356bx6Zx81KzLfVTqlOXY0j76wISt2u8dDpyNmgHI0J6QyoNgDVj6RuuZQiOD/0MYWkyGOKcysneM95f3v6qwk136f7oGdZzW0EOXU09Akltwvx9XgoNOwXspa9QAugOQWx5h7dn6LOC3BX1h8qtC7lm+nfkZFT69jA3nCaTyOqKdNVYDAg6M1oBS+4KNfsXNb7D1nUz6Aip2RxoCO4aGeA+kBqtlxSjPr6ZVdkdq6o6wCUvM0vHjAHaPvGE/3/ICIsg/oPQpUDY8Ae/hxX301gfKinkN3fFhHioeOqzuWOmcB72cN+muHJPHKNKXHF1hHh9dAsEzthQPXXDZkbhpu2QCU4MIBpgMHJxbLsw+iqi9CMnCte2bzESI0rsYEBu7lwtR6MfTgZF1cxEvmtcI+LG2mg4/pSwXBGtNXA2DRyZeWFYaU3INxmDZEWaqJ/PHGu3eMFQSEsM9KoDmiXwUToA6qxLM+yYJyXfmJVf5dekFw6cV50DuC/6GRPSW8ZQ== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230022)(4636009)(396003)(136003)(346002)(376002)(39860400002)(451199015)(46966006)(40470700004)(36840700001)(8676002)(8936002)(4326008)(316002)(31686004)(44832011)(2906002)(54906003)(110136005)(70206006)(16576012)(70586007)(478600001)(41300700001)(6666004)(53546011)(81166007)(16526019)(26005)(40460700003)(186003)(47076005)(426003)(83380400001)(2616005)(336012)(82310400005)(36756003)(5660300002)(82740400003)(356005)(36860700001)(31696002)(86362001)(40480700001)(43740500002)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2023 12:41:24.4150 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b4ef0499-3274-4109-31b5-08daefe3525f X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT060.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5049 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean mmc: zynq_sdhci: Fix wrong tuning_loop_counter datatype On 1/6/23 13:00, Ashok Reddy Soma wrote: > From: Algapally Santosh Sagar > > tuning_loop_counter is of char type. Change to int to fix below warning. > warning: comparison is always false due to limited range of data type. Conceptually description should be done a way that you say I fixed this issue because datatype wasn't correct. And this was reported by spare. And you are doing it because it is not correct not because there is a warning. Warning just points to it. M > > Signed-off-by: Algapally Santosh Sagar > Signed-off-by: Ashok Reddy Soma > --- > > drivers/mmc/zynq_sdhci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/zynq_sdhci.c b/drivers/mmc/zynq_sdhci.c > index 7dcf6ad842..be4075c97a 100644 > --- a/drivers/mmc/zynq_sdhci.c > +++ b/drivers/mmc/zynq_sdhci.c > @@ -249,7 +249,7 @@ static int arasan_sdhci_execute_tuning(struct mmc *mmc, u8 opcode) > u32 ctrl; > struct sdhci_host *host; > struct arasan_sdhci_priv *priv = dev_get_priv(mmc->dev); > - char tuning_loop_counter = SDHCI_TUNING_LOOP_COUNT; > + int tuning_loop_counter = SDHCI_TUNING_LOOP_COUNT; > > dev_dbg(mmc->dev, "%s\n", __func__); >