From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F34CC4743D for ; Tue, 8 Jun 2021 12:30:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 07A1E6128E for ; Tue, 8 Jun 2021 12:30:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232630AbhFHMch (ORCPT ); Tue, 8 Jun 2021 08:32:37 -0400 Received: from szxga03-in.huawei.com ([45.249.212.189]:5334 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232614AbhFHMcY (ORCPT ); Tue, 8 Jun 2021 08:32:24 -0400 Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.57]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4FzqH36Ycpz6ttB; Tue, 8 Jun 2021 20:26:39 +0800 (CST) Received: from dggpeml500019.china.huawei.com (7.185.36.137) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 8 Jun 2021 20:30:29 +0800 Received: from [10.174.179.189] (10.174.179.189) by dggpeml500019.china.huawei.com (7.185.36.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 8 Jun 2021 20:30:28 +0800 Subject: Re: [PATCH] nvme-multipath: combine grpid and ANA state checks in nvme_parse_ana_log() To: Christoph Hellwig CC: , , , , , References: <1623125616-629270-1-git-send-email-wubo40@huawei.com> <20210608052320.GA13828@lst.de> From: Wu Bo Message-ID: <3a243d2c-f9b9-edcf-1762-9b08cf21f152@huawei.com> Date: Tue, 8 Jun 2021 20:30:14 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.2.2 MIME-Version: 1.0 In-Reply-To: <20210608052320.GA13828@lst.de> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.189] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpeml500019.china.huawei.com (7.185.36.137) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/6/8 13:23, Christoph Hellwig wrote: > On Tue, Jun 08, 2021 at 12:13:36PM +0800, Wu Bo wrote: >> - if (WARN_ON_ONCE(desc->grpid == 0)) >> + if (WARN_ON_ONCE(desc->grpid == 0 || >> + le32_to_cpu(desc->grpid) > ctrl->anagrpmax)) >> return -EINVAL; >> - if (WARN_ON_ONCE(le32_to_cpu(desc->grpid) > ctrl->anagrpmax)) >> - return -EINVAL; >> - if (WARN_ON_ONCE(desc->state == 0)) >> - return -EINVAL; >> - if (WARN_ON_ONCE(desc->state > NVME_ANA_CHANGE)) >> + if (WARN_ON_ONCE(desc->state == 0 || >> + desc->state > NVME_ANA_CHANGE)) > > So besides making the code impossibl to read due to the incorrect > indentation this also makes each WARN_ON_ONCE cover multiple conditions. > Not very useful for debugging. > Indeed, not very useful for debugging, please ignore this patch. Thanks, Wu Bo > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1F7CC47082 for ; Tue, 8 Jun 2021 12:43:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6ED7561078 for ; Tue, 8 Jun 2021 12:43:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6ED7561078 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TJHyYOShAYF3/zIbn58VzKpRUL9F3bsltKGEQ8JRcGk=; b=2JcuJnLRWBuy4a9pxVxayEoxga PdCSbR7TfhZQyp9gF/2wucP//DVI/bnUj2GT1Im1lDKG93XO6SohyU8nQHg6FELJz70bNnRiuv6Pl OA2TcTKAfd2BF/flm+RLn7woxmy5CbvUfv2aguN9QoEQPFKhHWp5Z42W2PSvRURczrmOWI4jU7eiA KLpdOp3z+SUdEziJav73hFZ5WYVYPsuhN4Nf7LwlwyY22qfl2Bs6M9sDqkoUOAUqLSostBJenbcN/ BcUMDqZCL1RzURvhMMvFRYS7C+BcQ+Whfj9rioROzdmA1wyE+Jnw750daEHxh24k650N5A22h82IE 7T62ojcA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqb4T-008R0I-62; Tue, 08 Jun 2021 12:43:05 +0000 Received: from szxga03-in.huawei.com ([45.249.212.189]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqasN-008MBL-3d for linux-nvme@lists.infradead.org; Tue, 08 Jun 2021 12:30:38 +0000 Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.57]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4FzqH36Ycpz6ttB; Tue, 8 Jun 2021 20:26:39 +0800 (CST) Received: from dggpeml500019.china.huawei.com (7.185.36.137) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 8 Jun 2021 20:30:29 +0800 Received: from [10.174.179.189] (10.174.179.189) by dggpeml500019.china.huawei.com (7.185.36.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 8 Jun 2021 20:30:28 +0800 Subject: Re: [PATCH] nvme-multipath: combine grpid and ANA state checks in nvme_parse_ana_log() To: Christoph Hellwig CC: , , , , , References: <1623125616-629270-1-git-send-email-wubo40@huawei.com> <20210608052320.GA13828@lst.de> From: Wu Bo Message-ID: <3a243d2c-f9b9-edcf-1762-9b08cf21f152@huawei.com> Date: Tue, 8 Jun 2021 20:30:14 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.2.2 MIME-Version: 1.0 In-Reply-To: <20210608052320.GA13828@lst.de> Content-Language: en-US X-Originating-IP: [10.174.179.189] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpeml500019.china.huawei.com (7.185.36.137) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210608_053035_385782_253AB794 X-CRM114-Status: UNSURE ( 9.99 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On 2021/6/8 13:23, Christoph Hellwig wrote: > On Tue, Jun 08, 2021 at 12:13:36PM +0800, Wu Bo wrote: >> - if (WARN_ON_ONCE(desc->grpid == 0)) >> + if (WARN_ON_ONCE(desc->grpid == 0 || >> + le32_to_cpu(desc->grpid) > ctrl->anagrpmax)) >> return -EINVAL; >> - if (WARN_ON_ONCE(le32_to_cpu(desc->grpid) > ctrl->anagrpmax)) >> - return -EINVAL; >> - if (WARN_ON_ONCE(desc->state == 0)) >> - return -EINVAL; >> - if (WARN_ON_ONCE(desc->state > NVME_ANA_CHANGE)) >> + if (WARN_ON_ONCE(desc->state == 0 || >> + desc->state > NVME_ANA_CHANGE)) > > So besides making the code impossibl to read due to the incorrect > indentation this also makes each WARN_ON_ONCE cover multiple conditions. > Not very useful for debugging. > Indeed, not very useful for debugging, please ignore this patch. Thanks, Wu Bo > _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme