From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5104C433E0 for ; Thu, 25 Feb 2021 14:06:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7FCCF64F16 for ; Thu, 25 Feb 2021 14:06:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230467AbhBYOGi (ORCPT ); Thu, 25 Feb 2021 09:06:38 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:43614 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231248AbhBYOG0 (ORCPT ); Thu, 25 Feb 2021 09:06:26 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: ezequiel) with ESMTPSA id 439961F4617B Message-ID: <3a2b4d06a363541c475dbc1bbf61d90b3a1b0cc0.camel@collabora.com> Subject: Re: [PATCH v3 4/9] media: uapi: Add a control for HANTRO driver From: Ezequiel Garcia To: Benjamin Gaignard , p.zabel@pengutronix.de, mchehab@kernel.org, robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, gregkh@linuxfoundation.org, mripard@kernel.org, paul.kocialkowski@bootlin.com, wens@csie.org, jernej.skrabec@siol.net, peng.fan@nxp.com, hverkuil-cisco@xs4all.nl, dan.carpenter@oracle.com Cc: linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@collabora.com Date: Thu, 25 Feb 2021 11:05:32 -0300 In-Reply-To: <20210222122406.41782-5-benjamin.gaignard@collabora.com> References: <20210222122406.41782-1-benjamin.gaignard@collabora.com> <20210222122406.41782-5-benjamin.gaignard@collabora.com> Organization: Collabora Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.2-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Benjamin, On Mon, 2021-02-22 at 13:24 +0100, Benjamin Gaignard wrote: > The HEVC HANTRO driver needs to know the number of bits to skip at s/HANTRO/Hantro > the beginning of the slice header. As discussed in a different thread, we should describe exactly what the hardware is expecting, so applications can parse that and pass a correct value. > That is a hardware specific requirement so create a dedicated control > that this purpose. > > Signed-off-by: Benjamin Gaignard > --- > version 3: > - Fix typo in field name > >  include/uapi/linux/hantro-v4l2-controls.h | 20 ++++++++++++++++++++ >  include/uapi/linux/v4l2-controls.h        |  5 +++++ >  2 files changed, 25 insertions(+) >  create mode 100644 include/uapi/linux/hantro-v4l2-controls.h > > diff --git a/include/uapi/linux/hantro-v4l2-controls.h b/include/uapi/linux/hantro-v4l2-controls.h > new file mode 100644 > index 000000000000..a8dfd6b1a2a9 > --- /dev/null > +++ b/include/uapi/linux/hantro-v4l2-controls.h > @@ -0,0 +1,20 @@ > +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ > + > +#ifndef __UAPI_HANTRO_V4L2_CONYTROLS_H__ > +#define __UAPI_HANTRO_V4L2_CONYTROLS_H__ > + > +#include > +#include > + > +#define V4L2_CID_HANTRO_HEVC_EXTRA_DECODE_PARAMS       (V4L2_CID_USER_HANTRO_BASE + 0) > + > +/** > + * struct hantro_hevc_extra_decode_params - extra decode parameters for hantro driver > + * @hevc_hdr_skip_length:      header first bits offset > + */ > +struct hantro_hevc_extra_decode_params { > +       __u32   hevc_hdr_skip_length; > +       __u8    padding[4]; > +}; > + I think we can get away with a simpler solution. Since it's just one integer we need, there's no need for a compound control. Something like this: .codec = HANTRO_HEVC_DECODER, .cfg = { .id = V4L2_CID_HANTRO_HEVC_SLICE_HEADER_SKIP, .name = "Hantro HEVC slice header skip bytes", .type = V4L2_CTRL_TYPE_INTEGER, .min = 0, .max = 0x7fffffff, .step = 1, }, Also see V4L2_CID_CODA_MB_ERR_CNT which is defined in drivers/media/platform/coda/coda.h. The control is sufficiently special that it could be kept in an internal driver header. > +#endif > diff --git a/include/uapi/linux/v4l2-controls.h b/include/uapi/linux/v4l2-controls.h > index 039c0d7add1b..ced7486c7f46 100644 > --- a/include/uapi/linux/v4l2-controls.h > +++ b/include/uapi/linux/v4l2-controls.h > @@ -209,6 +209,11 @@ enum v4l2_colorfx { >   * We reserve 128 controls for this driver. >   */ >  #define V4L2_CID_USER_CCS_BASE                 (V4L2_CID_USER_BASE + 0x10f0) > +/* > + * The base for HANTRO driver controls. > + * We reserve 32 controls for this driver. > + */ > +#define V4L2_CID_USER_HANTRO_BASE              (V4L2_CID_USER_BASE + 0x1170) >   >  /* MPEG-class control IDs */ >  /* The MPEG controls are applicable to all codec controls Thanks, Ezequiel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECEE0C433DB for ; Thu, 25 Feb 2021 14:05:53 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8FB2264EC3 for ; Thu, 25 Feb 2021 14:05:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8FB2264EC3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QxYSdEO1bhT45M+wU8rrulhcDyBuxZg8R7RABgsD/cI=; b=hri3dFs/z1tWuch8FFrvS0RQ+ /bRykeZJJNbNKyXOt4WCSSTxGsg7JtnbBmuiYMKZsjoJe0AEryQdpXj6q3eYp5ue/RNF0puD+met9 AfDmrcoJeV8DV2yMbQpkbKA6LMg1thYbP5Kib9ynCLOVuA/7DcyU4HHRKnAW+KguCU/37Jo16w2ZU /vxc3mCvP1Th+i9rz0xh9t72He5bH6H4O9dSQAxX8jR+5vn3Z1eVq8Yx6lFmvt2Em+Jy4gsE2jUVW roJtcNJWVM8KDjI+yIDfkHCJV6WMpUpfWEyC33QEstOFQZRkfT/V3v+bX1cKAdDadUiI7Nv3YA5jq eNKUnveCQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lFHH4-0006Wn-Ul; Thu, 25 Feb 2021 14:05:50 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lFHH0-0006VO-5I; Thu, 25 Feb 2021 14:05:47 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: ezequiel) with ESMTPSA id 439961F4617B Message-ID: <3a2b4d06a363541c475dbc1bbf61d90b3a1b0cc0.camel@collabora.com> Subject: Re: [PATCH v3 4/9] media: uapi: Add a control for HANTRO driver From: Ezequiel Garcia To: Benjamin Gaignard , p.zabel@pengutronix.de, mchehab@kernel.org, robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, gregkh@linuxfoundation.org, mripard@kernel.org, paul.kocialkowski@bootlin.com, wens@csie.org, jernej.skrabec@siol.net, peng.fan@nxp.com, hverkuil-cisco@xs4all.nl, dan.carpenter@oracle.com Date: Thu, 25 Feb 2021 11:05:32 -0300 In-Reply-To: <20210222122406.41782-5-benjamin.gaignard@collabora.com> References: <20210222122406.41782-1-benjamin.gaignard@collabora.com> <20210222122406.41782-5-benjamin.gaignard@collabora.com> Organization: Collabora User-Agent: Evolution 3.38.2-1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210225_090546_600221_8104B049 X-CRM114-Status: GOOD ( 22.54 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, kernel@collabora.com, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org SGkgQmVuamFtaW4sCgpPbiBNb24sIDIwMjEtMDItMjIgYXQgMTM6MjQgKzAxMDAsIEJlbmphbWlu IEdhaWduYXJkIHdyb3RlOgo+IFRoZSBIRVZDIEhBTlRSTyBkcml2ZXIgbmVlZHMgdG8ga25vdyB0 aGUgbnVtYmVyIG9mIGJpdHMgdG8gc2tpcCBhdAoKcy9IQU5UUk8vSGFudHJvCgo+IHRoZSBiZWdp bm5pbmcgb2YgdGhlIHNsaWNlIGhlYWRlci4KCkFzIGRpc2N1c3NlZCBpbiBhIGRpZmZlcmVudCB0 aHJlYWQsIHdlIHNob3VsZCBkZXNjcmliZSBleGFjdGx5CndoYXQgdGhlIGhhcmR3YXJlIGlzIGV4 cGVjdGluZywgc28gYXBwbGljYXRpb25zIGNhbiBwYXJzZSB0aGF0CmFuZCBwYXNzIGEgY29ycmVj dCB2YWx1ZS4KCj4gVGhhdCBpcyBhIGhhcmR3YXJlIHNwZWNpZmljIHJlcXVpcmVtZW50IHNvIGNy ZWF0ZSBhIGRlZGljYXRlZCBjb250cm9sCj4gdGhhdCB0aGlzIHB1cnBvc2UuCj4gCj4gU2lnbmVk LW9mZi1ieTogQmVuamFtaW4gR2FpZ25hcmQgPGJlbmphbWluLmdhaWduYXJkQGNvbGxhYm9yYS5j b20+Cj4gLS0tCj4gdmVyc2lvbiAzOgo+IC0gRml4IHR5cG8gaW4gZmllbGQgbmFtZQo+IAo+IMKg aW5jbHVkZS91YXBpL2xpbnV4L2hhbnRyby12NGwyLWNvbnRyb2xzLmggfCAyMCArKysrKysrKysr KysrKysrKysrKwo+IMKgaW5jbHVkZS91YXBpL2xpbnV4L3Y0bDItY29udHJvbHMuaMKgwqDCoMKg wqDCoMKgIHzCoCA1ICsrKysrCj4gwqAyIGZpbGVzIGNoYW5nZWQsIDI1IGluc2VydGlvbnMoKykK PiDCoGNyZWF0ZSBtb2RlIDEwMDY0NCBpbmNsdWRlL3VhcGkvbGludXgvaGFudHJvLXY0bDItY29u dHJvbHMuaAo+IAo+IGRpZmYgLS1naXQgYS9pbmNsdWRlL3VhcGkvbGludXgvaGFudHJvLXY0bDIt Y29udHJvbHMuaCBiL2luY2x1ZGUvdWFwaS9saW51eC9oYW50cm8tdjRsMi1jb250cm9scy5oCj4g bmV3IGZpbGUgbW9kZSAxMDA2NDQKPiBpbmRleCAwMDAwMDAwMDAwMDAuLmE4ZGZkNmIxYTJhOQo+ IC0tLSAvZGV2L251bGwKPiArKysgYi9pbmNsdWRlL3VhcGkvbGludXgvaGFudHJvLXY0bDItY29u dHJvbHMuaAo+IEBAIC0wLDAgKzEsMjAgQEAKPiArLyogU1BEWC1MaWNlbnNlLUlkZW50aWZpZXI6 IEdQTC0yLjAgV0lUSCBMaW51eC1zeXNjYWxsLW5vdGUgKi8KPiArCj4gKyNpZm5kZWYgX19VQVBJ X0hBTlRST19WNEwyX0NPTllUUk9MU19IX18KPiArI2RlZmluZSBfX1VBUElfSEFOVFJPX1Y0TDJf Q09OWVRST0xTX0hfXwo+ICsKPiArI2luY2x1ZGUgPGxpbnV4L3Y0bDItY29udHJvbHMuaD4KPiAr I2luY2x1ZGUgPG1lZGlhL2hldmMtY3RybHMuaD4KPiArCj4gKyNkZWZpbmUgVjRMMl9DSURfSEFO VFJPX0hFVkNfRVhUUkFfREVDT0RFX1BBUkFNU8KgwqDCoMKgwqDCoMKgKFY0TDJfQ0lEX1VTRVJf SEFOVFJPX0JBU0UgKyAwKQo+ICsKPiArLyoqCj4gKyAqIHN0cnVjdCBoYW50cm9faGV2Y19leHRy YV9kZWNvZGVfcGFyYW1zIC0gZXh0cmEgZGVjb2RlIHBhcmFtZXRlcnMgZm9yIGhhbnRybyBkcml2 ZXIKPiArICogQGhldmNfaGRyX3NraXBfbGVuZ3RoOsKgwqDCoMKgwqDCoGhlYWRlciBmaXJzdCBi aXRzIG9mZnNldAo+ICsgKi8KPiArc3RydWN0IGhhbnRyb19oZXZjX2V4dHJhX2RlY29kZV9wYXJh bXMgewo+ICvCoMKgwqDCoMKgwqDCoF9fdTMywqDCoMKgaGV2Y19oZHJfc2tpcF9sZW5ndGg7Cj4g K8KgwqDCoMKgwqDCoMKgX191OMKgwqDCoMKgcGFkZGluZ1s0XTsKPiArfTsKPiArCgpJIHRoaW5r IHdlIGNhbiBnZXQgYXdheSB3aXRoIGEgc2ltcGxlciBzb2x1dGlvbi4gU2luY2UgaXQncyBqdXN0 IG9uZSBpbnRlZ2VyCndlIG5lZWQsIHRoZXJlJ3Mgbm8gbmVlZCBmb3IgYSBjb21wb3VuZCBjb250 cm9sLiBTb21ldGhpbmcgbGlrZSB0aGlzOgoKICAgICAgICAgICAgICAgIC5jb2RlYyA9IEhBTlRS T19IRVZDX0RFQ09ERVIsICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgCiAgICAg ICAgICAgICAgICAuY2ZnID0geyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIAogICAgICAgICAgICAgICAgICAgICAgICAuaWQgPSBWNEwyX0NJ RF9IQU5UUk9fSEVWQ19TTElDRV9IRUFERVJfU0tJUCwgICAgICAgICAgICAKICAgICAgICAgICAg ICAgICAgICAgICAgLm5hbWUgPSAiSGFudHJvIEhFVkMgc2xpY2UgaGVhZGVyIHNraXAgYnl0ZXMi LCAgICAgICAgICAgCiAgICAgICAgICAgICAgICAgICAgICAgIC50eXBlID0gVjRMMl9DVFJMX1RZ UEVfSU5URUdFUiwgICAgICAgICAgICAgICAgICAgICAgICAgIAogICAgICAgICAgICAgICAgICAg ICAgICAubWluID0gMCwgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAKICAgICAgICAgICAgICAgICAgICAgICAgLm1heCA9IDB4N2ZmZmZmZmYsICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgCiAgICAgICAgICAgICAgICAgICAgICAgIC5z dGVwID0gMSwgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIAog ICAgICAgICAgICAgICAgfSwgICAgIAoKQWxzbyBzZWUgVjRMMl9DSURfQ09EQV9NQl9FUlJfQ05U IHdoaWNoIGlzIGRlZmluZWQgaW4gZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9jb2RhL2NvZGEuaC4K VGhlIGNvbnRyb2wgaXMgc3VmZmljaWVudGx5IHNwZWNpYWwgdGhhdCBpdCBjb3VsZCBiZSBrZXB0 IGluIGFuIGludGVybmFsIGRyaXZlciBoZWFkZXIuCgo+ICsjZW5kaWYKPiBkaWZmIC0tZ2l0IGEv aW5jbHVkZS91YXBpL2xpbnV4L3Y0bDItY29udHJvbHMuaCBiL2luY2x1ZGUvdWFwaS9saW51eC92 NGwyLWNvbnRyb2xzLmgKPiBpbmRleCAwMzljMGQ3YWRkMWIuLmNlZDc0ODZjN2Y0NiAxMDA2NDQK PiAtLS0gYS9pbmNsdWRlL3VhcGkvbGludXgvdjRsMi1jb250cm9scy5oCj4gKysrIGIvaW5jbHVk ZS91YXBpL2xpbnV4L3Y0bDItY29udHJvbHMuaAo+IEBAIC0yMDksNiArMjA5LDExIEBAIGVudW0g djRsMl9jb2xvcmZ4IHsKPiDCoCAqIFdlIHJlc2VydmUgMTI4IGNvbnRyb2xzIGZvciB0aGlzIGRy aXZlci4KPiDCoCAqLwo+IMKgI2RlZmluZSBWNEwyX0NJRF9VU0VSX0NDU19CQVNFwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoChWNEwyX0NJRF9VU0VSX0JBU0UgKyAweDEwZjApCj4g Ky8qCj4gKyAqIFRoZSBiYXNlIGZvciBIQU5UUk8gZHJpdmVyIGNvbnRyb2xzLgo+ICsgKiBXZSBy ZXNlcnZlIDMyIGNvbnRyb2xzIGZvciB0aGlzIGRyaXZlci4KPiArICovCj4gKyNkZWZpbmUgVjRM Ml9DSURfVVNFUl9IQU5UUk9fQkFTRcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAoVjRMMl9D SURfVVNFUl9CQVNFICsgMHgxMTcwKQo+IMKgCj4gwqAvKiBNUEVHLWNsYXNzIGNvbnRyb2wgSURz ICovCj4gwqAvKiBUaGUgTVBFRyBjb250cm9scyBhcmUgYXBwbGljYWJsZSB0byBhbGwgY29kZWMg Y29udHJvbHMKClRoYW5rcywKRXplcXVpZWwKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpMaW51eC1yb2NrY2hpcCBtYWlsaW5nIGxpc3QKTGludXgtcm9j a2NoaXBAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LXJvY2tjaGlwCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 791F5C433E0 for ; Thu, 25 Feb 2021 14:07:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 15BCD64EC3 for ; Thu, 25 Feb 2021 14:07:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 15BCD64EC3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PF6cJjFZajf1S6QsfJ8sUuwm1v2JBMEMuVmc3D5jclg=; b=wqzHAgzaGMSmnNnUmLIeAhX4W CX5R7c5+3Gw5NZ+pE505CJuaBBdCdfuRTMkDkuMA4MXbEPdCxCRyVNsSq9psXzXCVvMRMSDbYimZw aEEwc+p1nNnr1MaMgcW1X5yWg6Lf4GPyggBqUqJSe/Ke5m6fL7DrlK2667C83ZIAxYqWY2i+bY0v9 nPqJNIVWIogyhs9x+gCA/6D/WfzKFdl2T9n2DcSnJFjHlRkNhHiVuUfXEJZZkMJHB1sXhys8F3iiz RUfSi3kZ3ORvPn6HDMm4a3MmNud7nYiT407MSaqnH/ZUOMAMWgclEd5ZwPXoSshPnzCeNpWmynPx/ fURmQcmLw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lFHH3-0006WC-43; Thu, 25 Feb 2021 14:05:49 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lFHH0-0006VO-5I; Thu, 25 Feb 2021 14:05:47 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: ezequiel) with ESMTPSA id 439961F4617B Message-ID: <3a2b4d06a363541c475dbc1bbf61d90b3a1b0cc0.camel@collabora.com> Subject: Re: [PATCH v3 4/9] media: uapi: Add a control for HANTRO driver From: Ezequiel Garcia To: Benjamin Gaignard , p.zabel@pengutronix.de, mchehab@kernel.org, robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, gregkh@linuxfoundation.org, mripard@kernel.org, paul.kocialkowski@bootlin.com, wens@csie.org, jernej.skrabec@siol.net, peng.fan@nxp.com, hverkuil-cisco@xs4all.nl, dan.carpenter@oracle.com Date: Thu, 25 Feb 2021 11:05:32 -0300 In-Reply-To: <20210222122406.41782-5-benjamin.gaignard@collabora.com> References: <20210222122406.41782-1-benjamin.gaignard@collabora.com> <20210222122406.41782-5-benjamin.gaignard@collabora.com> Organization: Collabora User-Agent: Evolution 3.38.2-1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210225_090546_600221_8104B049 X-CRM114-Status: GOOD ( 22.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, kernel@collabora.com, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgQmVuamFtaW4sCgpPbiBNb24sIDIwMjEtMDItMjIgYXQgMTM6MjQgKzAxMDAsIEJlbmphbWlu IEdhaWduYXJkIHdyb3RlOgo+IFRoZSBIRVZDIEhBTlRSTyBkcml2ZXIgbmVlZHMgdG8ga25vdyB0 aGUgbnVtYmVyIG9mIGJpdHMgdG8gc2tpcCBhdAoKcy9IQU5UUk8vSGFudHJvCgo+IHRoZSBiZWdp bm5pbmcgb2YgdGhlIHNsaWNlIGhlYWRlci4KCkFzIGRpc2N1c3NlZCBpbiBhIGRpZmZlcmVudCB0 aHJlYWQsIHdlIHNob3VsZCBkZXNjcmliZSBleGFjdGx5CndoYXQgdGhlIGhhcmR3YXJlIGlzIGV4 cGVjdGluZywgc28gYXBwbGljYXRpb25zIGNhbiBwYXJzZSB0aGF0CmFuZCBwYXNzIGEgY29ycmVj dCB2YWx1ZS4KCj4gVGhhdCBpcyBhIGhhcmR3YXJlIHNwZWNpZmljIHJlcXVpcmVtZW50IHNvIGNy ZWF0ZSBhIGRlZGljYXRlZCBjb250cm9sCj4gdGhhdCB0aGlzIHB1cnBvc2UuCj4gCj4gU2lnbmVk LW9mZi1ieTogQmVuamFtaW4gR2FpZ25hcmQgPGJlbmphbWluLmdhaWduYXJkQGNvbGxhYm9yYS5j b20+Cj4gLS0tCj4gdmVyc2lvbiAzOgo+IC0gRml4IHR5cG8gaW4gZmllbGQgbmFtZQo+IAo+IMKg aW5jbHVkZS91YXBpL2xpbnV4L2hhbnRyby12NGwyLWNvbnRyb2xzLmggfCAyMCArKysrKysrKysr KysrKysrKysrKwo+IMKgaW5jbHVkZS91YXBpL2xpbnV4L3Y0bDItY29udHJvbHMuaMKgwqDCoMKg wqDCoMKgIHzCoCA1ICsrKysrCj4gwqAyIGZpbGVzIGNoYW5nZWQsIDI1IGluc2VydGlvbnMoKykK PiDCoGNyZWF0ZSBtb2RlIDEwMDY0NCBpbmNsdWRlL3VhcGkvbGludXgvaGFudHJvLXY0bDItY29u dHJvbHMuaAo+IAo+IGRpZmYgLS1naXQgYS9pbmNsdWRlL3VhcGkvbGludXgvaGFudHJvLXY0bDIt Y29udHJvbHMuaCBiL2luY2x1ZGUvdWFwaS9saW51eC9oYW50cm8tdjRsMi1jb250cm9scy5oCj4g bmV3IGZpbGUgbW9kZSAxMDA2NDQKPiBpbmRleCAwMDAwMDAwMDAwMDAuLmE4ZGZkNmIxYTJhOQo+ IC0tLSAvZGV2L251bGwKPiArKysgYi9pbmNsdWRlL3VhcGkvbGludXgvaGFudHJvLXY0bDItY29u dHJvbHMuaAo+IEBAIC0wLDAgKzEsMjAgQEAKPiArLyogU1BEWC1MaWNlbnNlLUlkZW50aWZpZXI6 IEdQTC0yLjAgV0lUSCBMaW51eC1zeXNjYWxsLW5vdGUgKi8KPiArCj4gKyNpZm5kZWYgX19VQVBJ X0hBTlRST19WNEwyX0NPTllUUk9MU19IX18KPiArI2RlZmluZSBfX1VBUElfSEFOVFJPX1Y0TDJf Q09OWVRST0xTX0hfXwo+ICsKPiArI2luY2x1ZGUgPGxpbnV4L3Y0bDItY29udHJvbHMuaD4KPiAr I2luY2x1ZGUgPG1lZGlhL2hldmMtY3RybHMuaD4KPiArCj4gKyNkZWZpbmUgVjRMMl9DSURfSEFO VFJPX0hFVkNfRVhUUkFfREVDT0RFX1BBUkFNU8KgwqDCoMKgwqDCoMKgKFY0TDJfQ0lEX1VTRVJf SEFOVFJPX0JBU0UgKyAwKQo+ICsKPiArLyoqCj4gKyAqIHN0cnVjdCBoYW50cm9faGV2Y19leHRy YV9kZWNvZGVfcGFyYW1zIC0gZXh0cmEgZGVjb2RlIHBhcmFtZXRlcnMgZm9yIGhhbnRybyBkcml2 ZXIKPiArICogQGhldmNfaGRyX3NraXBfbGVuZ3RoOsKgwqDCoMKgwqDCoGhlYWRlciBmaXJzdCBi aXRzIG9mZnNldAo+ICsgKi8KPiArc3RydWN0IGhhbnRyb19oZXZjX2V4dHJhX2RlY29kZV9wYXJh bXMgewo+ICvCoMKgwqDCoMKgwqDCoF9fdTMywqDCoMKgaGV2Y19oZHJfc2tpcF9sZW5ndGg7Cj4g K8KgwqDCoMKgwqDCoMKgX191OMKgwqDCoMKgcGFkZGluZ1s0XTsKPiArfTsKPiArCgpJIHRoaW5r IHdlIGNhbiBnZXQgYXdheSB3aXRoIGEgc2ltcGxlciBzb2x1dGlvbi4gU2luY2UgaXQncyBqdXN0 IG9uZSBpbnRlZ2VyCndlIG5lZWQsIHRoZXJlJ3Mgbm8gbmVlZCBmb3IgYSBjb21wb3VuZCBjb250 cm9sLiBTb21ldGhpbmcgbGlrZSB0aGlzOgoKICAgICAgICAgICAgICAgIC5jb2RlYyA9IEhBTlRS T19IRVZDX0RFQ09ERVIsICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgCiAgICAg ICAgICAgICAgICAuY2ZnID0geyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIAogICAgICAgICAgICAgICAgICAgICAgICAuaWQgPSBWNEwyX0NJ RF9IQU5UUk9fSEVWQ19TTElDRV9IRUFERVJfU0tJUCwgICAgICAgICAgICAKICAgICAgICAgICAg ICAgICAgICAgICAgLm5hbWUgPSAiSGFudHJvIEhFVkMgc2xpY2UgaGVhZGVyIHNraXAgYnl0ZXMi LCAgICAgICAgICAgCiAgICAgICAgICAgICAgICAgICAgICAgIC50eXBlID0gVjRMMl9DVFJMX1RZ UEVfSU5URUdFUiwgICAgICAgICAgICAgICAgICAgICAgICAgIAogICAgICAgICAgICAgICAgICAg ICAgICAubWluID0gMCwgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAKICAgICAgICAgICAgICAgICAgICAgICAgLm1heCA9IDB4N2ZmZmZmZmYsICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgCiAgICAgICAgICAgICAgICAgICAgICAgIC5z dGVwID0gMSwgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIAog ICAgICAgICAgICAgICAgfSwgICAgIAoKQWxzbyBzZWUgVjRMMl9DSURfQ09EQV9NQl9FUlJfQ05U IHdoaWNoIGlzIGRlZmluZWQgaW4gZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9jb2RhL2NvZGEuaC4K VGhlIGNvbnRyb2wgaXMgc3VmZmljaWVudGx5IHNwZWNpYWwgdGhhdCBpdCBjb3VsZCBiZSBrZXB0 IGluIGFuIGludGVybmFsIGRyaXZlciBoZWFkZXIuCgo+ICsjZW5kaWYKPiBkaWZmIC0tZ2l0IGEv aW5jbHVkZS91YXBpL2xpbnV4L3Y0bDItY29udHJvbHMuaCBiL2luY2x1ZGUvdWFwaS9saW51eC92 NGwyLWNvbnRyb2xzLmgKPiBpbmRleCAwMzljMGQ3YWRkMWIuLmNlZDc0ODZjN2Y0NiAxMDA2NDQK PiAtLS0gYS9pbmNsdWRlL3VhcGkvbGludXgvdjRsMi1jb250cm9scy5oCj4gKysrIGIvaW5jbHVk ZS91YXBpL2xpbnV4L3Y0bDItY29udHJvbHMuaAo+IEBAIC0yMDksNiArMjA5LDExIEBAIGVudW0g djRsMl9jb2xvcmZ4IHsKPiDCoCAqIFdlIHJlc2VydmUgMTI4IGNvbnRyb2xzIGZvciB0aGlzIGRy aXZlci4KPiDCoCAqLwo+IMKgI2RlZmluZSBWNEwyX0NJRF9VU0VSX0NDU19CQVNFwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoChWNEwyX0NJRF9VU0VSX0JBU0UgKyAweDEwZjApCj4g Ky8qCj4gKyAqIFRoZSBiYXNlIGZvciBIQU5UUk8gZHJpdmVyIGNvbnRyb2xzLgo+ICsgKiBXZSBy ZXNlcnZlIDMyIGNvbnRyb2xzIGZvciB0aGlzIGRyaXZlci4KPiArICovCj4gKyNkZWZpbmUgVjRM Ml9DSURfVVNFUl9IQU5UUk9fQkFTRcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAoVjRMMl9D SURfVVNFUl9CQVNFICsgMHgxMTcwKQo+IMKgCj4gwqAvKiBNUEVHLWNsYXNzIGNvbnRyb2wgSURz ICovCj4gwqAvKiBUaGUgTVBFRyBjb250cm9scyBhcmUgYXBwbGljYWJsZSB0byBhbGwgY29kZWMg Y29udHJvbHMKClRoYW5rcywKRXplcXVpZWwKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1h cm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcv bWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==