All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geliang Tang <geliang.tang@suse.com>
To: mptcp@lists.linux.dev
Cc: Geliang Tang <geliang.tang@suse.com>
Subject: [PATCH mptcp-next v2 2/3] selftests: mptcp: add the port argument for set_flags
Date: Thu, 13 Jan 2022 23:08:32 +0800	[thread overview]
Message-ID: <3a30b5a11c8a7a5b510d99ba65e473344d61ffd2.1642085750.git.geliang.tang@suse.com> (raw)
In-Reply-To: <cover.1642085750.git.geliang.tang@suse.com>

This patch added the port argument for setting the address flags in
pm_nl_ctl.

Usage:

    pm_nl_ctl set 10.0.2.1 flags backup port 10100

Signed-off-by: Geliang Tang <geliang.tang@suse.com>
---
 tools/testing/selftests/net/mptcp/pm_nl_ctl.c | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/tools/testing/selftests/net/mptcp/pm_nl_ctl.c b/tools/testing/selftests/net/mptcp/pm_nl_ctl.c
index 9b6db9d77223..3c449158d821 100644
--- a/tools/testing/selftests/net/mptcp/pm_nl_ctl.c
+++ b/tools/testing/selftests/net/mptcp/pm_nl_ctl.c
@@ -28,7 +28,7 @@ static void syntax(char *argv[])
 	fprintf(stderr, "\tadd [flags signal|subflow|backup|fullmesh] [id <nr>] [dev <name>] <ip>\n");
 	fprintf(stderr, "\tdel <id> [<ip>]\n");
 	fprintf(stderr, "\tget <id>\n");
-	fprintf(stderr, "\tset <ip> [flags backup|nobackup|fullmesh|nofullmesh]\n");
+	fprintf(stderr, "\tset <ip> [flags backup|nobackup|fullmesh|nofullmesh] [port <nr>]\n");
 	fprintf(stderr, "\tflush\n");
 	fprintf(stderr, "\tdump\n");
 	fprintf(stderr, "\tlimits [<rcv addr max> <subflow max>]\n");
@@ -722,6 +722,18 @@ int set_flags(int fd, int pm_family, int argc, char *argv[])
 			rta->rta_len = RTA_LENGTH(4);
 			memcpy(RTA_DATA(rta), &flags, 4);
 			off += NLMSG_ALIGN(rta->rta_len);
+		} else if (!strcmp(argv[arg], "port")) {
+			u_int16_t port;
+
+			if (++arg >= argc)
+				error(1, 0, " missing port value");
+
+			port = atoi(argv[arg]);
+			rta = (void *)(data + off);
+			rta->rta_type = MPTCP_PM_ADDR_ATTR_PORT;
+			rta->rta_len = RTA_LENGTH(2);
+			memcpy(RTA_DATA(rta), &port, 2);
+			off += NLMSG_ALIGN(rta->rta_len);
 		} else {
 			error(1, 0, "unknown keyword %s", argv[arg]);
 		}
-- 
2.31.1


  parent reply	other threads:[~2022-01-13 15:09 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-13 15:08 [PATCH mptcp-next v2 0/3] set_flags port support Geliang Tang
2022-01-13 15:08 ` [PATCH mptcp-next v2 1/3] mptcp: allow to use port and non-signal in set_flags Geliang Tang
2022-01-13 15:08 ` Geliang Tang [this message]
2022-01-13 15:08 ` [PATCH mptcp-next v2 3/3] selftests: mptcp: add backup with port testcase Geliang Tang
2022-01-14  1:13   ` Mat Martineau
2022-01-13 15:08 ` [PATCH mptcp-next v5 0/5] use 'ip mptcp' in selftests Geliang Tang
2022-01-13 15:08   ` [PATCH mptcp-next v5 1/5] selftests: mptcp: add ip mptcp wrappers Geliang Tang
2022-01-13 15:08   ` [PATCH mptcp-next v5 2/5] selftests: mptcp: new approach of getting ID Geliang Tang
2022-01-13 15:08   ` [PATCH mptcp-next v5 3/5] selftests: mptcp: add wrapper for showing addrs Geliang Tang
2022-01-13 15:08   ` [PATCH mptcp-next v5 4/5] selftests: mptcp: add wrapper for setting flags Geliang Tang
2022-01-14  1:22     ` Mat Martineau
2022-01-13 15:08   ` [PATCH mptcp-next v5 5/5] selftests: mptcp: set ip_mptcp in command line Geliang Tang
2022-01-14  1:27   ` [PATCH mptcp-next v5 0/5] use 'ip mptcp' in selftests Mat Martineau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3a30b5a11c8a7a5b510d99ba65e473344d61ffd2.1642085750.git.geliang.tang@suse.com \
    --to=geliang.tang@suse.com \
    --cc=mptcp@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.