From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 612DDC433DF for ; Thu, 2 Jul 2020 19:42:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2FC40206E2 for ; Thu, 2 Jul 2020 19:42:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="PQF+y8KN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726028AbgGBTmr (ORCPT ); Thu, 2 Jul 2020 15:42:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725915AbgGBTmr (ORCPT ); Thu, 2 Jul 2020 15:42:47 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C70AC08C5C1 for ; Thu, 2 Jul 2020 12:42:47 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id f18so29900098wml.3 for ; Thu, 02 Jul 2020 12:42:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=boCB++59YR1MS+YXDEsix8grOvspQ3z1Y08y0ZLgZ3M=; b=PQF+y8KNYwb22Q8KdP3OAcdMJA4IqMbKEHL0VW2HKOSAifxvWv7JV3/2jSaAMwQKmC yyrqxksTOJuDhBpap8LABoL21w9yiPKPgAcBHvQ6mQUqZd1ObsFhLXukaTkela0tkKkY u+xQcjPcxExrm1ORvBwlxnQ2Op6CsKYkAjzms= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=boCB++59YR1MS+YXDEsix8grOvspQ3z1Y08y0ZLgZ3M=; b=TlAudpFjifSpcoXiLaJ8CI9Or4KPdPLNkYZae8fJece5JkXYVUk0emuPF3L3uY4QDf 9UJTw365PsfCTWrctrPjcG54x4BULZMGwXzHpzFQTcVfgHLiBkNH4A5SHjN2cR22svIH zYooRmA5haCcc03Hgv3E975f+oOu7lSMhnA5HGtJR4DGDIKXtd3+9hxiQndcySMVsEbp 6bOiyZztbg78GWS85kD0VKR3bN76am2dH1fF4sO7RVyVsJ1uquA8FQ5KWUAdtjXsnTCJ BwWHvhENoaA561fOsgsypPiEH5dduG23yf0JBvywqiWPA1nB4iKyX4KSfeLZpflbJ/QQ vJ/A== X-Gm-Message-State: AOAM533KVSTzlaW0hRnokyN3M3W95S1Yr5uAtPkuP7NziSS1tWKXNyp5 1mC5P4dUpWFpZfrPcDsNJN78NA== X-Google-Smtp-Source: ABdhPJzMRYhWDDE1A6uTlQOnn160yt2vebFmKVc0TguTYEF2G0upJ3FMfPQL5UatjdrLA7BjMU02Bw== X-Received: by 2002:a7b:c746:: with SMTP id w6mr35078507wmk.171.1593718965566; Thu, 02 Jul 2020 12:42:45 -0700 (PDT) Received: from [10.136.13.65] ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id y6sm11965936wmy.0.2020.07.02.12.42.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2020 12:42:44 -0700 (PDT) Subject: Re: [PATCH 15/15] mmc: host: sdhci-iproc: Tell the compiler that ACPI functions may not be used To: Lee Jones , ulf.hansson@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Adrian Hunter , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com References: <20200701124702.908713-1-lee.jones@linaro.org> <20200701124702.908713-16-lee.jones@linaro.org> From: Scott Branden Message-ID: <3a32b98c-45c6-6f8d-0853-161f91e65b57@broadcom.com> Date: Thu, 2 Jul 2020 12:42:40 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200701124702.908713-16-lee.jones@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lee, On 2020-07-01 5:47 a.m., Lee Jones wrote: > ... as is the case when !CONFIG_ACPI. > > Fixes the following W=1 kernel build warning: > > mmc/host/sdhci-iproc.c:297:36: warning: ‘sdhci_iproc_acpi_ids’ defined but not used [-Wunused-const-variable=] > > Cc: Adrian Hunter > Cc: Ray Jui > Cc: Scott Branden > Cc: bcm-kernel-feedback-list@broadcom.com > Signed-off-by: Lee Jones > --- > drivers/mmc/host/sdhci-iproc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c > index 225603148d7de..9c7d130205edd 100644 > --- a/drivers/mmc/host/sdhci-iproc.c > +++ b/drivers/mmc/host/sdhci-iproc.c > @@ -294,7 +294,7 @@ static const struct of_device_id sdhci_iproc_of_match[] = { > }; > MODULE_DEVICE_TABLE(of, sdhci_iproc_of_match); > Would it better to compile this in if CONFIG_ACPI is defined instead? #if CONFIG_ACPI > -static const struct acpi_device_id sdhci_iproc_acpi_ids[] = { > +static const struct acpi_device_id __maybe_unused sdhci_iproc_acpi_ids[] = { > { .id = "BRCM5871", .driver_data = (kernel_ulong_t)&iproc_cygnus_data }, > { .id = "BRCM5872", .driver_data = (kernel_ulong_t)&iproc_data }, > { /* sentinel */ } From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E274EC433DF for ; Thu, 2 Jul 2020 19:44:17 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A7456206E2 for ; Thu, 2 Jul 2020 19:44:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aBazyqw6"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="PQF+y8KN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A7456206E2 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=B0s7UMpf6nlc6uIoQla8nhdwxHeFISemlISvpwz+Gok=; b=aBazyqw6nOAIEuNSmphxe25VJ 5u3KDISQWD+r3t3/e+aDoSbhhoXmnQ/hN6A+aeom0tenk2m3EaMt9poHTim15x9BtiBF+vwLeZ7xC sdeWJmkzs3IFLPmD3LSPqLMi3oxAAQid+6Bax069AG07zhKpbiezq/FbrhG+2zanyphtrhTTTGkUC rpiXqzsNQXDRqR/KR11Jz+VJH2DgofFQxB6QWNAd8KYI1p1kWm7nahKFvW6RzCkNFAmE1meSQcRdc ZgPemmFXo6sdKlyQ2HZYKPaSpwtSlyWK4qaRrVKu3873XwVMCfSCInQK9jC3FkL/0vkaHfj56Yspb u0XlE2ArA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jr56i-0001tA-Gs; Thu, 02 Jul 2020 19:42:52 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jr56d-0001sb-Mk for linux-arm-kernel@lists.infradead.org; Thu, 02 Jul 2020 19:42:49 +0000 Received: by mail-wm1-x341.google.com with SMTP id l2so28398642wmf.0 for ; Thu, 02 Jul 2020 12:42:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=boCB++59YR1MS+YXDEsix8grOvspQ3z1Y08y0ZLgZ3M=; b=PQF+y8KNYwb22Q8KdP3OAcdMJA4IqMbKEHL0VW2HKOSAifxvWv7JV3/2jSaAMwQKmC yyrqxksTOJuDhBpap8LABoL21w9yiPKPgAcBHvQ6mQUqZd1ObsFhLXukaTkela0tkKkY u+xQcjPcxExrm1ORvBwlxnQ2Op6CsKYkAjzms= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=boCB++59YR1MS+YXDEsix8grOvspQ3z1Y08y0ZLgZ3M=; b=eRLW/1tTLN1ZmWmNgCMN+HRWKQedn6IJryyXQaNQ/3C//EMd6M1l6Zmud3LFHVjTYE uqRCFcgby0OubVRRhQCdzk9FOzxlE3RPXecysMGWNWI1vu28iHcCQzKulsH+09o/EgHp N4tU3CTL1poe8EsM9hPbVmqFyuhlb1WDQih3z1J3J+vEFgXBftkOs9nlHWmnUzuUxmeT J1T4ICWOi7CrTPEt5tiSqvtZwt0VsqFZQjeYlq1dPXULwb9TGgfxudWZaVs+dW1skEmY QV+witmXNdshX8B0HSgrWAMGc45ejORSCZlPEU8PrW7PEy+vH2V7kUqaHcrEnOm+0ZfO kp4g== X-Gm-Message-State: AOAM531NkeyyUdKm63fmh0VfVtNeV2lq9hWiE0UwkOM75ZJr7QdKnOwA KV8bQmWaGzuFwM8yV+lTHcMGjA== X-Google-Smtp-Source: ABdhPJzMRYhWDDE1A6uTlQOnn160yt2vebFmKVc0TguTYEF2G0upJ3FMfPQL5UatjdrLA7BjMU02Bw== X-Received: by 2002:a7b:c746:: with SMTP id w6mr35078507wmk.171.1593718965566; Thu, 02 Jul 2020 12:42:45 -0700 (PDT) Received: from [10.136.13.65] ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id y6sm11965936wmy.0.2020.07.02.12.42.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2020 12:42:44 -0700 (PDT) Subject: Re: [PATCH 15/15] mmc: host: sdhci-iproc: Tell the compiler that ACPI functions may not be used To: Lee Jones , ulf.hansson@linaro.org References: <20200701124702.908713-1-lee.jones@linaro.org> <20200701124702.908713-16-lee.jones@linaro.org> From: Scott Branden Message-ID: <3a32b98c-45c6-6f8d-0853-161f91e65b57@broadcom.com> Date: Thu, 2 Jul 2020 12:42:40 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200701124702.908713-16-lee.jones@linaro.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200702_154247_953956_F662D2A7 X-CRM114-Status: GOOD ( 19.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Scott Branden , Ray Jui , linux-kernel@vger.kernel.org, Adrian Hunter , bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgTGVlLAoKT24gMjAyMC0wNy0wMSA1OjQ3IGEubS4sIExlZSBKb25lcyB3cm90ZToKPiAuLi4g YXMgaXMgdGhlIGNhc2Ugd2hlbiAhQ09ORklHX0FDUEkuCj4KPiBGaXhlcyB0aGUgZm9sbG93aW5n IFc9MSBrZXJuZWwgYnVpbGQgd2FybmluZzoKPgo+ICAgbW1jL2hvc3Qvc2RoY2ktaXByb2MuYzoy OTc6MzY6IHdhcm5pbmc6IOKAmHNkaGNpX2lwcm9jX2FjcGlfaWRz4oCZIGRlZmluZWQgYnV0IG5v dCB1c2VkIFstV3VudXNlZC1jb25zdC12YXJpYWJsZT1dCj4KPiBDYzogQWRyaWFuIEh1bnRlciA8 YWRyaWFuLmh1bnRlckBpbnRlbC5jb20+Cj4gQ2M6IFJheSBKdWkgPHJqdWlAYnJvYWRjb20uY29t Pgo+IENjOiBTY290dCBCcmFuZGVuIDxzYnJhbmRlbkBicm9hZGNvbS5jb20+Cj4gQ2M6IGJjbS1r ZXJuZWwtZmVlZGJhY2stbGlzdEBicm9hZGNvbS5jb20KPiBTaWduZWQtb2ZmLWJ5OiBMZWUgSm9u ZXMgPGxlZS5qb25lc0BsaW5hcm8ub3JnPgo+IC0tLQo+ICAgZHJpdmVycy9tbWMvaG9zdC9zZGhj aS1pcHJvYy5jIHwgMiArLQo+ICAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRl bGV0aW9uKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9tbWMvaG9zdC9zZGhjaS1pcHJvYy5j IGIvZHJpdmVycy9tbWMvaG9zdC9zZGhjaS1pcHJvYy5jCj4gaW5kZXggMjI1NjAzMTQ4ZDdkZS4u OWM3ZDEzMDIwNWVkZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL21tYy9ob3N0L3NkaGNpLWlwcm9j LmMKPiArKysgYi9kcml2ZXJzL21tYy9ob3N0L3NkaGNpLWlwcm9jLmMKPiBAQCAtMjk0LDcgKzI5 NCw3IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3Qgb2ZfZGV2aWNlX2lkIHNkaGNpX2lwcm9jX29mX21h dGNoW10gPSB7Cj4gICB9Owo+ICAgTU9EVUxFX0RFVklDRV9UQUJMRShvZiwgc2RoY2lfaXByb2Nf b2ZfbWF0Y2gpOwo+ICAgCldvdWxkIGl0IGJldHRlciB0byBjb21waWxlIHRoaXMgaW4gaWYgQ09O RklHX0FDUEkgaXMgZGVmaW5lZCBpbnN0ZWFkPwojaWYgQ09ORklHX0FDUEkKPiAtc3RhdGljIGNv bnN0IHN0cnVjdCBhY3BpX2RldmljZV9pZCBzZGhjaV9pcHJvY19hY3BpX2lkc1tdID0gewo+ICtz dGF0aWMgY29uc3Qgc3RydWN0IGFjcGlfZGV2aWNlX2lkIF9fbWF5YmVfdW51c2VkIHNkaGNpX2lw cm9jX2FjcGlfaWRzW10gPSB7Cj4gICAJeyAuaWQgPSAiQlJDTTU4NzEiLCAuZHJpdmVyX2RhdGEg PSAoa2VybmVsX3Vsb25nX3QpJmlwcm9jX2N5Z251c19kYXRhIH0sCj4gICAJeyAuaWQgPSAiQlJD TTU4NzIiLCAuZHJpdmVyX2RhdGEgPSAoa2VybmVsX3Vsb25nX3QpJmlwcm9jX2RhdGEgfSwKPiAg IAl7IC8qIHNlbnRpbmVsICovIH0KCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2Vy bmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1h bi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==