From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E52E7C433DF for ; Mon, 29 Jun 2020 19:24:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C6198206E2 for ; Mon, 29 Jun 2020 19:24:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732238AbgF2TYR (ORCPT ); Mon, 29 Jun 2020 15:24:17 -0400 Received: from mga11.intel.com ([192.55.52.93]:22494 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731371AbgF2TYL (ORCPT ); Mon, 29 Jun 2020 15:24:11 -0400 IronPort-SDR: vrX4EslMBie7dZAu7oLsWfSLBSx4meYM3BFSP8WQRYnABnuFbqCksEp3vLsHZoySWn9csSevmS rfwYJgucNqkw== X-IronPort-AV: E=McAfee;i="6000,8403,9666"; a="144130202" X-IronPort-AV: E=Sophos;i="5.75,294,1589266800"; d="scan'208";a="144130202" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2020 03:02:35 -0700 IronPort-SDR: iMh8vArVq5oKcUs1FZ2st6Xi9hqb9Zp7LxQRW3BbWxsw9h9DLQhK2MvqWpzKdyJo8GaJrgTQm+ +TD8xya/8LSw== X-IronPort-AV: E=Sophos;i="5.75,294,1589266800"; d="scan'208";a="424765568" Received: from aslawinx-mobl1.ger.corp.intel.com (HELO [10.249.138.39]) ([10.249.138.39]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2020 03:02:32 -0700 Subject: Re: [PATCH v4 1/3] ALSA: compress: document the compress audio state machine To: Vinod Koul Cc: alsa-devel@alsa-project.org, Charles Keepax , linux-kernel@vger.kernel.org, Pierre-Louis Bossart , Takashi Iwai , Srinivas Kandagatla References: <20200629075002.11436-1-vkoul@kernel.org> <20200629075002.11436-2-vkoul@kernel.org> <20200629093429.GA2599@vkoul-mobl> From: =?UTF-8?Q?Amadeusz_S=c5=82awi=c5=84ski?= Message-ID: <3a43467a-5432-a3ef-2250-2ac1054539d0@linux.intel.com> Date: Mon, 29 Jun 2020 12:02:30 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200629093429.GA2599@vkoul-mobl> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/29/2020 11:34 AM, Vinod Koul wrote: > > Not sure, this is not in the version I posted, arrow is from setup -> > prepare. See https://lore.kernel.org/alsa-devel/20200629075002.11436-2-vkoul@kernel.org/ > > I don't know how it got reversed in your version, maybe the MUA messed > up?? > Ah... I must have edited it myself when preparing edited version, sorry for noise ;) > a compr_write() moves from SETUP -> PREPARE. Fixing that above looks > better version of mine.. Yes, I feel it is easier to understand, A redirect confused me for a short bit when I first looked at graph and it can be easily avoided. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3BCAC433E0 for ; Mon, 29 Jun 2020 10:03:36 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7080023750 for ; Mon, 29 Jun 2020 10:03:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="JJ97Q8Ol" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7080023750 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D9AF3847; Mon, 29 Jun 2020 12:02:44 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D9AF3847 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1593425015; bh=QQIpsg5pRTbPO4SDaA12RidiMZ10FPepIZFzx29G3fM=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=JJ97Q8Ol2gG3zE9V+3X5ELl2VBi/DhXXdbihFnZU07G7biF5s9F43GpNuP8/fyS9d sBfk/W6IwURmJKfzuzkaxg3HuG4z3Lr1bGvKg5xoSXlrFM27GZAvyxFLZflB2IzzUd 1NZ2tzzhnKPikaRaJ05th1dE26eOwZEqK39ykAZ4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 54845F801F8; Mon, 29 Jun 2020 12:02:44 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 64CE4F8020C; Mon, 29 Jun 2020 12:02:42 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 03FA1F800BA for ; Mon, 29 Jun 2020 12:02:38 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 03FA1F800BA IronPort-SDR: Yq+bGY/b7eQ7myeE254Kp/I1QKkFEv7dwggmg2j7BRJ+xRtu17TOLxJ1NERGWANkqktoO/8mUs 6vYPtiMMA+Og== X-IronPort-AV: E=McAfee;i="6000,8403,9666"; a="134255303" X-IronPort-AV: E=Sophos;i="5.75,294,1589266800"; d="scan'208";a="134255303" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2020 03:02:35 -0700 IronPort-SDR: iMh8vArVq5oKcUs1FZ2st6Xi9hqb9Zp7LxQRW3BbWxsw9h9DLQhK2MvqWpzKdyJo8GaJrgTQm+ +TD8xya/8LSw== X-IronPort-AV: E=Sophos;i="5.75,294,1589266800"; d="scan'208";a="424765568" Received: from aslawinx-mobl1.ger.corp.intel.com (HELO [10.249.138.39]) ([10.249.138.39]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2020 03:02:32 -0700 Subject: Re: [PATCH v4 1/3] ALSA: compress: document the compress audio state machine To: Vinod Koul References: <20200629075002.11436-1-vkoul@kernel.org> <20200629075002.11436-2-vkoul@kernel.org> <20200629093429.GA2599@vkoul-mobl> From: =?UTF-8?Q?Amadeusz_S=c5=82awi=c5=84ski?= Message-ID: <3a43467a-5432-a3ef-2250-2ac1054539d0@linux.intel.com> Date: Mon, 29 Jun 2020 12:02:30 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200629093429.GA2599@vkoul-mobl> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: Pierre-Louis Bossart , alsa-devel@alsa-project.org, Charles Keepax , Takashi Iwai , linux-kernel@vger.kernel.org, Srinivas Kandagatla X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 6/29/2020 11:34 AM, Vinod Koul wrote: > > Not sure, this is not in the version I posted, arrow is from setup -> > prepare. See https://lore.kernel.org/alsa-devel/20200629075002.11436-2-vkoul@kernel.org/ > > I don't know how it got reversed in your version, maybe the MUA messed > up?? > Ah... I must have edited it myself when preparing edited version, sorry for noise ;) > a compr_write() moves from SETUP -> PREPARE. Fixing that above looks > better version of mine.. Yes, I feel it is easier to understand, A redirect confused me for a short bit when I first looked at graph and it can be easily avoided.