From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06B70C49361 for ; Mon, 28 Jun 2021 10:54:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E3073619C3 for ; Mon, 28 Jun 2021 10:54:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232777AbhF1K5G (ORCPT ); Mon, 28 Jun 2021 06:57:06 -0400 Received: from smtp-fw-2101.amazon.com ([72.21.196.25]:37345 "EHLO smtp-fw-2101.amazon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232700AbhF1K5E (ORCPT ); Mon, 28 Jun 2021 06:57:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1624877679; x=1656413679; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=40yGFLlFdyP2oUyLOKMw3GyY1D5jUGecldbwh8C4AXo=; b=i4e+T2PgpeRNmhoxC1/eKxa/yI5pGslVNYz9glM1cxzvpLHa+0Jk6ylx 6SO22jdm5ZPf/weiLHMbNhGm9+iRrLvonj44vFEXYdc7jXCXDKF2ISJw9 v6w5O0Z1T6EGrpdG3Oij+HzDsw1dWOGkBwRnZ1QOvg9Umx8lVimLcDzij g=; X-IronPort-AV: E=Sophos;i="5.83,305,1616457600"; d="scan'208";a="118759721" Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-2c-579b7f5b.us-west-2.amazon.com) ([10.43.8.2]) by smtp-border-fw-2101.iad2.amazon.com with ESMTP; 28 Jun 2021 10:54:30 +0000 Received: from EX13MTAUWC001.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan3.pdx.amazon.com [10.236.137.198]) by email-inbound-relay-2c-579b7f5b.us-west-2.amazon.com (Postfix) with ESMTPS id 45F81A1DC8; Mon, 28 Jun 2021 10:54:29 +0000 (UTC) Received: from EX13D20UWC001.ant.amazon.com (10.43.162.244) by EX13MTAUWC001.ant.amazon.com (10.43.162.135) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Mon, 28 Jun 2021 10:54:28 +0000 Received: from [192.168.24.203] (10.43.161.153) by EX13D20UWC001.ant.amazon.com (10.43.162.244) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Mon, 28 Jun 2021 10:54:25 +0000 Message-ID: <3a43b2de-6a71-2373-8695-5e96657c8fc2@amazon.com> Date: Mon, 28 Jun 2021 12:54:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:90.0) Gecko/20100101 Thunderbird/90.0 Subject: Re: [PATCH v4 1/3] iommu: io-pgtable: add DART pagetable format Content-Language: en-US To: Sven Peter , Will Deacon , "Robin Murphy" , Joerg Roedel CC: Arnd Bergmann , , "Hector Martin" , , Marc Zyngier , Mohamed Mediouni , "Stan Skowronek" , , "Mark Kettenis" , , Alyssa Rosenzweig , Rob Herring , References: <20210627143405.77298-1-sven@svenpeter.dev> <20210627143405.77298-2-sven@svenpeter.dev> From: Alexander Graf In-Reply-To: <20210627143405.77298-2-sven@svenpeter.dev> X-Originating-IP: [10.43.161.153] X-ClientProxiedBy: EX13D17UWB001.ant.amazon.com (10.43.161.252) To EX13D20UWC001.ant.amazon.com (10.43.162.244) Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: base64 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org CgpPbiAyNy4wNi4yMSAxNjozNCwgU3ZlbiBQZXRlciB3cm90ZToKPiAKPiBBcHBsZSdzIERBUlQg aW9tbXUgdXNlcyBhIHBhZ2V0YWJsZSBmb3JtYXQgdGhhdCBzaGFyZXMgc29tZQo+IHNpbWlsYXJp dGllcyB3aXRoIHRoZSBvbmVzIGFscmVhZHkgaW1wbGVtZW50ZWQgYnkgaW8tcGd0YWJsZS5jLgo+ IEFkZCBhIG5ldyBmb3JtYXQgdmFyaWFudCB0byBzdXBwb3J0IHRoZSByZXF1aXJlZCBkaWZmZXJl bmNlcwo+IHNvIHRoYXQgd2UgZG9uJ3QgaGF2ZSB0byBkdXBsaWNhdGUgdGhlIHBhZ2V0YWJsZSBo YW5kbGluZyBjb2RlLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFN2ZW4gUGV0ZXIgPHN2ZW5Ac3ZlbnBl dGVyLmRldj4KPiAtLS0KPiAgIGRyaXZlcnMvaW9tbXUvaW8tcGd0YWJsZS1hcm0uYyB8IDYyICsr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPiAgIGRyaXZlcnMvaW9tbXUvaW8tcGd0 YWJsZS5jICAgICB8ICAxICsKPiAgIGluY2x1ZGUvbGludXgvaW8tcGd0YWJsZS5oICAgICB8ICA3 ICsrKysKPiAgIDMgZmlsZXMgY2hhbmdlZCwgNzAgaW5zZXJ0aW9ucygrKQo+IAo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2lvbW11L2lvLXBndGFibGUtYXJtLmMgYi9kcml2ZXJzL2lvbW11L2lvLXBn dGFibGUtYXJtLmMKPiBpbmRleCA4N2RlZjU4ZTc5YjUuLjFkZDVjNDViNGI1YiAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL2lvbW11L2lvLXBndGFibGUtYXJtLmMKPiArKysgYi9kcml2ZXJzL2lvbW11 L2lvLXBndGFibGUtYXJtLmMKPiBAQCAtMTI3LDYgKzEyNyw5IEBACj4gICAjZGVmaW5lIEFSTV9N QUxJX0xQQUVfTUVNQVRUUl9JTVBfREVGICAweDg4VUxMCj4gICAjZGVmaW5lIEFSTV9NQUxJX0xQ QUVfTUVNQVRUUl9XUklURV9BTExPQyAweDhEVUxMCj4gCj4gKyNkZWZpbmUgQVBQTEVfREFSVF9Q VEVfUFJPVF9OT19XUklURSAoMTw8NykKPiArI2RlZmluZSBBUFBMRV9EQVJUX1BURV9QUk9UX05P X1JFQUQgKDE8PDgpCj4gKwo+ICAgLyogSU9QVEUgYWNjZXNzb3JzICovCj4gICAjZGVmaW5lIGlv cHRlX2RlcmVmKHB0ZSxkKSBfX3ZhKGlvcHRlX3RvX3BhZGRyKHB0ZSwgZCkpCj4gCj4gQEAgLTM4 MSw2ICszODQsMTUgQEAgc3RhdGljIGFybV9scGFlX2lvcHRlIGFybV9scGFlX3Byb3RfdG9fcHRl KHN0cnVjdCBhcm1fbHBhZV9pb19wZ3RhYmxlICpkYXRhLAo+ICAgewo+ICAgICAgICAgIGFybV9s cGFlX2lvcHRlIHB0ZTsKPiAKPiArICAgICAgIGlmIChkYXRhLT5pb3AuZm10ID09IEFSTV9BUFBM RV9EQVJUKSB7Cj4gKyAgICAgICAgICAgICAgIHB0ZSA9IDA7Cj4gKyAgICAgICAgICAgICAgIGlm ICghKHByb3QgJiBJT01NVV9XUklURSkpCj4gKyAgICAgICAgICAgICAgICAgICAgICAgcHRlIHw9 IEFQUExFX0RBUlRfUFRFX1BST1RfTk9fV1JJVEU7Cj4gKyAgICAgICAgICAgICAgIGlmICghKHBy b3QgJiBJT01NVV9SRUFEKSkKPiArICAgICAgICAgICAgICAgICAgICAgICBwdGUgfD0gQVBQTEVf REFSVF9QVEVfUFJPVF9OT19SRUFEOwo+ICsgICAgICAgICAgICAgICByZXR1cm4gcHRlOwoKV2hh dCBhYm91dCB0aGUgb3RoZXIgYml0cywgc3VjaCBhcyBzaGFyYWJpbGl0eSwgWE4sIGV0Yz8gRG8g dGhleSBub3QgCmV4aXN0IG9uIERBUlQ/IE9yIGhhdmUgdGhleSBub3QgYmVlbiByZXZlcnNlIGVu Z2luZWVyZWQgYW5kIDBzIGhhcHBlbiB0byAKImp1c3Qgd29yayI/Cgo+ICsgICAgICAgfQo+ICsK PiAgICAgICAgICBpZiAoZGF0YS0+aW9wLmZtdCA9PSBBUk1fNjRfTFBBRV9TMSB8fAo+ICAgICAg ICAgICAgICBkYXRhLT5pb3AuZm10ID09IEFSTV8zMl9MUEFFX1MxKSB7Cj4gICAgICAgICAgICAg ICAgICBwdGUgPSBBUk1fTFBBRV9QVEVfbkc7Cj4gQEAgLTEwNDMsNiArMTA1NSw1MSBAQCBhcm1f bWFsaV9scGFlX2FsbG9jX3BndGFibGUoc3RydWN0IGlvX3BndGFibGVfY2ZnICpjZmcsIHZvaWQg KmNvb2tpZSkKPiAgICAgICAgICByZXR1cm4gTlVMTDsKPiAgIH0KPiAKPiArc3RhdGljIHN0cnVj dCBpb19wZ3RhYmxlICoKPiArYXBwbGVfZGFydF9hbGxvY19wZ3RhYmxlKHN0cnVjdCBpb19wZ3Rh YmxlX2NmZyAqY2ZnLCB2b2lkICpjb29raWUpCj4gK3sKPiArICAgICAgIHN0cnVjdCBhcm1fbHBh ZV9pb19wZ3RhYmxlICpkYXRhOwo+ICsgICAgICAgaW50IGk7Cj4gKwo+ICsgICAgICAgaWYgKGNm Zy0+b2FzID4gMzYpCj4gKyAgICAgICAgICAgICAgIHJldHVybiBOVUxMOwo+ICsKPiArICAgICAg IGRhdGEgPSBhcm1fbHBhZV9hbGxvY19wZ3RhYmxlKGNmZyk7Cj4gKyAgICAgICBpZiAoIWRhdGEp Cj4gKyAgICAgICAgICAgICAgIHJldHVybiBOVUxMOwo+ICsKPiArICAgICAgIC8qCj4gKyAgICAg ICAgKiBBcHBsZSdzIERBUlQgYWx3YXlzIHJlcXVpcmVzIHRocmVlIGxldmVscyB3aXRoIHRoZSBm aXJzdCBsZXZlbCBiZWluZwo+ICsgICAgICAgICogc3RvcmVkIGluIGZvdXIgTU1JTyByZWdpc3Rl cnMuIFdlIGFsd2F5cyBjb25jYXRlbmF0ZSB0aGUgZmlyc3QgYW5kCj4gKyAgICAgICAgKiBzZWNv bmQgbGV2ZWwgc28gdGhhdCB3ZSBvbmx5IGhhdmUgdG8gc2V0dXAgdGhlIE1NSU8gcmVnaXN0ZXJz IG9uY2UuCj4gKyAgICAgICAgKiBUaGlzIHJlc3VsdHMgaW4gYW4gZWZmZWN0aXZlIHR3byBsZXZl bCBwYWdldGFibGUuCj4gKyAgICAgICAgKi8KPiArICAgICAgIGlmIChkYXRhLT5zdGFydF9sZXZl bCA8IDEpCj4gKyAgICAgICAgICAgICAgIHJldHVybiBOVUxMOwo+ICsgICAgICAgaWYgKGRhdGEt PnN0YXJ0X2xldmVsID09IDEgJiYgZGF0YS0+cGdkX2JpdHMgPiAyKQo+ICsgICAgICAgICAgICAg ICByZXR1cm4gTlVMTDsKPiArICAgICAgIGlmIChkYXRhLT5zdGFydF9sZXZlbCA+IDEpCj4gKyAg ICAgICAgICAgICAgIGRhdGEtPnBnZF9iaXRzID0gMDsKPiArICAgICAgIGRhdGEtPnN0YXJ0X2xl dmVsID0gMjsKPiArICAgICAgIGNmZy0+YXBwbGVfZGFydF9jZmcubl90dGJycyA9IDEgPDwgZGF0 YS0+cGdkX2JpdHM7CgpNYXliZSBhZGQgYSBCVUdfT04gaWYgbl90dGJycyA+IEFSUkFZX1NJWkUo dHRicik/IE9yIGFsdGVybmF0aXZlbHksIGRvIGEgCm5vcm1hbCBydW50aW1lIGNoZWNrIGFuZCBi YWlsIG91dCB0aGVuLgoKCkFsZXgKCgoKQW1hem9uIERldmVsb3BtZW50IENlbnRlciBHZXJtYW55 IEdtYkgKS3JhdXNlbnN0ci4gMzgKMTAxMTcgQmVybGluCkdlc2NoYWVmdHNmdWVocnVuZzogQ2hy aXN0aWFuIFNjaGxhZWdlciwgSm9uYXRoYW4gV2Vpc3MKRWluZ2V0cmFnZW4gYW0gQW10c2dlcmlj aHQgQ2hhcmxvdHRlbmJ1cmcgdW50ZXIgSFJCIDE0OTE3MyBCClNpdHo6IEJlcmxpbgpVc3QtSUQ6 IERFIDI4OSAyMzcgODc5CgoK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F40AC2B9F4 for ; Mon, 28 Jun 2021 10:54:45 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 43BCE619F1 for ; Mon, 28 Jun 2021 10:54:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 43BCE619F1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lists.linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 0EBA182C75; Mon, 28 Jun 2021 10:54:45 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VWXSNWD2Y_ie; Mon, 28 Jun 2021 10:54:44 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp1.osuosl.org (Postfix) with ESMTPS id ED582818DC; Mon, 28 Jun 2021 10:54:43 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id C2B3FC001A; Mon, 28 Jun 2021 10:54:43 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id B4551C000E for ; Mon, 28 Jun 2021 10:54:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id AF9984031C for ; Mon, 28 Jun 2021 10:54:42 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp4.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=amazon.com Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ps6D42mxp80p for ; Mon, 28 Jun 2021 10:54:40 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from smtp-fw-2101.amazon.com (smtp-fw-2101.amazon.com [72.21.196.25]) by smtp4.osuosl.org (Postfix) with ESMTPS id 5A3A7402C0 for ; Mon, 28 Jun 2021 10:54:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1624877680; x=1656413680; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=40yGFLlFdyP2oUyLOKMw3GyY1D5jUGecldbwh8C4AXo=; b=W3yapkx+hW8YISLneCucahadHT8+POMccL/2FG7tFdvjXVQZjnJClHJh mKaDlmsifc5qLfzVFB4P4/eWTEn87bXrKxdkAOlM+j/ACVhXyoU0I7lQJ nyvjs6QL15XNMmCYMpbOiyem5/DfdqWqRyr3JsVH3f5WHg8DdYG0Q5rKC o=; X-IronPort-AV: E=Sophos;i="5.83,305,1616457600"; d="scan'208";a="118759721" Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-2c-579b7f5b.us-west-2.amazon.com) ([10.43.8.2]) by smtp-border-fw-2101.iad2.amazon.com with ESMTP; 28 Jun 2021 10:54:30 +0000 Received: from EX13MTAUWC001.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan3.pdx.amazon.com [10.236.137.198]) by email-inbound-relay-2c-579b7f5b.us-west-2.amazon.com (Postfix) with ESMTPS id 45F81A1DC8; Mon, 28 Jun 2021 10:54:29 +0000 (UTC) Received: from EX13D20UWC001.ant.amazon.com (10.43.162.244) by EX13MTAUWC001.ant.amazon.com (10.43.162.135) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Mon, 28 Jun 2021 10:54:28 +0000 Received: from [192.168.24.203] (10.43.161.153) by EX13D20UWC001.ant.amazon.com (10.43.162.244) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Mon, 28 Jun 2021 10:54:25 +0000 Message-ID: <3a43b2de-6a71-2373-8695-5e96657c8fc2@amazon.com> Date: Mon, 28 Jun 2021 12:54:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:90.0) Gecko/20100101 Thunderbird/90.0 Subject: Re: [PATCH v4 1/3] iommu: io-pgtable: add DART pagetable format Content-Language: en-US To: Sven Peter , Will Deacon , "Robin Murphy" , Joerg Roedel References: <20210627143405.77298-1-sven@svenpeter.dev> <20210627143405.77298-2-sven@svenpeter.dev> In-Reply-To: <20210627143405.77298-2-sven@svenpeter.dev> X-Originating-IP: [10.43.161.153] X-ClientProxiedBy: EX13D17UWB001.ant.amazon.com (10.43.161.252) To EX13D20UWC001.ant.amazon.com (10.43.162.244) Cc: Arnd Bergmann , r.czerwinski@pengutronix.de, devicetree@vger.kernel.org, Marc Zyngier , Hector Martin , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Rob Herring , Alyssa Rosenzweig , Mohamed Mediouni , Mark Kettenis , linux-arm-kernel@lists.infradead.org, Stan Skowronek X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Alexander Graf via iommu Reply-To: Alexander Graf Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On 27.06.21 16:34, Sven Peter wrote: > > Apple's DART iommu uses a pagetable format that shares some > similarities with the ones already implemented by io-pgtable.c. > Add a new format variant to support the required differences > so that we don't have to duplicate the pagetable handling code. > > Signed-off-by: Sven Peter > --- > drivers/iommu/io-pgtable-arm.c | 62 ++++++++++++++++++++++++++++++++++ > drivers/iommu/io-pgtable.c | 1 + > include/linux/io-pgtable.h | 7 ++++ > 3 files changed, 70 insertions(+) > > diff --git a/drivers/iommu/io-pgtable-arm.c b/drivers/iommu/io-pgtable-arm.c > index 87def58e79b5..1dd5c45b4b5b 100644 > --- a/drivers/iommu/io-pgtable-arm.c > +++ b/drivers/iommu/io-pgtable-arm.c > @@ -127,6 +127,9 @@ > #define ARM_MALI_LPAE_MEMATTR_IMP_DEF 0x88ULL > #define ARM_MALI_LPAE_MEMATTR_WRITE_ALLOC 0x8DULL > > +#define APPLE_DART_PTE_PROT_NO_WRITE (1<<7) > +#define APPLE_DART_PTE_PROT_NO_READ (1<<8) > + > /* IOPTE accessors */ > #define iopte_deref(pte,d) __va(iopte_to_paddr(pte, d)) > > @@ -381,6 +384,15 @@ static arm_lpae_iopte arm_lpae_prot_to_pte(struct arm_lpae_io_pgtable *data, > { > arm_lpae_iopte pte; > > + if (data->iop.fmt == ARM_APPLE_DART) { > + pte = 0; > + if (!(prot & IOMMU_WRITE)) > + pte |= APPLE_DART_PTE_PROT_NO_WRITE; > + if (!(prot & IOMMU_READ)) > + pte |= APPLE_DART_PTE_PROT_NO_READ; > + return pte; What about the other bits, such as sharability, XN, etc? Do they not exist on DART? Or have they not been reverse engineered and 0s happen to "just work"? > + } > + > if (data->iop.fmt == ARM_64_LPAE_S1 || > data->iop.fmt == ARM_32_LPAE_S1) { > pte = ARM_LPAE_PTE_nG; > @@ -1043,6 +1055,51 @@ arm_mali_lpae_alloc_pgtable(struct io_pgtable_cfg *cfg, void *cookie) > return NULL; > } > > +static struct io_pgtable * > +apple_dart_alloc_pgtable(struct io_pgtable_cfg *cfg, void *cookie) > +{ > + struct arm_lpae_io_pgtable *data; > + int i; > + > + if (cfg->oas > 36) > + return NULL; > + > + data = arm_lpae_alloc_pgtable(cfg); > + if (!data) > + return NULL; > + > + /* > + * Apple's DART always requires three levels with the first level being > + * stored in four MMIO registers. We always concatenate the first and > + * second level so that we only have to setup the MMIO registers once. > + * This results in an effective two level pagetable. > + */ > + if (data->start_level < 1) > + return NULL; > + if (data->start_level == 1 && data->pgd_bits > 2) > + return NULL; > + if (data->start_level > 1) > + data->pgd_bits = 0; > + data->start_level = 2; > + cfg->apple_dart_cfg.n_ttbrs = 1 << data->pgd_bits; Maybe add a BUG_ON if n_ttbrs > ARRAY_SIZE(ttbr)? Or alternatively, do a normal runtime check and bail out then. Alex Amazon Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B Sitz: Berlin Ust-ID: DE 289 237 879 _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_ALL,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA066C2B9F4 for ; Mon, 28 Jun 2021 10:56:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 73F7761A2B for ; Mon, 28 Jun 2021 10:56:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 73F7761A2B Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=amazon.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xIjdA5Qiil4k/OKyQDh0LDY4GtN1K2csH227vkqoO4o=; b=sxllQXYWL80QXA JT7G3315DRPcNd9I4REdYtRgeFWgfxuAEQrG6osJvZL5U8oPHfz0PkRmY5ZZbHwp2dpKGkUDtPtko UVrsK5PUAagmmFrcM403gdKNnDJsp0TjHnGP89ouqU7MkH4GhyuxoG9FebAmvjikJDeJWhDmcateK NMnKd669E/PlQSZ8iA2bT023jVQdV98PzxayUaK3BGbORpYJzeakpIcjOw5Zid6R4FI6L/Y4Qubno +VMgnQ2zwyyNO5E0WssnDBJd/762+pil/tEtm90+L5Rrf9y9VdI/64/0km4T0h36Bc4MhUh7A2dWG XCAjINW4rk1+0BrG78fw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lxoud-007h6H-8Z; Mon, 28 Jun 2021 10:54:47 +0000 Received: from smtp-fw-2101.amazon.com ([72.21.196.25]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lxouZ-007h5E-GY for linux-arm-kernel@lists.infradead.org; Mon, 28 Jun 2021 10:54:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1624877683; x=1656413683; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=40yGFLlFdyP2oUyLOKMw3GyY1D5jUGecldbwh8C4AXo=; b=ksLITe6lJAq8tSBAwC0SIlwKX1oB0D9FO8QeojNLrlQ7kmh0OS1GY+tj hTEbv3cUmyDeMV/0GmnViSyv6dN7MFzAK3GYtATZIt7CegpaSdRscQRKx Xe2PXCzjjSQNT22wOxilumqyOnHIM8xvnTOAB+CiFi3JmewGTwjhBb8XF U=; X-IronPort-AV: E=Sophos;i="5.83,305,1616457600"; d="scan'208";a="118759721" Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-2c-579b7f5b.us-west-2.amazon.com) ([10.43.8.2]) by smtp-border-fw-2101.iad2.amazon.com with ESMTP; 28 Jun 2021 10:54:30 +0000 Received: from EX13MTAUWC001.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan3.pdx.amazon.com [10.236.137.198]) by email-inbound-relay-2c-579b7f5b.us-west-2.amazon.com (Postfix) with ESMTPS id 45F81A1DC8; Mon, 28 Jun 2021 10:54:29 +0000 (UTC) Received: from EX13D20UWC001.ant.amazon.com (10.43.162.244) by EX13MTAUWC001.ant.amazon.com (10.43.162.135) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Mon, 28 Jun 2021 10:54:28 +0000 Received: from [192.168.24.203] (10.43.161.153) by EX13D20UWC001.ant.amazon.com (10.43.162.244) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Mon, 28 Jun 2021 10:54:25 +0000 Message-ID: <3a43b2de-6a71-2373-8695-5e96657c8fc2@amazon.com> Date: Mon, 28 Jun 2021 12:54:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:90.0) Gecko/20100101 Thunderbird/90.0 Subject: Re: [PATCH v4 1/3] iommu: io-pgtable: add DART pagetable format Content-Language: en-US To: Sven Peter , Will Deacon , "Robin Murphy" , Joerg Roedel CC: Arnd Bergmann , , "Hector Martin" , , Marc Zyngier , Mohamed Mediouni , "Stan Skowronek" , , "Mark Kettenis" , , Alyssa Rosenzweig , Rob Herring , References: <20210627143405.77298-1-sven@svenpeter.dev> <20210627143405.77298-2-sven@svenpeter.dev> From: Alexander Graf In-Reply-To: <20210627143405.77298-2-sven@svenpeter.dev> X-Originating-IP: [10.43.161.153] X-ClientProxiedBy: EX13D17UWB001.ant.amazon.com (10.43.161.252) To EX13D20UWC001.ant.amazon.com (10.43.162.244) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210628_035443_725789_17520198 X-CRM114-Status: GOOD ( 22.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 27.06.21 16:34, Sven Peter wrote: > > Apple's DART iommu uses a pagetable format that shares some > similarities with the ones already implemented by io-pgtable.c. > Add a new format variant to support the required differences > so that we don't have to duplicate the pagetable handling code. > > Signed-off-by: Sven Peter > --- > drivers/iommu/io-pgtable-arm.c | 62 ++++++++++++++++++++++++++++++++++ > drivers/iommu/io-pgtable.c | 1 + > include/linux/io-pgtable.h | 7 ++++ > 3 files changed, 70 insertions(+) > > diff --git a/drivers/iommu/io-pgtable-arm.c b/drivers/iommu/io-pgtable-arm.c > index 87def58e79b5..1dd5c45b4b5b 100644 > --- a/drivers/iommu/io-pgtable-arm.c > +++ b/drivers/iommu/io-pgtable-arm.c > @@ -127,6 +127,9 @@ > #define ARM_MALI_LPAE_MEMATTR_IMP_DEF 0x88ULL > #define ARM_MALI_LPAE_MEMATTR_WRITE_ALLOC 0x8DULL > > +#define APPLE_DART_PTE_PROT_NO_WRITE (1<<7) > +#define APPLE_DART_PTE_PROT_NO_READ (1<<8) > + > /* IOPTE accessors */ > #define iopte_deref(pte,d) __va(iopte_to_paddr(pte, d)) > > @@ -381,6 +384,15 @@ static arm_lpae_iopte arm_lpae_prot_to_pte(struct arm_lpae_io_pgtable *data, > { > arm_lpae_iopte pte; > > + if (data->iop.fmt == ARM_APPLE_DART) { > + pte = 0; > + if (!(prot & IOMMU_WRITE)) > + pte |= APPLE_DART_PTE_PROT_NO_WRITE; > + if (!(prot & IOMMU_READ)) > + pte |= APPLE_DART_PTE_PROT_NO_READ; > + return pte; What about the other bits, such as sharability, XN, etc? Do they not exist on DART? Or have they not been reverse engineered and 0s happen to "just work"? > + } > + > if (data->iop.fmt == ARM_64_LPAE_S1 || > data->iop.fmt == ARM_32_LPAE_S1) { > pte = ARM_LPAE_PTE_nG; > @@ -1043,6 +1055,51 @@ arm_mali_lpae_alloc_pgtable(struct io_pgtable_cfg *cfg, void *cookie) > return NULL; > } > > +static struct io_pgtable * > +apple_dart_alloc_pgtable(struct io_pgtable_cfg *cfg, void *cookie) > +{ > + struct arm_lpae_io_pgtable *data; > + int i; > + > + if (cfg->oas > 36) > + return NULL; > + > + data = arm_lpae_alloc_pgtable(cfg); > + if (!data) > + return NULL; > + > + /* > + * Apple's DART always requires three levels with the first level being > + * stored in four MMIO registers. We always concatenate the first and > + * second level so that we only have to setup the MMIO registers once. > + * This results in an effective two level pagetable. > + */ > + if (data->start_level < 1) > + return NULL; > + if (data->start_level == 1 && data->pgd_bits > 2) > + return NULL; > + if (data->start_level > 1) > + data->pgd_bits = 0; > + data->start_level = 2; > + cfg->apple_dart_cfg.n_ttbrs = 1 << data->pgd_bits; Maybe add a BUG_ON if n_ttbrs > ARRAY_SIZE(ttbr)? Or alternatively, do a normal runtime check and bail out then. Alex Amazon Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B Sitz: Berlin Ust-ID: DE 289 237 879 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel