From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 1/5] drm/prime: fix potential race in drm_gem_map_detach Date: Wed, 28 Feb 2018 11:25:59 +0100 Message-ID: <3a4f9020-235d-ef05-a246-1ba920070f09@gmail.com> References: <20180227115000.4105-1-christian.koenig@amd.com> <1519811307.6253.5.camel@pengutronix.de> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1519811307.6253.5.camel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Lucas Stach , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: dri-devel@lists.freedesktop.org QW0gMjguMDIuMjAxOCB1bSAxMDo0OCBzY2hyaWViIEx1Y2FzIFN0YWNoOgo+IEhpIENocmlzdGlh biwKPgo+IEFtIERpZW5zdGFnLCBkZW4gMjcuMDIuMjAxOCwgMTI6NDkgKzAxMDAgc2NocmllYiBD aHJpc3RpYW4gS8O2bmlnOgo+PiBVbnBpbiB0aGUgR0VNIG9iamVjdCBvbmx5IGFmdGVyIGZyZWVp bmcgdGhlIHNnIHRhYmxlLgo+IFdoYXQgaXMgdGhlIHJhY2UgdGhhdCBpcyBiZWluZyBmaXhlZCBo ZXJlPyBUaGUgU0cgdGFibGUgaXMgcHJpdmF0ZSB0bwo+IHRoZSBpbXBvcnRlciBhbmQgdGhlIGlt cG9ydGVyIHNob3VsZCBob3BlZnVsbHkgb25seSBjYWxsIG1hcF9kZXRhY2ggaWYKPiBpdCBpcyBk b25lIHdpdGggYWxsIG9wZXJhdGlvbnMgdXNpbmcgdGhlIFNHIHRhYmxlLiBUaHVzIGl0IHNob3Vs ZG4ndAo+IG1hdHRlciB0aGF0IHRoZSBTRyB0YWJsZSBtaWdodCBwb2ludCB0byBtb3ZlZCBwYWdl cyBkdXJpbmcgZXhlY3V0aW9uIG9mCj4gdGhpcyBmdW5jdGlvbi4KCkV4YWN0bHksIGl0IHNob3Vs ZG4ndCBtYXR0ZXIuIFRoaXMgaXMganVzdCBhIHByZWNhdXRpb24uCgpXaGVuIHRoZSBkZXZpY2Ug ZHJpdmVyIGlzIGJ1Z2d5IEkgd2FudCBwcm9wZXIgZXJyb3IgbWVzc2FnZXMgZnJvbSBJT01NVSAK YW5kIG5vdCBhY2Nlc3NpbmcgcGFnZXMgd2hpY2ggbWlnaHQgYWxyZWFkeSBiZSByZXVzZWQgZm9y IHNvbWV0aGluZyBlbHNlLgoKUmVnYXJkcywKQ2hyaXN0aWFuLgoKPgo+IFJlZ2FyZHMsCj4gTHVj YXMKPgo+PiBTaWduZWQtb2ZmLWJ5OiBDaHJpc3RpYW4gS8O2bmlnIDxjaHJpc3RpYW4ua29lbmln QGFtZC5jb20+Cj4+IC0tLQo+PiAgIGRyaXZlcnMvZ3B1L2RybS9kcm1fcHJpbWUuYyB8IDMyICsr KysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tCj4+ICAgMSBmaWxlIGNoYW5nZWQsIDE2IGlu c2VydGlvbnMoKyksIDE2IGRlbGV0aW9ucygtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2RybV9wcmltZS5jCj4+IGIvZHJpdmVycy9ncHUvZHJtL2RybV9wcmltZS5jCj4+IGlu ZGV4IGU4MmE5NzZmMGZiYS4uYzM4ZGFjZGE2MTE5IDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vZHJtX3ByaW1lLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9wcmltZS5jCj4+ IEBAIC0yMzAsMjYgKzIzMCwyNiBAQCB2b2lkIGRybV9nZW1fbWFwX2RldGFjaChzdHJ1Y3QgZG1h X2J1Zgo+PiAqZG1hX2J1ZiwKPj4gICAJc3RydWN0IGRybV9wcmltZV9hdHRhY2htZW50ICpwcmlt ZV9hdHRhY2ggPSBhdHRhY2gtPnByaXY7Cj4+ICAgCXN0cnVjdCBkcm1fZ2VtX29iamVjdCAqb2Jq ID0gZG1hX2J1Zi0+cHJpdjsKPj4gICAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IG9iai0+ZGV2 Owo+PiAtCXN0cnVjdCBzZ190YWJsZSAqc2d0Owo+PiAgIAo+PiAtCWlmIChkZXYtPmRyaXZlci0+ Z2VtX3ByaW1lX3VucGluKQo+PiAtCQlkZXYtPmRyaXZlci0+Z2VtX3ByaW1lX3VucGluKG9iaik7 Cj4+ICsJaWYgKHByaW1lX2F0dGFjaCkgewo+PiArCQlzdHJ1Y3Qgc2dfdGFibGUgKnNndCA9IHBy aW1lX2F0dGFjaC0+c2d0Owo+PiAgIAo+PiAtCWlmICghcHJpbWVfYXR0YWNoKQo+PiAtCQlyZXR1 cm47Cj4+IC0KPj4gLQlzZ3QgPSBwcmltZV9hdHRhY2gtPnNndDsKPj4gLQlpZiAoc2d0KSB7Cj4+ IC0JCWlmIChwcmltZV9hdHRhY2gtPmRpciAhPSBETUFfTk9ORSkKPj4gLQkJCWRtYV91bm1hcF9z Z19hdHRycyhhdHRhY2gtPmRldiwgc2d0LT5zZ2wsCj4+IHNndC0+bmVudHMsCj4+IC0JCQkJCSAg IHByaW1lX2F0dGFjaC0+ZGlyLAo+PiAtCQkJCQkgICBETUFfQVRUUl9TS0lQX0NQVV9TWU5DKTsK Pj4gLQkJc2dfZnJlZV90YWJsZShzZ3QpOwo+PiArCQlpZiAoc2d0KSB7Cj4+ICsJCQlpZiAocHJp bWVfYXR0YWNoLT5kaXIgIT0gRE1BX05PTkUpCj4+ICsJCQkJZG1hX3VubWFwX3NnX2F0dHJzKGF0 dGFjaC0+ZGV2LCBzZ3QtCj4+PiBzZ2wsCj4+ICsJCQkJCQkgICBzZ3QtPm5lbnRzLAo+PiArCQkJ CQkJICAgcHJpbWVfYXR0YWNoLQo+Pj4gZGlyLAo+PiArCQkJCQkJICAgRE1BX0FUVFJfU0tJUF9D UFUKPj4gX1NZTkMpOwo+PiArCQkJc2dfZnJlZV90YWJsZShzZ3QpOwo+PiArCQl9Cj4+ICsKPj4g KwkJa2ZyZWUoc2d0KTsKPj4gKwkJa2ZyZWUocHJpbWVfYXR0YWNoKTsKPj4gKwkJYXR0YWNoLT5w cml2ID0gTlVMTDsKPj4gICAJfQo+PiAgIAo+PiAtCWtmcmVlKHNndCk7Cj4+IC0Ja2ZyZWUocHJp bWVfYXR0YWNoKTsKPj4gLQlhdHRhY2gtPnByaXYgPSBOVUxMOwo+PiArCWlmIChkZXYtPmRyaXZl ci0+Z2VtX3ByaW1lX3VucGluKQo+PiArCQlkZXYtPmRyaXZlci0+Z2VtX3ByaW1lX3VucGluKG9i aik7Cj4+ICAgfQo+PiAgIEVYUE9SVF9TWU1CT0woZHJtX2dlbV9tYXBfZGV0YWNoKTsKPj4gICAK Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmFtZC1nZngg bWFpbGluZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeAo=