Re: [PATCH v2] eal: allow worker lcore stacks to be allocated from hugepage memory

From: Don Wallwork <donw@xsightlabs.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, mb@smartsharesystems.com,
	anatoly.burakov@intel.com, dmitry.kozliuk@gmail.com,
	bruce.richardson@intel.com, Honnappa.Nagarahalli@arm.com,
	nd@arm.com, haiyue.wang@intel.com
Subject: Re: [PATCH v2] eal: allow worker lcore stacks to be allocated from hugepage memory
Date: Mon, 16 May 2022 15:43:23 -0400	[thread overview]
Message-ID: <3a576578-c9c8-79f1-53a7-a31f37d5f8e9@xsightlabs.com> (raw)
In-Reply-To: <20220513143805.2aa167b0@hermes.local>


On 5/13/2022 5:38 PM, Stephen Hemminger wrote:
> On Fri, 13 May 2022 13:58:22 -0400
> Don Wallwork <donw@xsightlabs.com> wrote:
>
>> +static int
>> +eal_parse_huge_worker_stack(const char *arg, size_t *huge_worker_stack_size)
>> +{
>> +	size_t worker_stack_size;
>> +	if (arg == NULL) {
>> +		*huge_worker_stack_size = USE_OS_STACK_SIZE;
>> +		return 0;
>> +	}
>> +	worker_stack_size = atoi(arg);
>> +	if (worker_stack_size == 0)
>> +		return -1;
>> +
> Since worker_stack_size is size_t you are better off using something
> like strtoul() and check for more errors from that
This and your other comment are addressed in the v3 patch.