From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Osipenko Subject: Re: [PATCH v2 4/9] ASoC: tegra: add Tegra210 based I2S driver Date: Thu, 6 Feb 2020 19:59:24 +0300 Message-ID: <3a586a6b-5f53-dc44-b9fc-67c633c626ef@gmail.com> References: <1580380422-3431-1-git-send-email-spujar@nvidia.com> <1580380422-3431-5-git-send-email-spujar@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <1580380422-3431-5-git-send-email-spujar-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Content-Language: en-US Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sameer Pujar Cc: perex-/Fr2/VpizcU@public.gmane.org, tiwai-IBi9RG/b67k@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, sharadg-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, mkumard-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, viswanathl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, rlokhande-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, dramesh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, atalambedu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org List-Id: linux-tegra@vger.kernel.org 30.01.2020 13:33, Sameer Pujar пишет: ... > +static const int tegra210_cif_fmt[] = { > + 0, > + TEGRA_ACIF_BITS_16, > + TEGRA_ACIF_BITS_32, > +}; > + > +static const int tegra210_i2s_bit_fmt[] = { > + 0, > + I2S_BITS_16, > + I2S_BITS_32, > +}; > + > +static const int tegra210_i2s_sample_size[] = { > + 0, > + 16, > + 32, > +}; static const *unsigned* int? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CACA5C352A2 for ; Thu, 6 Feb 2020 16:59:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A274921D7D for ; Thu, 6 Feb 2020 16:59:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HRo6PM95" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727835AbgBFQ73 (ORCPT ); Thu, 6 Feb 2020 11:59:29 -0500 Received: from mail-lj1-f194.google.com ([209.85.208.194]:33339 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727358AbgBFQ72 (ORCPT ); Thu, 6 Feb 2020 11:59:28 -0500 Received: by mail-lj1-f194.google.com with SMTP id y6so6903246lji.0; Thu, 06 Feb 2020 08:59:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=og0ADzsSpshRIcdeT+Ks5xnjpqRL7rIYjLZFqgQChC8=; b=HRo6PM95VaVbLvysaWne6f1YcD6Xn8ky7qGhXssAk+65rmhIhxrSsaq1vkT4jVTRWJ Vcg3sSdqitzIy5JSWb03RkBU8I/AWKITP9G5QxgsvxVSJKIIUUoUpfPzFdybKYxboX8m KiwDB9pm+oXNwHJ9gMCaR2lVltrz6cj9O2C4RTILmHCSu4jevdPaDT0WkensyZEykNCQ XevyWbBJbNfxFTQOsguMTpusj2kEjDl3Ppqzd0/Cs7bjkxI2lZIqBmbkqUSZDhOkxPwj CCAIvnNKUrs1OdnnVGd5zb99/zb075vJPrcfM0c76n9AoWoiQVOsJdJkoAYvK++HUC0j NSjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=og0ADzsSpshRIcdeT+Ks5xnjpqRL7rIYjLZFqgQChC8=; b=g3ZhjIOjkz6+Rmms5yaS8IocBcVAwArcuYfl3BPhY3W7/QBSWe9PJ3n2PzYxgX0rQm 5SsE8D0JMDEbBUHoe3kYSaLRH2fwoiieAPhp6rV8yYKxeX13vm/fGHAnWzdxgIaXrB2e qac7LjmWunD3WKqw2FPNlW8+6ZXfGVwlVRJdezOxNFhwEmVkPaXRR+r8hvyxO71B7Fu7 XzMWH7ERFS1CcL+/tLPKA1harnjgYHqBfzs1PLlngJk2K9CLletfQmqSyiruShdsp25M S+drOhQHrSjNpIPQnrix86WhZSJGvRP2blWxDY0MQpOLirPTs7t9TQSXkhV8wSfkjEy6 z5eQ== X-Gm-Message-State: APjAAAW1jjieDOJ+u/qeuEJpfSWXH/zRlhYotKQC3yoVomgtXMJ7VYSA PBhpS6gE2syps4lT2TH3rxc= X-Google-Smtp-Source: APXvYqyguhImDG7VTsNciB0wVBuwnFI+0C60WcsTjlt52pFAY46lNafpCyeCJnDDsMLILiEPwTOYGg== X-Received: by 2002:a2e:9c85:: with SMTP id x5mr2681644lji.50.1581008366212; Thu, 06 Feb 2020 08:59:26 -0800 (PST) Received: from [192.168.2.145] (79-139-233-37.dynamic.spd-mgts.ru. [79.139.233.37]) by smtp.googlemail.com with ESMTPSA id p15sm1546166lfo.88.2020.02.06.08.59.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Feb 2020 08:59:25 -0800 (PST) Subject: Re: [PATCH v2 4/9] ASoC: tegra: add Tegra210 based I2S driver To: Sameer Pujar Cc: perex@perex.cz, tiwai@suse.com, robh+dt@kernel.org, broonie@kernel.org, lgirdwood@gmail.com, thierry.reding@gmail.com, jonathanh@nvidia.com, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, sharadg@nvidia.com, mkumard@nvidia.com, viswanathl@nvidia.com, rlokhande@nvidia.com, dramesh@nvidia.com, atalambedu@nvidia.com References: <1580380422-3431-1-git-send-email-spujar@nvidia.com> <1580380422-3431-5-git-send-email-spujar@nvidia.com> From: Dmitry Osipenko Message-ID: <3a586a6b-5f53-dc44-b9fc-67c633c626ef@gmail.com> Date: Thu, 6 Feb 2020 19:59:24 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <1580380422-3431-5-git-send-email-spujar@nvidia.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 30.01.2020 13:33, Sameer Pujar пишет: ... > +static const int tegra210_cif_fmt[] = { > + 0, > + TEGRA_ACIF_BITS_16, > + TEGRA_ACIF_BITS_32, > +}; > + > +static const int tegra210_i2s_bit_fmt[] = { > + 0, > + I2S_BITS_16, > + I2S_BITS_32, > +}; > + > +static const int tegra210_i2s_sample_size[] = { > + 0, > + 16, > + 32, > +}; static const *unsigned* int? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EA7CC33CAC for ; Thu, 6 Feb 2020 17:00:24 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F415620838 for ; Thu, 6 Feb 2020 17:00:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="uDESFLRa"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HRo6PM95" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F415620838 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 5E45E16BA; Thu, 6 Feb 2020 17:59:32 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 5E45E16BA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1581008422; bh=Y5ZAbhiaAZO0aRy+P8m/Olt83ztMfMQYX7vXbcLYF10=; h=To:References:From:Date:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=uDESFLRaA3aNYe4x5fn73b8HIiR0hSN5sJ0WRD5GCL71pdQESC4W7Gp/+7uOSbX4l wsHmHR5KW1aj1m/yWLlUW4l2L4+WdFcqo14SCiHc+ipTPOz+QVKC6viMU3YeCd8gw5 NYQquHdZFnbX/myD37PwbhhuDZcXK6Qt6s/tkJFI= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id D2B1AF800C6; Thu, 6 Feb 2020 17:59:31 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 43066F8015B; Thu, 6 Feb 2020 17:59:30 +0100 (CET) Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 3F590F80059 for ; Thu, 6 Feb 2020 17:59:26 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 3F590F80059 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HRo6PM95" Received: by mail-lj1-x241.google.com with SMTP id q8so6835363ljj.11 for ; Thu, 06 Feb 2020 08:59:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=og0ADzsSpshRIcdeT+Ks5xnjpqRL7rIYjLZFqgQChC8=; b=HRo6PM95VaVbLvysaWne6f1YcD6Xn8ky7qGhXssAk+65rmhIhxrSsaq1vkT4jVTRWJ Vcg3sSdqitzIy5JSWb03RkBU8I/AWKITP9G5QxgsvxVSJKIIUUoUpfPzFdybKYxboX8m KiwDB9pm+oXNwHJ9gMCaR2lVltrz6cj9O2C4RTILmHCSu4jevdPaDT0WkensyZEykNCQ XevyWbBJbNfxFTQOsguMTpusj2kEjDl3Ppqzd0/Cs7bjkxI2lZIqBmbkqUSZDhOkxPwj CCAIvnNKUrs1OdnnVGd5zb99/zb075vJPrcfM0c76n9AoWoiQVOsJdJkoAYvK++HUC0j NSjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=og0ADzsSpshRIcdeT+Ks5xnjpqRL7rIYjLZFqgQChC8=; b=PxJoCNMuyBEGHsxgk3vVX95/dXgoxPxShEQ6LKOBR8JvV8WjJUKse25u3zC6ImnlFY SIuNLhzwjrao+Et9OFTO2ob+c8YH8B3qQQBJgk2bkIU7vjjAeLpX2WKu/lnNrkVOhcni bnOFzTtmJVbawrSiFZXE9ZxLrGvFIMm1DDlSPaTJhuTz3TPOz7Q26rIKo6nWc+SIvBUZ ffAZ83LZBtW0sIL02wRSxxQ74LHojeM0orY10ufh4vW84jAn4l/I6qjucoWWugzoPlri PrTvLqiSlvq46ANNyAmps9oP7wU3UJlykyeA3xyllkTLfAtLxCTZGYSykpDU/Wvja2Xs cBgA== X-Gm-Message-State: APjAAAXKCUnovg8C2UxFetW/yu+JhhNOmCQE/ph7S2n2O6uYrfhiMTgX VtmdRvlH0FPH2wmx5X4KUFs= X-Google-Smtp-Source: APXvYqyguhImDG7VTsNciB0wVBuwnFI+0C60WcsTjlt52pFAY46lNafpCyeCJnDDsMLILiEPwTOYGg== X-Received: by 2002:a2e:9c85:: with SMTP id x5mr2681644lji.50.1581008366212; Thu, 06 Feb 2020 08:59:26 -0800 (PST) Received: from [192.168.2.145] (79-139-233-37.dynamic.spd-mgts.ru. [79.139.233.37]) by smtp.googlemail.com with ESMTPSA id p15sm1546166lfo.88.2020.02.06.08.59.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Feb 2020 08:59:25 -0800 (PST) To: Sameer Pujar References: <1580380422-3431-1-git-send-email-spujar@nvidia.com> <1580380422-3431-5-git-send-email-spujar@nvidia.com> From: Dmitry Osipenko Message-ID: <3a586a6b-5f53-dc44-b9fc-67c633c626ef@gmail.com> Date: Thu, 6 Feb 2020 19:59:24 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <1580380422-3431-5-git-send-email-spujar@nvidia.com> Content-Language: en-US Cc: jonathanh@nvidia.com, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, atalambedu@nvidia.com, linux-kernel@vger.kernel.org, lgirdwood@gmail.com, robh+dt@kernel.org, tiwai@suse.com, viswanathl@nvidia.com, sharadg@nvidia.com, broonie@kernel.org, thierry.reding@gmail.com, linux-tegra@vger.kernel.org, rlokhande@nvidia.com, mkumard@nvidia.com, dramesh@nvidia.com Subject: Re: [alsa-devel] [PATCH v2 4/9] ASoC: tegra: add Tegra210 based I2S driver X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" MzAuMDEuMjAyMCAxMzozMywgU2FtZWVyIFB1amFyINC/0LjRiNC10YI6Ci4uLgo+ICtzdGF0aWMg Y29uc3QgaW50IHRlZ3JhMjEwX2NpZl9mbXRbXSA9IHsKPiArCTAsCj4gKwlURUdSQV9BQ0lGX0JJ VFNfMTYsCj4gKwlURUdSQV9BQ0lGX0JJVFNfMzIsCj4gK307Cj4gKwo+ICtzdGF0aWMgY29uc3Qg aW50IHRlZ3JhMjEwX2kyc19iaXRfZm10W10gPSB7Cj4gKwkwLAo+ICsJSTJTX0JJVFNfMTYsCj4g KwlJMlNfQklUU18zMiwKPiArfTsKPiArCj4gK3N0YXRpYyBjb25zdCBpbnQgdGVncmEyMTBfaTJz X3NhbXBsZV9zaXplW10gPSB7Cj4gKwkwLAo+ICsJMTYsCj4gKwkzMiwKPiArfTsKCnN0YXRpYyBj b25zdCAqdW5zaWduZWQqIGludD8KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KQWxzYS1kZXZlbCBtYWlsaW5nIGxpc3QKQWxzYS1kZXZlbEBhbHNhLXByb2pl Y3Qub3JnCmh0dHBzOi8vbWFpbG1hbi5hbHNhLXByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8v YWxzYS1kZXZlbAo=