From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761989AbcINMrC (ORCPT ); Wed, 14 Sep 2016 08:47:02 -0400 Received: from mx2.suse.de ([195.135.220.15]:54653 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761960AbcINMq7 (ORCPT ); Wed, 14 Sep 2016 08:46:59 -0400 Subject: Re: [PATCH 06/15] hisi_sas: disable dlvry queues once at reset for v2 hw To: John Garry , jejb@linux.vnet.ibm.com, martin.petersen@oracle.com References: <1473176185-217808-1-git-send-email-john.garry@huawei.com> <1473176185-217808-7-git-send-email-john.garry@huawei.com> Cc: linuxarm@huawei.com, zhangfei.gao@linaro.org, xuwei5@hisilicon.com, john.garry2@mail.dcu.ie, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org From: Hannes Reinecke Message-ID: <3a66d740-6764-de25-097f-c910fe5eb5de@suse.de> Date: Wed, 14 Sep 2016 14:46:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <1473176185-217808-7-git-send-email-john.garry@huawei.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/06/2016 05:36 PM, John Garry wrote: > The Delivery queue enable register should only be written > to once at reset for v2 hw. > > Signed-off-by: John Garry > --- > drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c > index 25e7c58..aca2b80 100644 > --- a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c > +++ b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c > @@ -685,9 +685,7 @@ static int reset_hw_v2_hw(struct hisi_hba *hisi_hba) > else > reset_val = 0x7ffff; > > - /* Disable all of the DQ */ > - for (i = 0; i < HISI_SAS_MAX_QUEUES; i++) > - hisi_sas_write32(hisi_hba, DLVRY_QUEUE_ENABLE, 0); > + hisi_sas_write32(hisi_hba, DLVRY_QUEUE_ENABLE, 0); > > /* Disable all of the PHYs */ > for (i = 0; i < hisi_hba->n_phy; i++) { > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)