All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/fb-helper: improve DRM fbdev emulation device names
@ 2021-05-21 13:19 ` Javier Martinez Canillas
  0 siblings, 0 replies; 11+ messages in thread
From: Javier Martinez Canillas @ 2021-05-21 13:19 UTC (permalink / raw)
  To: linux-kernel
  Cc: Javier Martinez Canillas, Peter Robinson, Daniel Vetter,
	David Airlie, Maarten Lankhorst, Maxime Ripard,
	Thomas Zimmermann, dri-devel

Framebuffer devices that are registered by DRM drivers for fbdev emulation
have a "drmfb" suffix in their name. But makes them to be quite confusing
if a driver already has "drm" in its name:

$ cat /proc/fb
0 rockchipdrmdrmfb

$ cat /proc/fb
0 simpledrmdrmfb

Instead, let's just add a "-fb" suffix to denote that are DRM drivers FB:

$ cat /proc/fb
0 rockchipdrm-fb

$ cat /proc/fb
0 simpledrm-fb

Suggested-by: Peter Robinson <pbrobinson@gmail.com>
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
---

 drivers/gpu/drm/drm_fb_helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index f6baa204612..bbaff92c509 100644
--- a/drivers/gpu/drm/drm_fb_helper.c
+++ b/drivers/gpu/drm/drm_fb_helper.c
@@ -1737,7 +1737,7 @@ void drm_fb_helper_fill_info(struct fb_info *info,
 			       sizes->fb_width, sizes->fb_height);
 
 	info->par = fb_helper;
-	snprintf(info->fix.id, sizeof(info->fix.id), "%sdrmfb",
+	snprintf(info->fix.id, sizeof(info->fix.id), "%s-fb",
 		 fb_helper->dev->driver->name);
 
 }
-- 
2.31.1


^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2021-05-25 13:54 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-21 13:19 [PATCH] drm/fb-helper: improve DRM fbdev emulation device names Javier Martinez Canillas
2021-05-21 13:19 ` Javier Martinez Canillas
2021-05-21 15:33 ` Daniel Vetter
2021-05-21 15:33   ` Daniel Vetter
2021-05-21 16:53   ` Thomas Zimmermann
2021-05-21 17:18     ` Javier Martinez Canillas
2021-05-21 18:53       ` Thomas Zimmermann
2021-05-25 13:08         ` Daniel Vetter
2021-05-25 13:08           ` Daniel Vetter
2021-05-25 13:34           ` Thomas Zimmermann
2021-05-25 13:52             ` Javier Martinez Canillas

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.