From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933750AbdKGJuk (ORCPT ); Tue, 7 Nov 2017 04:50:40 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:47458 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933735AbdKGJug (ORCPT ); Tue, 7 Nov 2017 04:50:36 -0500 Subject: Re: [PATCH v2] cpupowerutils: bench - Fix cpu online check To: Shuah Khan , Shuah Khan , Thomas Renninger , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20171107094755.49440-1-huntbag@linux.vnet.ibm.com> From: Abhishek Date: Tue, 7 Nov 2017 15:20:29 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171107094755.49440-1-huntbag@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-TM-AS-GCONF: 00 x-cbid: 17110709-0016-0000-0000-000004FE6787 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17110709-0017-0000-0000-0000283A05AA Message-Id: <3a6fd547-b367-6e35-7fb5-5ab8d1139b5b@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-11-07_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1711070138 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Can you please have a look at this also? Thanks and Regards, Abhishek Goel System Engineer IBM India Pvt. Ltd. On 11/07/2017 03:17 PM, Abhishek Goel wrote: > cpupower_is_cpu_online was incorrectly checking for 0. This patch fixes > this by checking for 1 when the cpu is online. > > Signed-off-by: Abhishek Goel > --- > v2: Commit message rephrased. > --- > tools/power/cpupower/bench/system.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/power/cpupower/bench/system.c b/tools/power/cpupower/bench/system.c > index c25a74a..2bb3eef 100644 > --- a/tools/power/cpupower/bench/system.c > +++ b/tools/power/cpupower/bench/system.c > @@ -61,7 +61,7 @@ int set_cpufreq_governor(char *governor, unsigned int cpu) > > dprintf("set %s as cpufreq governor\n", governor); > > - if (cpupower_is_cpu_online(cpu) != 0) { > + if (cpupower_is_cpu_online(cpu) != 1) { > perror("cpufreq_cpu_exists"); > fprintf(stderr, "error: cpu %u does not exist\n", cpu); > return -1;