From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751904AbeA2Njo (ORCPT ); Mon, 29 Jan 2018 08:39:44 -0500 Received: from lb1-smtp-cloud8.xs4all.net ([194.109.24.21]:34747 "EHLO lb1-smtp-cloud8.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751298AbeA2Njn (ORCPT ); Mon, 29 Jan 2018 08:39:43 -0500 Subject: Re: [Patch v7 12/12] Documention: v4l: Documentation for HEVC CIDs To: Smitha T Murthy Cc: linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, kyungmin.park@samsung.com, kamil@wypas.org, jtp.park@samsung.com, a.hajda@samsung.com, mchehab@kernel.org, pankaj.dubey@samsung.com, krzk@kernel.org, m.szyprowski@samsung.com, s.nawrocki@samsung.com References: <1516791584-7980-1-git-send-email-smitha.t@samsung.com> <1516791584-7980-13-git-send-email-smitha.t@samsung.com> <127cfd7f-113f-6724-297c-6f3c3746a8ff@xs4all.nl> <1517229778.29374.9.camel@smitha-fedora> <1517231702.29374.13.camel@smitha-fedora> From: Hans Verkuil Message-ID: <3a746ca1-728f-f32f-a4b9-df99f2784c2b@xs4all.nl> Date: Mon, 29 Jan 2018 14:39:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1517231702.29374.13.camel@smitha-fedora> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4wfCKPhzotRRVfqO13akMu4qX9++FI1x7ITsmH0Ikw2hpMoCYXbjJ7Lk6dwy7Ajnj1OcNmgQN8mEbuTKUFvm6Z9jD7p00sgu3yV28d5CJspYvp5uLMkQ1L yF+Fb8627FwVZzzFVJR6LpLuVgksghE6JPbXbUkc11+LhqzPbNlMGoRrA9ZMKlIr75zBzfCB8epWCHaFtHwhNmoCEGDa7BfF+xOMntvmXPw2Tniwkr1qDiu7 0sFOVVypBM/vrixUE8cHlrim5+a2eLS5mGLlomJjJO1WbptVfsNsVcNND0arOlGBlYnzF8CGl/Um5824e10h5LXnRJ83xaTtV3lP/8KIJaOhUwZXM6XX85O3 1ADvVVFNPja6lqa7r9TAc+dnWyWJpOt/qXpJnaDt6/VyGU/4veRY7tWd2iTtLWqv5ubwJr4jXdHPFwipc6qMUtLrpT7oQKtY/bZ0ffSoUPrV6em8wY/Vr0wl SXASMY2PrVAyS/pINjyELpcNs74rpGYbZ1xRGjb30zNCN5fsPehFkp/p8olKxoGXX3Zrzr+H9Ti3umfO Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/29/2018 02:15 PM, Smitha T Murthy wrote: >>>> >>> The values set in V4L2_CID_MPEG_VIDEO_HEVC_MIN_QP and >>> V4L2_CID_MPEG_VIDEO_HEVC_MAX_QP will give the limits for the L0-L6 QP >>> values that can be set. >> >> OK. If you can clarify this in the documentation, then I can Ack this. >> >> Note: if userspace changes MIN_QP or MAX_QP, then the driver should call >> v4l2_ctrl_modify_range() to update the ranges of the controls that are >> impacted by QP range changes. I'm not sure if that's done at the moment. >> >> Regards, >> >> Hans >> >> > I can mention for all these controls range as > [V4L2_CID_MPEG_VIDEO_HEVC_MIN_QP, V4L2_CID_MPEG_VIDEO_HEVC_MAX_QP]. > Will this be ok? Yes, that sounds good. Hans From mboxrd@z Thu Jan 1 00:00:00 1970 From: hverkuil@xs4all.nl (Hans Verkuil) Date: Mon, 29 Jan 2018 14:39:38 +0100 Subject: [Patch v7 12/12] Documention: v4l: Documentation for HEVC CIDs In-Reply-To: <1517231702.29374.13.camel@smitha-fedora> References: <1516791584-7980-1-git-send-email-smitha.t@samsung.com> <1516791584-7980-13-git-send-email-smitha.t@samsung.com> <127cfd7f-113f-6724-297c-6f3c3746a8ff@xs4all.nl> <1517229778.29374.9.camel@smitha-fedora> <1517231702.29374.13.camel@smitha-fedora> Message-ID: <3a746ca1-728f-f32f-a4b9-df99f2784c2b@xs4all.nl> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 01/29/2018 02:15 PM, Smitha T Murthy wrote: >>>> >>> The values set in V4L2_CID_MPEG_VIDEO_HEVC_MIN_QP and >>> V4L2_CID_MPEG_VIDEO_HEVC_MAX_QP will give the limits for the L0-L6 QP >>> values that can be set. >> >> OK. If you can clarify this in the documentation, then I can Ack this. >> >> Note: if userspace changes MIN_QP or MAX_QP, then the driver should call >> v4l2_ctrl_modify_range() to update the ranges of the controls that are >> impacted by QP range changes. I'm not sure if that's done at the moment. >> >> Regards, >> >> Hans >> >> > I can mention for all these controls range as > [V4L2_CID_MPEG_VIDEO_HEVC_MIN_QP, V4L2_CID_MPEG_VIDEO_HEVC_MAX_QP]. > Will this be ok? Yes, that sounds good. Hans