From: Fabrice Gasnier <fabrice.gasnier@st.com>
To: Alexandre Torgue <alexandre.torgue@st.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
arnd@arndb.de, robh+dt@kernel.org, mark.rutland@arm.com,
linux@armlinux.org.uk
Cc: devicetree@vger.kernel.org, erwan.leray@st.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: stm32: Fix IRQ_TYPE_NONE warnings on stm32mp157c
Date: Wed, 2 May 2018 16:28:03 +0200 [thread overview]
Message-ID: <3a9408b2-2670-4098-3311-b30658ac3011@st.com> (raw)
In-Reply-To: <1525267434-12644-1-git-send-email-alexandre.torgue@st.com>
On 05/02/2018 03:23 PM, Alexandre Torgue wrote:
> Since commit 83a86fbb5b56 ("irqchip/gic: Loudly complain about
> the use of IRQ_TYPE_NONE"), a warning is raised if IRQ_TYPE_NONE is used.
> So we use IRQ_TYPE_LEVEL_HIGH for usart nodes instead of IRQ_TYPE_NONE.
>
> Signed-off-by: Alexandre Torgue <alexandre.torgue@st.com>
Hi Alexandre,
Tested-by: Fabrice Gasnier <fabrice.gasnier@st.com>
BR,
Fabrice
>
> diff --git a/arch/arm/boot/dts/stm32mp157c.dtsi b/arch/arm/boot/dts/stm32mp157c.dtsi
> index 9c1a6c4..d096d06 100644
> --- a/arch/arm/boot/dts/stm32mp157c.dtsi
> +++ b/arch/arm/boot/dts/stm32mp157c.dtsi
> @@ -314,7 +314,7 @@
> usart2: serial@4000e000 {
> compatible = "st,stm32h7-uart";
> reg = <0x4000e000 0x400>;
> - interrupts = <GIC_SPI 38 IRQ_TYPE_NONE>;
> + interrupts = <GIC_SPI 38 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&rcc USART2_K>;
> status = "disabled";
> };
> @@ -322,7 +322,7 @@
> usart3: serial@4000f000 {
> compatible = "st,stm32h7-uart";
> reg = <0x4000f000 0x400>;
> - interrupts = <GIC_SPI 39 IRQ_TYPE_NONE>;
> + interrupts = <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&rcc USART3_K>;
> status = "disabled";
> };
> @@ -330,7 +330,7 @@
> uart4: serial@40010000 {
> compatible = "st,stm32h7-uart";
> reg = <0x40010000 0x400>;
> - interrupts = <GIC_SPI 52 IRQ_TYPE_NONE>;
> + interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&rcc UART4_K>;
> status = "disabled";
> };
> @@ -338,7 +338,7 @@
> uart5: serial@40011000 {
> compatible = "st,stm32h7-uart";
> reg = <0x40011000 0x400>;
> - interrupts = <GIC_SPI 53 IRQ_TYPE_NONE>;
> + interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&rcc UART5_K>;
> status = "disabled";
> };
> @@ -370,7 +370,7 @@
> uart7: serial@40018000 {
> compatible = "st,stm32h7-uart";
> reg = <0x40018000 0x400>;
> - interrupts = <GIC_SPI 82 IRQ_TYPE_NONE>;
> + interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&rcc UART7_K>;
> status = "disabled";
> };
> @@ -378,7 +378,7 @@
> uart8: serial@40019000 {
> compatible = "st,stm32h7-uart";
> reg = <0x40019000 0x400>;
> - interrupts = <GIC_SPI 83 IRQ_TYPE_NONE>;
> + interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&rcc UART8_K>;
> status = "disabled";
> };
> @@ -428,7 +428,7 @@
> usart6: serial@44003000 {
> compatible = "st,stm32h7-uart";
> reg = <0x44003000 0x400>;
> - interrupts = <GIC_SPI 71 IRQ_TYPE_NONE>;
> + interrupts = <GIC_SPI 71 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&rcc USART6_K>;
> status = "disabled";
> };
> @@ -591,7 +591,7 @@
> usart1: serial@5c000000 {
> compatible = "st,stm32h7-uart";
> reg = <0x5c000000 0x400>;
> - interrupts = <GIC_SPI 37 IRQ_TYPE_NONE>;
> + interrupts = <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&rcc USART1_K>;
> status = "disabled";
> };
>
WARNING: multiple messages have this Message-ID (diff)
From: fabrice.gasnier@st.com (Fabrice Gasnier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: stm32: Fix IRQ_TYPE_NONE warnings on stm32mp157c
Date: Wed, 2 May 2018 16:28:03 +0200 [thread overview]
Message-ID: <3a9408b2-2670-4098-3311-b30658ac3011@st.com> (raw)
In-Reply-To: <1525267434-12644-1-git-send-email-alexandre.torgue@st.com>
On 05/02/2018 03:23 PM, Alexandre Torgue wrote:
> Since commit 83a86fbb5b56 ("irqchip/gic: Loudly complain about
> the use of IRQ_TYPE_NONE"), a warning is raised if IRQ_TYPE_NONE is used.
> So we use IRQ_TYPE_LEVEL_HIGH for usart nodes instead of IRQ_TYPE_NONE.
>
> Signed-off-by: Alexandre Torgue <alexandre.torgue@st.com>
Hi Alexandre,
Tested-by: Fabrice Gasnier <fabrice.gasnier@st.com>
BR,
Fabrice
>
> diff --git a/arch/arm/boot/dts/stm32mp157c.dtsi b/arch/arm/boot/dts/stm32mp157c.dtsi
> index 9c1a6c4..d096d06 100644
> --- a/arch/arm/boot/dts/stm32mp157c.dtsi
> +++ b/arch/arm/boot/dts/stm32mp157c.dtsi
> @@ -314,7 +314,7 @@
> usart2: serial at 4000e000 {
> compatible = "st,stm32h7-uart";
> reg = <0x4000e000 0x400>;
> - interrupts = <GIC_SPI 38 IRQ_TYPE_NONE>;
> + interrupts = <GIC_SPI 38 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&rcc USART2_K>;
> status = "disabled";
> };
> @@ -322,7 +322,7 @@
> usart3: serial at 4000f000 {
> compatible = "st,stm32h7-uart";
> reg = <0x4000f000 0x400>;
> - interrupts = <GIC_SPI 39 IRQ_TYPE_NONE>;
> + interrupts = <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&rcc USART3_K>;
> status = "disabled";
> };
> @@ -330,7 +330,7 @@
> uart4: serial at 40010000 {
> compatible = "st,stm32h7-uart";
> reg = <0x40010000 0x400>;
> - interrupts = <GIC_SPI 52 IRQ_TYPE_NONE>;
> + interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&rcc UART4_K>;
> status = "disabled";
> };
> @@ -338,7 +338,7 @@
> uart5: serial at 40011000 {
> compatible = "st,stm32h7-uart";
> reg = <0x40011000 0x400>;
> - interrupts = <GIC_SPI 53 IRQ_TYPE_NONE>;
> + interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&rcc UART5_K>;
> status = "disabled";
> };
> @@ -370,7 +370,7 @@
> uart7: serial at 40018000 {
> compatible = "st,stm32h7-uart";
> reg = <0x40018000 0x400>;
> - interrupts = <GIC_SPI 82 IRQ_TYPE_NONE>;
> + interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&rcc UART7_K>;
> status = "disabled";
> };
> @@ -378,7 +378,7 @@
> uart8: serial at 40019000 {
> compatible = "st,stm32h7-uart";
> reg = <0x40019000 0x400>;
> - interrupts = <GIC_SPI 83 IRQ_TYPE_NONE>;
> + interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&rcc UART8_K>;
> status = "disabled";
> };
> @@ -428,7 +428,7 @@
> usart6: serial at 44003000 {
> compatible = "st,stm32h7-uart";
> reg = <0x44003000 0x400>;
> - interrupts = <GIC_SPI 71 IRQ_TYPE_NONE>;
> + interrupts = <GIC_SPI 71 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&rcc USART6_K>;
> status = "disabled";
> };
> @@ -591,7 +591,7 @@
> usart1: serial at 5c000000 {
> compatible = "st,stm32h7-uart";
> reg = <0x5c000000 0x400>;
> - interrupts = <GIC_SPI 37 IRQ_TYPE_NONE>;
> + interrupts = <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&rcc USART1_K>;
> status = "disabled";
> };
>
next prev parent reply other threads:[~2018-05-02 14:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-02 13:23 [PATCH] ARM: dts: stm32: Fix IRQ_TYPE_NONE warnings on stm32mp157c Alexandre Torgue
2018-05-02 13:23 ` Alexandre Torgue
2018-05-02 14:28 ` Fabrice Gasnier [this message]
2018-05-02 14:28 ` Fabrice Gasnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a9408b2-2670-4098-3311-b30658ac3011@st.com \
--to=fabrice.gasnier@st.com \
--cc=alexandre.torgue@st.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=erwan.leray@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.