From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0063C433E0 for ; Tue, 16 Feb 2021 21:05:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8333C64E85 for ; Tue, 16 Feb 2021 21:05:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230142AbhBPVFj (ORCPT ); Tue, 16 Feb 2021 16:05:39 -0500 Received: from mail.codeweavers.com ([50.203.203.244]:49504 "EHLO mail.codeweavers.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229544AbhBPVFh (ORCPT ); Tue, 16 Feb 2021 16:05:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=codeweavers.com; s=6377696661; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:References:Cc:To:From:Subject:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=zY97zwVfWY8WHBbRL37+t2vDGTB3LFeY2gz0qcPX4rg=; b=o6sI+KaNN7UwXzejCtEYCGWm0y DHoKihcJME+Cc+7JpJpi9YRwkz2gwEaChmfLti5vcn2S00KXUe3fjOFxDA2JL2ZJ+3LyxxFmU+6vS IR1GaBhn36H8g08ciVqz7YtYcmeL/CS/XthI989i0Pj5xW2U3iLy80h4iX9apLJSyGSw=; Received: from [10.69.141.136] by mail.codeweavers.com with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lC7We-0002Mh-3R; Tue, 16 Feb 2021 15:04:54 -0600 Subject: Re: [PATCH 2/2] perf buildid-cache: Add test for 16-byte build-id From: Nicholas Fraser To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , "Frank Ch. Eigler" , Song Liu , Adrian Hunter , Kim Phillips , Tommi Rantala , Remi Bernon , linux-kernel@vger.kernel.org Cc: Ulrich Czekalla , Huw Davies References: Message-ID: <3aa04469-b891-5d05-85bc-799af460d54f@codeweavers.com> Date: Tue, 16 Feb 2021 16:04:40 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sorry, I just realized I forgot to run checkpatch.pl on these; they're missing the --signoff. I'll re-send. On 2021-02-16 3:38 p.m., Nicholas Fraser wrote: > tests/shell/buildid.sh added an ELF executable with an MD5 build-id to > the perf debug cache but did not check whether the object was printed > by a subsequent call to "perf buildid-cache -l". It was being omitted > from the list. > > A previous commit fixed the bug that left it out of the list. This adds > a test for it. > --- > tools/perf/tests/shell/buildid.sh | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/tools/perf/tests/shell/buildid.sh b/tools/perf/tests/shell/buildid.sh > index 4861a20edee2..de02a23b7c7b 100755 > --- a/tools/perf/tests/shell/buildid.sh > +++ b/tools/perf/tests/shell/buildid.sh > @@ -50,6 +50,12 @@ check() > exit 1 > fi > > + ${perf} buildid-cache -l|grep $id > + if [ $? -ne 0 ]; then > + echo "failed: ${id} is not reported by \"perf buildid-cache -l\"" > + exit 1 > + fi > + > echo "OK for ${1}" > } > >