From: David Hildenbrand <david@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Thomas Huth" <thuth@redhat.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Cornelia Huck" <cohuck@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Markus Armbruster" <armbru@redhat.com>,
"Halil Pasic" <pasic@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@de.ibm.com>,
qemu-s390x <qemu-s390x@nongnu.org>,
"Michael Mueller" <mimu@linux.ibm.com>,
"Jiri Denemark" <jdenemar@redhat.com>,
"Janosch Frank" <frankja@linux.ibm.com>
Subject: Re: [PATCH v1 0/2] s390x/cpumodel: Introduce "best" model variants
Date: Mon, 18 Nov 2019 11:56:43 +0100 [thread overview]
Message-ID: <3aa1d025-20a3-e813-2fe6-35518efedf2f@redhat.com> (raw)
In-Reply-To: <CAFEAcA-Q7H9sZjN-PcMMDHQU41yN1RdXhNY5KqMh7E6xh0yjgA@mail.gmail.com>
On 18.11.19 11:53, Peter Maydell wrote:
> On Mon, 18 Nov 2019 at 10:47, David Hildenbrand <david@redhat.com> wrote:
>> My personal opinion: "max" really means "all features". If we want an
>> automatic way to specify something you requested ("give me something
>> that's going to work") we either have to change the definition of the
>> max model for alla rchitectures or introduce something that really
>> matches the "no -cpu specified" - e.g., "best".
>
> I don't strongly object to 'max' including deprecated features,
> but I do definitely object to 'max' including by default any
> experimental (x- prefix) features. Those should never be
> enabled (whatever the '-cpu foo' name) unless the user has
> specifically opted into them: that's the point of the x- prefix.
> We need to be able to tell from the command line whether it's
> got any non-standard weirdness enabled.
I'll let Eduardo respond to that, as we don't really have experimental
features on s390x, especially under KVM ("host" corresponds to "max").
>
> thanks
> -- PMM
>
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2019-11-18 11:01 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 11:07 [PATCH v1 0/2] s390x/cpumodel: Introduce "best" model variants David Hildenbrand
2019-11-08 11:07 ` [PATCH v1 1/2] s390x/cpumodels: Factor out CPU feature dependencies David Hildenbrand
2019-11-08 11:07 ` [PATCH v1 2/2] s390x/cpumodel: Introduce "best" model variants David Hildenbrand
2019-11-08 19:51 ` Eduardo Habkost
2019-11-08 21:18 ` David Hildenbrand
2019-11-08 11:10 ` [PATCH v1 0/2] " Peter Maydell
2019-11-08 12:46 ` David Hildenbrand
2019-11-08 13:02 ` Peter Maydell
2019-11-08 19:10 ` Eduardo Habkost
2019-11-08 22:58 ` David Hildenbrand
2019-11-09 16:07 ` Peter Maydell
2019-11-18 10:47 ` David Hildenbrand
2019-11-18 10:53 ` Peter Maydell
2019-11-18 10:56 ` David Hildenbrand [this message]
2019-11-18 10:59 ` Peter Maydell
2019-11-18 18:49 ` Eduardo Habkost
2019-11-18 21:19 ` Peter Maydell
2019-11-18 22:04 ` Eduardo Habkost
2019-11-19 9:22 ` Peter Maydell
2019-11-19 9:58 ` David Hildenbrand
2019-11-19 10:36 ` Peter Maydell
2019-11-19 11:00 ` David Hildenbrand
2019-11-19 19:42 ` Eduardo Habkost
2019-11-20 10:28 ` David Hildenbrand
2019-11-20 14:04 ` Eduardo Habkost
2019-11-20 14:21 ` David Hildenbrand
2019-11-08 16:59 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3aa1d025-20a3-e813-2fe6-35518efedf2f@redhat.com \
--to=david@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=ehabkost@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=jdenemar@redhat.com \
--cc=mimu@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.