From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B44DC4338F for ; Mon, 23 Aug 2021 11:15:28 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E7D5861374 for ; Mon, 23 Aug 2021 11:15:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E7D5861374 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 57625898AA; Mon, 23 Aug 2021 11:15:26 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 67DA9898AA for ; Mon, 23 Aug 2021 11:15:24 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10084"; a="204278603" X-IronPort-AV: E=Sophos;i="5.84,344,1620716400"; d="scan'208";a="204278603" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Aug 2021 04:15:23 -0700 X-IronPort-AV: E=Sophos;i="5.84,344,1620716400"; d="scan'208";a="492663109" Received: from mkayyal-mobl.ger.corp.intel.com (HELO [10.249.254.235]) ([10.249.254.235]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Aug 2021 04:15:22 -0700 Message-ID: <3ad5188659ce362087db1980880ac47af60e639f.camel@linux.intel.com> Subject: Re: [PATCH 1/5] drm/vmwgfx: unbind in vmw_ttm_unpopulate From: Thomas =?ISO-8859-1?Q?Hellstr=F6m?= To: Christian =?ISO-8859-1?Q?K=F6nig?= , daniel.vetter@ffwll.ch, airlied@gmail.com Cc: dri-devel@lists.freedesktop.org Date: Mon, 23 Aug 2021 13:15:20 +0200 In-Reply-To: References: <20210728130552.2074-1-christian.koenig@amd.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.40.3 (3.40.3-1.fc34) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, 2021-08-23 at 13:05 +0200, Christian König wrote: > Adding Thomas on CC as well. > > Just a gentle ping. I think the patch set makes sense now. > > Regards, > Christian. > > Am 28.07.21 um 15:05 schrieb Christian König: > > Doing this in vmw_ttm_destroy() is to late. > > > > It turned out that this is not a good idea at all because it leaves > > pointers > > to freed up system memory pages in the GART tables of the drivers. > > > > Signed-off-by: Christian König > > --- > >   drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c | 9 +++------ > >   1 file changed, 3 insertions(+), 6 deletions(-) > > Reviewed-by: Thomas Hellström