From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03F38C433E7 for ; Thu, 15 Oct 2020 13:16:07 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 4BBD42225C for ; Thu, 15 Oct 2020 13:16:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4BBD42225C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 782D41E91D; Thu, 15 Oct 2020 15:16:04 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id DAA331E8C4 for ; Thu, 15 Oct 2020 15:16:01 +0200 (CEST) IronPort-SDR: VIEzVSAoi1XAI+4i/FYbTdmNkLCvmRUhih3rjhy+A9p1WSR6U8thnZrQPaRfsSWFsADqpJ+5lS XhVM01+m71+g== X-IronPort-AV: E=McAfee;i="6000,8403,9774"; a="166399704" X-IronPort-AV: E=Sophos;i="5.77,379,1596524400"; d="scan'208";a="166399704" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Oct 2020 06:15:55 -0700 IronPort-SDR: I8VuPUDPI3utDaXrALb4hksR/oxrp5hn0XiIPDJ4w7r9Cuo6lZHpitLmAt2itTL9suPU2hr0zp 7s6LeVIuCCyw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,379,1596524400"; d="scan'208";a="520765541" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga006.fm.intel.com with ESMTP; 15 Oct 2020 06:15:54 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 15 Oct 2020 06:15:54 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX601.ccr.corp.intel.com (10.109.6.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 15 Oct 2020 21:15:52 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.1713.004; Thu, 15 Oct 2020 21:15:52 +0800 From: "Zhang, Qi Z" To: "Xu, Rosen" , "Zhang, Tianfei" , "dev@dpdk.org" , "Huang, Wei" Thread-Topic: [PATCH v2 3/4] raw/ifpga/base: cleanup ifpga raw devices when process quit Thread-Index: AQHWlgIAOMJIrX9Iak6Pcgr4TDjHk6mYvokg Date: Thu, 15 Oct 2020 13:15:52 +0000 Message-ID: <3addc949dbb64766b446fdef8eeb4d43@intel.com> References: <1600846213-18093-1-git-send-email-tianfei.zhang@intel.com> <1601257218-6606-1-git-send-email-tianfei.zhang@intel.com> <1601257218-6606-4-git-send-email-tianfei.zhang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-originating-ip: [10.108.32.68] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 3/4] raw/ifpga/base: cleanup ifpga raw devices when process quit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Xu, Rosen > Sent: Tuesday, September 29, 2020 9:43 AM > To: Zhang, Tianfei ; dev@dpdk.org; Huang, Wei > > Subject: Re: [dpdk-dev] [PATCH v2 3/4] raw/ifpga/base: cleanup ifpga raw > devices when process quit >=20 > Hi, >=20 > > -----Original Message----- > > From: Zhang, Tianfei > > Sent: Monday, September 28, 2020 9:40 > > To: dev@dpdk.org; Xu, Rosen ; Huang, Wei > > > > Cc: Zhang, Tianfei > > Subject: [PATCH v2 3/4] raw/ifpga/base: cleanup ifpga raw devices when > > process quit > > > > From: Wei Huang > > > > Add function ifpga_rawdev_cleanup() to cleanup all ifpga raw devices > > and register it as RTE_FINI function to make it called after main(). > > > > Signed-off-by: Wei Huang > > Signed-off-by: Tianfei zhang > > --- > > drivers/raw/ifpga/ifpga_rawdev.c | 20 ++++++++++++++++++++ > > 1 file changed, 20 insertions(+) > > > > diff --git a/drivers/raw/ifpga/ifpga_rawdev.c > > b/drivers/raw/ifpga/ifpga_rawdev.c > > index 98b02b5fa..1bc500a2a 100644 > > --- a/drivers/raw/ifpga/ifpga_rawdev.c > > +++ b/drivers/raw/ifpga/ifpga_rawdev.c > > @@ -1609,6 +1609,26 @@ > > RTE_PMD_REGISTER_PCI_TABLE(ifpga_rawdev_pci_driver, > > rte_ifpga_rawdev_pmd); > > RTE_PMD_REGISTER_KMOD_DEP(ifpga_rawdev_pci_driver, "* igb_uio | > > uio_pci_generic | vfio-pci"); RTE_LOG_REGISTER(ifpga_rawdev_logtype, > > driver.raw.init, NOTICE); > > > > +RTE_FINI(ifpga_rawdev_cleanup) > > +{ > > + struct ifpga_rawdev *dev; > > + struct opae_adapter *adapter; > > + unsigned int i; > > + > > + for (i =3D 0; i < IFPGA_RAWDEV_NUM; i++) { > > + dev =3D &ifpga_rawdevices[i]; > > + if (dev->rawdev) { > > + adapter =3D ifpga_rawdev_get_priv(dev->rawdev); > > + if (adapter) { > > + opae_adapter_destroy(adapter); > > + opae_adapter_data_free(adapter->data); > > + } > > + rte_rawdev_pmd_release(dev->rawdev); > > + dev->rawdev =3D NULL; > > + } > > + } > > +} > > + > > static const char * const valid_args[] =3D { > > #define IFPGA_ARG_NAME "ifpga" > > IFPGA_ARG_NAME, > > -- > > 2.17.1 >=20 > Acked-by: Rosen Xu Applied to dpdk-next-net-intel. Thanks Qi