All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonas Bonn <jonas@southpole.se>
To: Harald Welte <laforge@gnumonks.org>
Cc: pablo@netfilter.org, netdev@vger.kernel.org
Subject: Re: [PATCH 1/1] gtp: support SGSN-side tunnels
Date: Tue, 21 Mar 2017 16:11:25 +0100	[thread overview]
Message-ID: <3aee55f1-f42d-a0b5-5d50-b6bbea5ca74a@southpole.se> (raw)
In-Reply-To: <20170315163916.gins7lzzqhwkvfrc@nataraja>

Hi Harald,

On 03/15/2017 05:39 PM, Harald Welte wrote:
> Hi Jonas,
>
> are you working on the review feedback that was provided back in early
> February?  I think there were some comments like
> * remove unrelated cosmetic change in comment
> * change from FLAGS to a dedicated MODE netlink attribute
> * add libgtpnl code and some usage information or even sample scripts
>
> I would definitely like to see this move forward, particularly in order
> to test the GGSN-side code.

Sorry for the delay in this.

I've sent, just now, revised patches to the kernel module.

I was going to send some libgtpnl patches but I noticed, when gathering 
these up, that you have already made most of the necessary changes on a 
new branch.  What you've got there is almost identical to what I've got.

Since you used the terminology "role" instead of "mode" in your libgtpnl 
branch, I made the corresponding change in the kernel module, too, so it 
now calls this role instead of mode.

Regards,
Jonas




>
> Regards,
> 	Harald

  parent reply	other threads:[~2017-03-21 15:55 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-03  9:12 [PATCH 1/1] gtp: support SGSN-side tunnels Jonas Bonn
2017-02-06 11:08 ` Pablo Neira Ayuso
2017-02-06 13:33   ` Jonas Bonn
2017-02-06 14:16     ` Harald Welte
2017-02-06 18:15       ` Pablo Neira Ayuso
2017-02-06 17:27     ` Andreas Schultz
2017-02-06 17:56     ` Pablo Neira Ayuso
2017-02-06 17:25   ` Andreas Schultz
2017-02-06 13:44 ` Harald Welte
2017-02-13  9:25 ` Andreas Schultz
2017-02-13 11:16   ` Pablo Neira Ayuso
2017-02-13 11:52     ` Andreas Schultz
2017-02-13 14:23       ` Harald Welte
2017-03-15 16:39 ` Harald Welte
2017-03-15 17:23   ` Pablo Neira Ayuso
2017-03-15 19:10     ` Harald Welte
2017-03-15 19:27       ` Harald Welte
2017-03-15 21:42       ` Pablo Neira Ayuso
2017-03-21 15:11   ` Jonas Bonn [this message]
2017-03-21 15:04 ` [PATCH v2 1/2] gtp: rename SGSN netlink attribute Jonas Bonn
2017-03-21 15:04   ` [PATCH v2 2/2] gtp: support SGSN-side tunnels Jonas Bonn
2017-03-21 15:07   ` [PATCH v2 1/2] gtp: rename SGSN netlink attribute Pablo Neira Ayuso
2017-03-21 15:10     ` Jonas Bonn
2017-03-21 15:15       ` Pablo Neira Ayuso
2017-03-23 21:16   ` David Miller
2017-03-23 21:28     ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3aee55f1-f42d-a0b5-5d50-b6bbea5ca74a@southpole.se \
    --to=jonas@southpole.se \
    --cc=laforge@gnumonks.org \
    --cc=netdev@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.