All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>, jack@suse.cz
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH] loop: remember whether sysfs_create_group() succeeded
Date: Fri, 4 May 2018 08:15:58 -0600	[thread overview]
Message-ID: <3afa1009-c55e-08e2-32b9-49fde1c587c8@kernel.dk> (raw)
In-Reply-To: <201805042047.EFJ26068.OtOJFSLFFQOVHM@I-love.SAKURA.ne.jp>

On 5/4/18 5:47 AM, Tetsuo Handa wrote:
>>>From 626d33de1b70b11ecaf95a9f83f7644998e54cbb Mon Sep 17 00:00:00 2001
> From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> Date: Wed, 2 May 2018 23:03:48 +0900
> Subject: [PATCH] loop: remember whether sysfs_create_group() succeeded
> 
> syzbot is hitting WARN() triggered by memory allocation fault
> injection [1] because loop module is calling sysfs_remove_group()
> when sysfs_create_group() failed.
> Fix this by remembering whether sysfs_create_group() succeeded.

Can we store this locally instead of in the loop_device? Also,
naming wise, something like sysfs_init_done would be more readily
understandable.

-- 
Jens Axboe

  reply	other threads:[~2018-05-04 14:15 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <001a113ed2fa7bedfe055c8316a5@google.com>
2017-10-27  8:43 ` WARNING in sysfs_remove_group Greg KH
2017-10-27  9:10   ` Dmitry Vyukov
2017-10-27  9:23     ` Greg KH
2017-10-27  9:30       ` Dmitry Vyukov
2017-12-23 20:50 ` syzbot
2018-05-02 14:11   ` Tetsuo Handa
2018-05-02 14:24     ` Greg KH
2018-05-04 11:47       ` [PATCH] loop: remember whether sysfs_create_group() succeeded Tetsuo Handa
2018-05-04 14:15         ` Jens Axboe [this message]
2018-05-04 14:27           ` Tetsuo Handa
2018-05-04 14:30             ` Jens Axboe
2018-05-04 14:40               ` Tetsuo Handa
2018-05-04 14:43                 ` Jens Axboe
2018-05-04 16:14                   ` [PATCH v2] " Tetsuo Handa
2018-05-04 16:27                     ` Jens Axboe
2018-05-04 16:47                       ` Tetsuo Handa
2018-05-05 10:46                 ` [PATCH] " Milan Broz
2018-05-05 11:49                   ` Tetsuo Handa
2018-05-08  9:02                     ` Milan Broz
2018-05-09 12:31         ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3afa1009-c55e-08e2-32b9-49fde1c587c8@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=jack@suse.cz \
    --cc=linux-block@vger.kernel.org \
    --cc=penguin-kernel@I-love.SAKURA.ne.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.