All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Marco Berizzi <pupilla@libero.it>, David Ahern <dsahern@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH net] net: sched: Remove TCA_OPTIONS from policy
Date: Fri, 26 Oct 2018 09:48:25 -0600	[thread overview]
Message-ID: <3afc552f-2f76-4555-31af-ffeb4a2fb9ff@gmail.com> (raw)
In-Reply-To: <1305358874.1795395.1540553653206@mail.libero.it>

On 10/26/18 5:34 AM, Marco Berizzi wrote:
> Apologies for bothering you again.
> I applied your patch to 4.19, but after issuing this
> command:
> 
> root@Calimero:~# tc qdisc add dev eth0 root handle 1:0 hfsc default 1
> root@Calimero:~# ping 10.81.104.1
> PING 10.81.104.1 (10.81.104.1) 56(84) bytes of data.
> ^C
> --- 10.81.104.1 ping statistics ---
> 2 packets transmitted, 0 received, 100% packet loss, time 1001ms
> 
> I'm losing ipv4 connectivity.
> If I remove the qdisc everything is going to work again:
> 
> root@Calimero:~# tc qdisc del dev eth0 root                   
> root@Calimero:~# ping 10.81.104.1
> PING 10.81.104.1 (10.81.104.1) 56(84) bytes of data.
> 64 bytes from 10.81.104.1: icmp_seq=1 ttl=255 time=0.711 ms
> ^C
> --- 10.81.104.1 ping statistics ---
> 1 packets transmitted, 1 received, 0% packet loss, time 0ms
> rtt min/avg/max/mdev = 0.711/0.711/0.711/0.000 ms
> 

I backed up to 95278ddaa15cfa23e4a06ee9ed7b6ee0197c500b which is the
commit before the validation patch and it does not work there.

Can you bisect and find out when it stopped working?

  reply	other threads:[~2018-10-27  0:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-24 15:32 [PATCH net] net: sched: Remove TCA_OPTIONS from policy David Ahern
2018-10-24 21:35 ` David Miller
2018-10-25  6:31 ` Jiri Pirko
2018-10-26 16:02   ` David Ahern
2018-10-26 16:08     ` Jiri Pirko
2018-10-26 11:34 ` Marco Berizzi
2018-10-26 15:48   ` David Ahern [this message]
2018-10-26 18:19   ` Cong Wang
2018-10-31 12:42     ` Marco Berizzi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3afc552f-2f76-4555-31af-ffeb4a2fb9ff@gmail.com \
    --to=dsahern@gmail.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pupilla@libero.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.