From: Paolo Bonzini <pbonzini@redhat.com>
To: Sean Christopherson <seanjc@google.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH kvm-unit-tests] x86: clean up EFER definitions
Date: Thu, 18 Feb 2021 19:31:42 +0100 [thread overview]
Message-ID: <3b33ecee-e123-1fae-db99-7acf8192b29d@redhat.com> (raw)
In-Reply-To: <YC6rsTdE1iqiYYYO@google.com>
On 18/02/21 19:02, Sean Christopherson wrote:
> On Thu, Feb 18, 2021, Paolo Bonzini wrote:
>> The X86_EFER_LMA definition is wrong, while X86_IA32_EFER is unused.
>> There are also two useless WRMSRs that try to set EFER_LMA in
>> x86/pks.c and x86/pku.c. Clean them all up.
>
> For posterity: EFER_LMA is incorrectly defined as EFER_LME, and both PKS and PKU
> tests are 64-bit only, so the WRMSRs are guaranteed to be nops.
Added to the commit message and pushed, thanks.
Paolo
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>
> Reviewed-by: Sean Christopherson <seanjc@google.com>
>
prev parent reply other threads:[~2021-02-18 18:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-18 13:26 [PATCH kvm-unit-tests] x86: clean up EFER definitions Paolo Bonzini
2021-02-18 18:02 ` Sean Christopherson
2021-02-18 18:31 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b33ecee-e123-1fae-db99-7acf8192b29d@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.