All of lore.kernel.org
 help / color / mirror / Atom feed
From: WANG Xuerui <i@xen0n.name>
To: Du Huanpeng <u74147@gmail.com>, Tiezhu Yang <yangtiezhu@loongson.cn>
Cc: WANG Xuerui <git@xen0n.name>,
	linux-rtc@vger.kernel.org, linux-mips@vger.kernel.org,
	devicetree@vger.kernel.org, Huacai Chen <chenhc@lemote.com>
Subject: Re: [PATCH 1/4] rtc: ls2x: Add support for the Loongson-2K/LS7A RTC
Date: Fri, 25 Sep 2020 14:13:13 +0800	[thread overview]
Message-ID: <3b35cd8d-012a-18b5-50c3-8dae19cc53b1@xen0n.name> (raw)
In-Reply-To: <20200923143149.GA11566@tkernel.org>

(Re-sending, as the original reply inadvertently contained an HTML part
and has been blocked by all of the mailing lists.)

Hi Huanpeng,

On 2020/9/23 22:31, Du Huanpeng wrote:

>> rtc-ls2x --> rtc-ls2x-ls7a
>> RTC_DRV_LS2X --> RTC_DRV_LS2X_LS7A
>> Loongson LS2X RTC --> Loongson LS2X/LS7A RTC
>>
>> Maybe the related names include ls7a or LS7A is better to
>> reflect the reality?
> Is there any difference with the rtc IP in loongson 1* SoCs?

From a cursory look at 1A and 7A manuals the registers seem to have the
same layout. Some registers are marked as "reserved" on the 7A manual
while having real meaning on 1A, like the sys_toytrim and sys_rtctrim
registers.

I am investigating whether the rtc_ls1x driver could be worked to
support DT configuration, along with the hardcoded addresses when
compiled for Loongson 1A. If so, adding a separate rtc_ls2x may not be
necessary, rtc_ls1x would be turned into something like rtc_loongson
instead.

>
> Regards,
> Du Huanpeng

  reply	other threads:[~2020-09-25  6:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-23  7:58 [PATCH 0/4] rtc: ls2x: Add support for the Loongson-2K/LS7A RTC WANG Xuerui
2020-09-23  7:58 ` [PATCH 1/4] " WANG Xuerui
2020-09-23  9:54   ` Tiezhu Yang
2020-09-23 14:31     ` Du Huanpeng
2020-09-25  6:13       ` WANG Xuerui [this message]
2020-11-16 12:40         ` Tiezhu Yang
2020-09-24  7:32     ` WANG Xuerui
2020-09-23 13:50   ` Jiaxun Yang
2020-09-23  7:58 ` [PATCH 2/4] dt-bindings: rtc: Add bindings for LS2X RTC WANG Xuerui
2020-09-29 18:45   ` Rob Herring
2020-09-23  7:58 ` [PATCH 3/4] MIPS: Loongson64: DTS: Add RTC support to LS7A WANG Xuerui
2020-09-23  7:58 ` [PATCH 4/4] MIPS: Loongson: Enable LS2X RTC in loongson3_defconfig WANG Xuerui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3b35cd8d-012a-18b5-50c3-8dae19cc53b1@xen0n.name \
    --to=i@xen0n.name \
    --cc=chenhc@lemote.com \
    --cc=devicetree@vger.kernel.org \
    --cc=git@xen0n.name \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=u74147@gmail.com \
    --cc=yangtiezhu@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.