From: Paolo Bonzini <pbonzini@redhat.com>
To: Krish Sadhukhan <krish.sadhukhan@oracle.com>, kvm@vger.kernel.org
Subject: Re: [PATCH 1/3 v2] KVM: x86: Create mask for guest CR4 reserved bits in kvm_update_cpuid()
Date: Sat, 9 May 2020 14:56:17 +0200 [thread overview]
Message-ID: <3b3650b2-1f9f-6567-bf6e-28d7eca2ed89@redhat.com> (raw)
In-Reply-To: <20200509003652.25178-2-krish.sadhukhan@oracle.com>
On 09/05/20 02:36, Krish Sadhukhan wrote:
> +extern u64 __guest_cr4_reserved_bits;
> +
> int kvm_update_cpuid(struct kvm_vcpu *vcpu)
This cannot be a global, it is different for each guest since it depends
on their CPUID. Please put it in vcpu->arch.
Paolo
next prev parent reply other threads:[~2020-05-09 12:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-09 0:36 [PATCH 0/3 v2] KVM: nSVM: Check MBZ bits in CR3 and CR4 on vmrun of nested guests Krish Sadhukhan
2020-05-09 0:36 ` [PATCH 1/3 v2] KVM: x86: Create mask for guest CR4 reserved bits in kvm_update_cpuid() Krish Sadhukhan
2020-05-09 12:56 ` Paolo Bonzini [this message]
2020-05-09 0:36 ` [PATCH 2/3 v2] KVM: nSVM: Check that MBZ bits in CR3 and CR4 are not set on vmrun of nested guests Krish Sadhukhan
2020-05-09 0:36 ` [PATCH 3/3 v2] KVM: nSVM: Test " Krish Sadhukhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b3650b2-1f9f-6567-bf6e-28d7eca2ed89@redhat.com \
--to=pbonzini@redhat.com \
--cc=krish.sadhukhan@oracle.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.