From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DBA9C43460 for ; Thu, 15 Apr 2021 13:27:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0E7C0611AC for ; Thu, 15 Apr 2021 13:27:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233092AbhDON1v (ORCPT ); Thu, 15 Apr 2021 09:27:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230202AbhDON1u (ORCPT ); Thu, 15 Apr 2021 09:27:50 -0400 X-Greylist: delayed 354 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Thu, 15 Apr 2021 06:27:27 PDT Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51C1FC061574; Thu, 15 Apr 2021 06:27:25 -0700 (PDT) Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 8025681E77; Thu, 15 Apr 2021 15:21:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1618492888; bh=ZONWGzYKtU8DHCzBAyEFfKxI0PsF5qLdYZOEWoxUxKQ=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=rFO2ciQsIJnRAm72WtUX1yUdmKRSKfPKLDR/Zkra4IVdcKMG9S/2EoTdPdr1yEazy +V5V1F4LGvrw4RrmrpCZXFx50uaqsIYaU/af6YL3hPsgqEAjiOA99WEPKs5Vr+LNl+ nCxoVRycYBM7p8bG1ewYdBtqr3imi2bM2JhN2lQvSMzOSP1g/4n/Zlp+4oUIqdIVGB 4H5iVZeBMkNhxtCBLLNG4O//I+MILGLIKcLPnFx4LH5bnFmPb6o9ZlQgbofSAYYu0s ayRhbM9YD5mIKPKqhQIxEpzUYdiA7pLhWNGSln3l9RIHsO6UjVjxNEVFyae/Q1011+ 1dd4NJLYniHHw== Subject: Re: [PATCH 11/13] ARM: dts: stm32: fix LTDC port node on STM32 MCU ad MPU To: Alexandre Torgue , arnd@arndb.de, robh+dt@kernel.org, jagan@amarulasolutions.com, Manivannan Sadhasivam , Marcin Sloniewski , Ahmad Fatoum Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-kernel@vger.kernel.org, Lee Jones , kuba@kernel.org References: <20210415101037.1465-1-alexandre.torgue@foss.st.com> <20210415101037.1465-12-alexandre.torgue@foss.st.com> From: Marek Vasut Message-ID: <3b39908b-a263-a5d4-f6ac-ac30ffb06269@denx.de> Date: Thu, 15 Apr 2021 15:21:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210415101037.1465-12-alexandre.torgue@foss.st.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/15/21 12:10 PM, Alexandre Torgue wrote: > Running "make dtbs_check W=1", some warnings are reported concerning > LTDC port subnode: > > /soc/display-controller@5a001000/port: > unnecessary #address-cells/#size-cells without "ranges" or child "reg" > property > /soc/display-controller@5a001000/port: graph node has single child node > 'endpoint', #address-cells/#size-cells are not necessary btw could you retain diffstat on your patches ? It's useful to see which files changed right away. [...] > diff --git a/arch/arm/boot/dts/stm32mp157c-dk2.dts b/arch/arm/boot/dts/stm32mp157c-dk2.dts > index 2bc92ef3aeb9..19ef475a48fc 100644 > --- a/arch/arm/boot/dts/stm32mp157c-dk2.dts > +++ b/arch/arm/boot/dts/stm32mp157c-dk2.dts > @@ -82,9 +82,15 @@ > }; > > <dc { > - status = "okay"; > - > port { > + #address-cells = <1>; > + #size-cells = <0>; > + > + ltdc_ep0_out: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&sii9022_in>; > + }; > + > ltdc_ep1_out: endpoint@1 { > reg = <1>; > remote-endpoint = <&dsi_in>; [...] > diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi b/arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi > index 64dca5b7f748..e7f10975cacf 100644 > --- a/arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi > +++ b/arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi > @@ -277,11 +277,7 @@ > status = "okay"; > > port { > - #address-cells = <1>; > - #size-cells = <0>; > - > - ltdc_ep0_out: endpoint@0 { > - reg = <0>; > + ltdc_ep0_out: endpoint { > remote-endpoint = <&adv7513_in>; > }; > }; I think this is wrong, the AV96 can have two displays connected to two ports of the LTDC, just like DK2 for example. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BF0BC433B4 for ; Thu, 15 Apr 2021 13:23:14 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 98161611AC for ; Thu, 15 Apr 2021 13:23:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 98161611AC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DDx0jeq01cgSC+FiSJnG9gU16XMK3Etxc9+xR/6d7gc=; b=UZ5DI9Z033GHuZI/FOyRwJT3C oKMppfs5wsdQQdsF31v2AYNUiLp091/emz1o72T1xJ2JejgxgBSytOVUO3TK5c7KyEfrGZTZPdM5B /vnAjYG9K1TwOrRURy8C2anCXb0ZnlVhK/ZE6pIthql4dMjfWAkbTzUE/r7ocNNy85DwNm9c1L2HW ZXqfnrcsmCnEf4N4zd6qO2JiuDyHKXY4fdLbD7AjWibPU6gt4//AeE03Scp76LAEHcFyhRSYiVFAX 1bfX3J2d+UXybd85nJygtBPLgSUZXk5M67QdGRl8MqiRSODcTxXHFJmKoTtuf77+P67D6D38BlwGn ZuXy0fmLQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lX1wD-00GF0S-IZ; Thu, 15 Apr 2021 13:21:41 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lX1w9-00GF0N-UX for linux-arm-kernel@desiato.infradead.org; Thu, 15 Apr 2021 13:21:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=ZONWGzYKtU8DHCzBAyEFfKxI0PsF5qLdYZOEWoxUxKQ=; b=rG30mdzeTJSUTctKaUyh8kLDOY oz9VQzqTBPGXQ6R9TfoFXASFf1MneCg7RGgWBM9G1zTd7pDuT75ocWpVn4hCFrrT4Ojujioi2Q8Si KENEiFZRNMw5efmDsehlcDfcukKoXJ/E4thKTnzgdMo4EbXnzeDhVEZYbdhdSYdNvIp9RfhxuPWSU Yge/gyCO0QsHOyD8thcsTF+h9nXZXv+A1uvJdQ4dao06dgU+tuexnTS1TofLu1KYGtEU5dgIcDmSb 2krvXqiMzIQtrtlhs5wOEXk5ZMBEAG62hMtw2lucIHqlK6h2PiguliFr9eqGETydl/I544Mo31gxn MzstIpTw==; Received: from phobos.denx.de ([85.214.62.61]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lX1w4-008bLH-Hn for linux-arm-kernel@lists.infradead.org; Thu, 15 Apr 2021 13:21:35 +0000 Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 8025681E77; Thu, 15 Apr 2021 15:21:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1618492888; bh=ZONWGzYKtU8DHCzBAyEFfKxI0PsF5qLdYZOEWoxUxKQ=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=rFO2ciQsIJnRAm72WtUX1yUdmKRSKfPKLDR/Zkra4IVdcKMG9S/2EoTdPdr1yEazy +V5V1F4LGvrw4RrmrpCZXFx50uaqsIYaU/af6YL3hPsgqEAjiOA99WEPKs5Vr+LNl+ nCxoVRycYBM7p8bG1ewYdBtqr3imi2bM2JhN2lQvSMzOSP1g/4n/Zlp+4oUIqdIVGB 4H5iVZeBMkNhxtCBLLNG4O//I+MILGLIKcLPnFx4LH5bnFmPb6o9ZlQgbofSAYYu0s ayRhbM9YD5mIKPKqhQIxEpzUYdiA7pLhWNGSln3l9RIHsO6UjVjxNEVFyae/Q1011+ 1dd4NJLYniHHw== Subject: Re: [PATCH 11/13] ARM: dts: stm32: fix LTDC port node on STM32 MCU ad MPU To: Alexandre Torgue , arnd@arndb.de, robh+dt@kernel.org, jagan@amarulasolutions.com, Manivannan Sadhasivam , Marcin Sloniewski , Ahmad Fatoum Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-kernel@vger.kernel.org, Lee Jones , kuba@kernel.org References: <20210415101037.1465-1-alexandre.torgue@foss.st.com> <20210415101037.1465-12-alexandre.torgue@foss.st.com> From: Marek Vasut Message-ID: <3b39908b-a263-a5d4-f6ac-ac30ffb06269@denx.de> Date: Thu, 15 Apr 2021 15:21:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210415101037.1465-12-alexandre.torgue@foss.st.com> Content-Language: en-US X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210415_062133_724870_F94D3C0E X-CRM114-Status: GOOD ( 16.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/15/21 12:10 PM, Alexandre Torgue wrote: > Running "make dtbs_check W=1", some warnings are reported concerning > LTDC port subnode: > > /soc/display-controller@5a001000/port: > unnecessary #address-cells/#size-cells without "ranges" or child "reg" > property > /soc/display-controller@5a001000/port: graph node has single child node > 'endpoint', #address-cells/#size-cells are not necessary btw could you retain diffstat on your patches ? It's useful to see which files changed right away. [...] > diff --git a/arch/arm/boot/dts/stm32mp157c-dk2.dts b/arch/arm/boot/dts/stm32mp157c-dk2.dts > index 2bc92ef3aeb9..19ef475a48fc 100644 > --- a/arch/arm/boot/dts/stm32mp157c-dk2.dts > +++ b/arch/arm/boot/dts/stm32mp157c-dk2.dts > @@ -82,9 +82,15 @@ > }; > > <dc { > - status = "okay"; > - > port { > + #address-cells = <1>; > + #size-cells = <0>; > + > + ltdc_ep0_out: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&sii9022_in>; > + }; > + > ltdc_ep1_out: endpoint@1 { > reg = <1>; > remote-endpoint = <&dsi_in>; [...] > diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi b/arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi > index 64dca5b7f748..e7f10975cacf 100644 > --- a/arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi > +++ b/arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi > @@ -277,11 +277,7 @@ > status = "okay"; > > port { > - #address-cells = <1>; > - #size-cells = <0>; > - > - ltdc_ep0_out: endpoint@0 { > - reg = <0>; > + ltdc_ep0_out: endpoint { > remote-endpoint = <&adv7513_in>; > }; > }; I think this is wrong, the AV96 can have two displays connected to two ports of the LTDC, just like DK2 for example. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel