All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean-Francois Moine <moinejf@free.fr>
To: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v4 4/4] ASoC: simple-card: Remove useless check
Date: Sun, 9 Nov 2014 12:26:19 +0100	[thread overview]
Message-ID: <3b3dcd0172b0bdd0a661d65d697a73f837565309.1415605717.git.moinejf@free.fr> (raw)
In-Reply-To: <cover.1415605716.git.moinejf@free.fr>

The CPU and CODEC names are checked when getting the DAI names.
There is no need to check them once more.

Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
---
 sound/soc/generic/simple-card.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/sound/soc/generic/simple-card.c b/sound/soc/generic/simple-card.c
index 61f9500..c1ba78b 100644
--- a/sound/soc/generic/simple-card.c
+++ b/sound/soc/generic/simple-card.c
@@ -319,11 +319,6 @@ static int asoc_simple_card_dai_link_of(struct device_node *node,
 	if (ret < 0)
 		goto dai_link_of_err;
 
-	if (!dai_link->cpu_dai_name || !dai_link->codec_dai_name) {
-		ret = -EINVAL;
-		goto dai_link_of_err;
-	}
-
 	/* Simple Card assumes platform == cpu */
 	dai_link->platform_of_node = dai_link->cpu_of_node;
 
-- 
2.1.3


      parent reply	other threads:[~2014-11-10  8:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-10  7:48 [PATCH v4 0/4] ASoC: simple-card: Add multi-CODEC support Jean-Francois Moine
2014-11-10  7:48 ` Jean-Francois Moine
2014-11-08 19:06 ` [PATCH v4 1/4] ASoC: core: add multi-codec support in DT Jean-Francois Moine
2014-11-09  9:12 ` [PATCH v4 2/4] ASoC: simple-card: Remove useless function argument Jean-Francois Moine
2014-11-09 11:22 ` [PATCH v4 3/4] ASoC: simple-card: add multi-CODECs in DT Jean-Francois Moine
2014-11-10  8:39   ` Arnd Bergmann
2014-11-10  8:39     ` Arnd Bergmann
2014-11-10  9:05     ` Jean-Francois Moine
2014-11-10  9:05       ` Jean-Francois Moine
2014-11-10  9:04       ` Arnd Bergmann
2014-11-09 11:26 ` Jean-Francois Moine [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3b3dcd0172b0bdd0a661d65d697a73f837565309.1415605717.git.moinejf@free.fr \
    --to=moinejf@free.fr \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.