From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Wang, Dongsheng" <dongsheng.wang@hxt-semitech.com>
Subject: Re: Question about default m88e1510 LED configuration of marvell phy
Date: Tue, 15 Jan 2019 09:08:49 +0000
Message-ID: <3b4b16139b974dcf8a8d6d5223e0b901@HXTBJIDCEMVIW02.hxtcorp.net>
References: <1a4ecb58-7835-85f9-51b7-88b0cfca7eba@huawei.com>
 <20190115033910.GA11722@lunn.ch>
 <b09f1de8-63ac-79c3-acf8-3533b0ec2e10@huawei.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-2022-jp"
Content-Transfer-Encoding: 8BIT
Cc: Andrew Lunn <andrew@lun>, David Miller <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "Zhuangyuzeng (Yisen)" <yisen.zhuang@huawei.com>,
        Salil Mehta <salil.mehta@huawei.com>,
        "lipeng (Y)" <lipeng321@huawei.com>,
        Yunsheng Lin <linyunsheng@huawei.com>,
        Dengweiwei <dengweiwei@huawei.com>
To: "shenjian (K)" <shenjian15@huawei.com>,
        Andrew Lunn <andrew@lunn.ch>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mx01.hxt-semitech.com ([223.203.96.7]:39958 "EHLO
        barracuda.hxt-semitech.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1725929AbfAOJKs (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 15 Jan 2019 04:10:48 -0500
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 2019/1/15 14:41, shenjian (K) wrote:
>
> 在 2019/1/15 11:39, Andrew Lunn 写道:
>> On Tue, Jan 15, 2019 at 11:07:17AM +0800, shenjian (K) wrote:
>>> Hi, all
>>> 	We encounted a problem when using the marvel 88e151x phy driver, the
>>> link(LED[0])/ack(LED[1]) leds worked abnormally since we updated our kernel to v4.19.
>>> The act led kept on and never blink.  It works well when we use genphy driver, aslo
>>> works well when use marvell phy in kernel v4.18.
>>>
>>> 	I found that the default led configuration had been changed to 0x1177
>>> by commit commit 077772468ec1(net: phy: marvell: change default m88e1510 LED configuration).
>> It is a difficult job deciding what the driver should configure. I
>> would actually prefer to keeps with the reset default, which would be
>> 0x101e according to the datasheet.
>>
>> If you are using device tree, you have the option of poking values
>> into registers, using marvell,reg-init. There are a few examples you
>> can copy. Doing that guarantees you have the configuration you want.
>>
>>     Andrew
>>
>> .
>>
> Thanks, Andrew.
>
> But we are using acpi mode, is there any ohter way to poke values into registers ?

You can describe property in ACPI _DSD. And parse then in
marvell_config_init just like of.

Cheers
Dongsheng