From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Hunter Subject: Re: [PATCH v2 6/9] PM / Domains: Don't attach devices in genpd with multi PM domains Date: Wed, 30 May 2018 17:06:11 +0100 Message-ID: <3b5072bb-f4bb-3f71-9575-5263cdf0b09f@nvidia.com> References: <20180529100421.31022-1-ulf.hansson@linaro.org> <20180529100421.31022-7-ulf.hansson@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180529100421.31022-7-ulf.hansson@linaro.org> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Ulf Hansson , "Rafael J . Wysocki" , linux-pm@vger.kernel.org Cc: Greg Kroah-Hartman , Geert Uytterhoeven , Todor Tomov , Rajendra Nayak , Viresh Kumar , Vincent Guittot , Kevin Hilman , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, Rob Herring , devicetree@vger.kernel.org List-Id: linux-tegra@vger.kernel.org On 29/05/18 11:04, Ulf Hansson wrote: > The power-domain DT property may now contain a list of PM domain > specifiers, which represents that a device are partitioned across multiple > PM domains. This leads to a new situation in genpd_dev_pm_attach(), as only > one PM domain can be attached per device. > > To remain things simple for the most common configuration, when a single PM > domain is used, let's treat the multiple PM domain case as being specific. > > In other words, let's change genpd_dev_pm_attach() to check for multiple PM > domains and prevent it from attach any PM domain for this case. Instead, > leave this to be managed separately, from following changes to genpd. > > Cc: Rob Herring > Cc: devicetree@vger.kernel.org > Suggested-by: Jon Hunter > Signed-off-by: Ulf Hansson > --- > > Changes in v2: > - Minor update to changelog to mention "PM domain specifiers" rather > than a "list of phandles". > > --- > drivers/base/power/domain.c | 18 +++++++++++++----- > 1 file changed, 13 insertions(+), 5 deletions(-) > > diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c > index 7ebf7993273a..12a20f21974d 100644 > --- a/drivers/base/power/domain.c > +++ b/drivers/base/power/domain.c > @@ -2229,10 +2229,10 @@ static void genpd_dev_pm_sync(struct device *dev) > * attaches the device to retrieved pm_domain ops. > * > * Returns 1 on successfully attached PM domain, 0 when the device don't need a > - * PM domain or a negative error code in case of failures. Note that if a > - * power-domain exists for the device, but it cannot be found or turned on, > - * then return -EPROBE_DEFER to ensure that the device is not probed and to > - * re-try again later. > + * PM domain or when multiple power-domains exists for it, else a negative error > + * code. Note that if a power-domain exists for the device, but it cannot be > + * found or turned on, then return -EPROBE_DEFER to ensure that the device is > + * not probed and to re-try again later. > */ > int genpd_dev_pm_attach(struct device *dev) > { > @@ -2243,10 +2243,18 @@ int genpd_dev_pm_attach(struct device *dev) > if (!dev->of_node) > return 0; > > + /* > + * Devices with multiple PM domains must be attached separately, as we > + * can only attach one PM domain per device. > + */ > + if (of_count_phandle_with_args(dev->of_node, "power-domains", > + "#power-domain-cells") != 1) > + return 0; > + > ret = of_parse_phandle_with_args(dev->of_node, "power-domains", > "#power-domain-cells", 0, &pd_args); > if (ret < 0) > - return 0; > + return ret; > > mutex_lock(&gpd_list_lock); > pd = genpd_get_from_provider(&pd_args); > Acked-by: Jon Hunter Tested-by: Jon Hunter Cheers Jon -- nvpublic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753176AbeE3QGa (ORCPT ); Wed, 30 May 2018 12:06:30 -0400 Received: from hqemgate15.nvidia.com ([216.228.121.64]:5653 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751300AbeE3QGZ (ORCPT ); Wed, 30 May 2018 12:06:25 -0400 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Wed, 30 May 2018 09:06:24 -0700 Subject: Re: [PATCH v2 6/9] PM / Domains: Don't attach devices in genpd with multi PM domains To: Ulf Hansson , "Rafael J . Wysocki" , CC: Greg Kroah-Hartman , Geert Uytterhoeven , Todor Tomov , "Rajendra Nayak" , Viresh Kumar , Vincent Guittot , Kevin Hilman , , , , "Rob Herring" , References: <20180529100421.31022-1-ulf.hansson@linaro.org> <20180529100421.31022-7-ulf.hansson@linaro.org> From: Jon Hunter Message-ID: <3b5072bb-f4bb-3f71-9575-5263cdf0b09f@nvidia.com> Date: Wed, 30 May 2018 17:06:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180529100421.31022-7-ulf.hansson@linaro.org> X-Originating-IP: [172.20.13.39] X-ClientProxiedBy: HQMAIL103.nvidia.com (172.20.187.11) To HQMAIL101.nvidia.com (172.20.187.10) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/05/18 11:04, Ulf Hansson wrote: > The power-domain DT property may now contain a list of PM domain > specifiers, which represents that a device are partitioned across multiple > PM domains. This leads to a new situation in genpd_dev_pm_attach(), as only > one PM domain can be attached per device. > > To remain things simple for the most common configuration, when a single PM > domain is used, let's treat the multiple PM domain case as being specific. > > In other words, let's change genpd_dev_pm_attach() to check for multiple PM > domains and prevent it from attach any PM domain for this case. Instead, > leave this to be managed separately, from following changes to genpd. > > Cc: Rob Herring > Cc: devicetree@vger.kernel.org > Suggested-by: Jon Hunter > Signed-off-by: Ulf Hansson > --- > > Changes in v2: > - Minor update to changelog to mention "PM domain specifiers" rather > than a "list of phandles". > > --- > drivers/base/power/domain.c | 18 +++++++++++++----- > 1 file changed, 13 insertions(+), 5 deletions(-) > > diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c > index 7ebf7993273a..12a20f21974d 100644 > --- a/drivers/base/power/domain.c > +++ b/drivers/base/power/domain.c > @@ -2229,10 +2229,10 @@ static void genpd_dev_pm_sync(struct device *dev) > * attaches the device to retrieved pm_domain ops. > * > * Returns 1 on successfully attached PM domain, 0 when the device don't need a > - * PM domain or a negative error code in case of failures. Note that if a > - * power-domain exists for the device, but it cannot be found or turned on, > - * then return -EPROBE_DEFER to ensure that the device is not probed and to > - * re-try again later. > + * PM domain or when multiple power-domains exists for it, else a negative error > + * code. Note that if a power-domain exists for the device, but it cannot be > + * found or turned on, then return -EPROBE_DEFER to ensure that the device is > + * not probed and to re-try again later. > */ > int genpd_dev_pm_attach(struct device *dev) > { > @@ -2243,10 +2243,18 @@ int genpd_dev_pm_attach(struct device *dev) > if (!dev->of_node) > return 0; > > + /* > + * Devices with multiple PM domains must be attached separately, as we > + * can only attach one PM domain per device. > + */ > + if (of_count_phandle_with_args(dev->of_node, "power-domains", > + "#power-domain-cells") != 1) > + return 0; > + > ret = of_parse_phandle_with_args(dev->of_node, "power-domains", > "#power-domain-cells", 0, &pd_args); > if (ret < 0) > - return 0; > + return ret; > > mutex_lock(&gpd_list_lock); > pd = genpd_get_from_provider(&pd_args); > Acked-by: Jon Hunter Tested-by: Jon Hunter Cheers Jon -- nvpublic From mboxrd@z Thu Jan 1 00:00:00 1970 From: jonathanh@nvidia.com (Jon Hunter) Date: Wed, 30 May 2018 17:06:11 +0100 Subject: [PATCH v2 6/9] PM / Domains: Don't attach devices in genpd with multi PM domains In-Reply-To: <20180529100421.31022-7-ulf.hansson@linaro.org> References: <20180529100421.31022-1-ulf.hansson@linaro.org> <20180529100421.31022-7-ulf.hansson@linaro.org> Message-ID: <3b5072bb-f4bb-3f71-9575-5263cdf0b09f@nvidia.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 29/05/18 11:04, Ulf Hansson wrote: > The power-domain DT property may now contain a list of PM domain > specifiers, which represents that a device are partitioned across multiple > PM domains. This leads to a new situation in genpd_dev_pm_attach(), as only > one PM domain can be attached per device. > > To remain things simple for the most common configuration, when a single PM > domain is used, let's treat the multiple PM domain case as being specific. > > In other words, let's change genpd_dev_pm_attach() to check for multiple PM > domains and prevent it from attach any PM domain for this case. Instead, > leave this to be managed separately, from following changes to genpd. > > Cc: Rob Herring > Cc: devicetree at vger.kernel.org > Suggested-by: Jon Hunter > Signed-off-by: Ulf Hansson > --- > > Changes in v2: > - Minor update to changelog to mention "PM domain specifiers" rather > than a "list of phandles". > > --- > drivers/base/power/domain.c | 18 +++++++++++++----- > 1 file changed, 13 insertions(+), 5 deletions(-) > > diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c > index 7ebf7993273a..12a20f21974d 100644 > --- a/drivers/base/power/domain.c > +++ b/drivers/base/power/domain.c > @@ -2229,10 +2229,10 @@ static void genpd_dev_pm_sync(struct device *dev) > * attaches the device to retrieved pm_domain ops. > * > * Returns 1 on successfully attached PM domain, 0 when the device don't need a > - * PM domain or a negative error code in case of failures. Note that if a > - * power-domain exists for the device, but it cannot be found or turned on, > - * then return -EPROBE_DEFER to ensure that the device is not probed and to > - * re-try again later. > + * PM domain or when multiple power-domains exists for it, else a negative error > + * code. Note that if a power-domain exists for the device, but it cannot be > + * found or turned on, then return -EPROBE_DEFER to ensure that the device is > + * not probed and to re-try again later. > */ > int genpd_dev_pm_attach(struct device *dev) > { > @@ -2243,10 +2243,18 @@ int genpd_dev_pm_attach(struct device *dev) > if (!dev->of_node) > return 0; > > + /* > + * Devices with multiple PM domains must be attached separately, as we > + * can only attach one PM domain per device. > + */ > + if (of_count_phandle_with_args(dev->of_node, "power-domains", > + "#power-domain-cells") != 1) > + return 0; > + > ret = of_parse_phandle_with_args(dev->of_node, "power-domains", > "#power-domain-cells", 0, &pd_args); > if (ret < 0) > - return 0; > + return ret; > > mutex_lock(&gpd_list_lock); > pd = genpd_get_from_provider(&pd_args); > Acked-by: Jon Hunter Tested-by: Jon Hunter Cheers Jon -- nvpublic