From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98CF8C433F5 for ; Mon, 30 May 2022 11:27:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231548AbiE3L1G (ORCPT ); Mon, 30 May 2022 07:27:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233224AbiE3L1A (ORCPT ); Mon, 30 May 2022 07:27:00 -0400 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6CB213FD9A for ; Mon, 30 May 2022 04:26:53 -0700 (PDT) Received: by mail-lf1-x133.google.com with SMTP id u23so16306481lfc.1 for ; Mon, 30 May 2022 04:26:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz-org.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:from:subject:to:cc :references:content-language:in-reply-to:content-transfer-encoding; bh=4e9cAQNYvP51hKc6KpBonPtXgR81jEqGpiEVOIyf/5s=; b=xizF6KRy3bFdr7qqwILsD9GKyKXrT5rRjnCMU+4tebhEx+64CxYJbtIbvsChGeZp9p eSNkgCkAudTzd3EKloNzUi0JiC3932qtJlaXk1tfWhx3CZo0+1/dlrPo2A0+4lDBNj1/ oy6OpdKdMux4+Yco38Cdoh1Ak2+Q7U0JVjDpaDnR9IQhAyAgrDsDlmf9XZ7w9jnPg8hZ 6lVTYkwk7E555m7EJX5Ebmj9BJHMo+oyNavkwL/xerfAMHsVuJKLEuhAr+reY72Zpvms GKxs7z2KmJmMOOMUjpCHbYKh3Q965rKnTT3EtDdZNmVh1yEu4+GEDLRkHsOXns+JVJmo onaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:from :subject:to:cc:references:content-language:in-reply-to :content-transfer-encoding; bh=4e9cAQNYvP51hKc6KpBonPtXgR81jEqGpiEVOIyf/5s=; b=k6HJtawU8D0fczX1FBb1qzq4DKY59V+QvWHIV7zQItJJq+b5UrvmQjqot2edr4HGLY GRRYi8wOntjfrFkLJpEeALnJ9Z8+A/N5WERQFqF4db4Xp1n9KwI/eB5cMQpIrQRqXzc4 JY3Xal2X1gejtFd/kHtwkzfk8Ef3yhzOmD6J1ur4PPo/jr6t84dFLV5Shi+u+DK2LTuP FIgryyHifV4bCyHXOI5+fUSp3b9FwJBGIu7VdDjLExwkBLKSP8l1S1hQnqVLFz8HflEI 4OcjjSfuWDtwrLsCFaCYYZq32BwiBmBH2dUrlGlHjhJSu8be+D0JrnhOvFXtR3fpaMNy i+Ng== X-Gm-Message-State: AOAM533st5rx3xJ3Q1CmSiSfuIDpEM4n68KD9qo8njhQBXwH50Ajlcpn By/Q6DaQGFEkH+3XlwoTsBOuWQ== X-Google-Smtp-Source: ABdhPJwF1AwMaj291W7nGiUPQz5B+WwYAG2NqIo/7HzPTtCYWTM7nFaT7vdg6FgpWglp2bJz7VaG2Q== X-Received: by 2002:a05:6512:31d0:b0:477:ce21:fa6d with SMTP id j16-20020a05651231d000b00477ce21fa6dmr35830913lfe.219.1653910011534; Mon, 30 May 2022 04:26:51 -0700 (PDT) Received: from [192.168.1.65] ([46.188.121.129]) by smtp.gmail.com with ESMTPSA id be10-20020a056512250a00b00478cd831077sm1308038lfb.271.2022.05.30.04.26.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 May 2022 04:26:51 -0700 (PDT) Message-ID: <3b524f9c-c078-1118-9385-7e57cb5a0347@openvz.org> Date: Mon, 30 May 2022 14:26:50 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 From: Vasily Averin Subject: [PATCH mm v3 7/9] memcg: enable accounting for large allocations in mem_cgroup_css_alloc To: Andrew Morton Cc: kernel@openvz.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Shakeel Butt , Roman Gushchin , =?UTF-8?Q?Michal_Koutn=c3=bd?= , Vlastimil Babka , Michal Hocko , Muchun Song , cgroups@vger.kernel.org References: <06505918-3b8a-0ad5-5951-89ecb510138e@openvz.org> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Creation of each memory cgroup allocates few huge objects in mem_cgroup_css_alloc(). Its size exceeds the size of memory accounted in common part of cgroup creation: common part: ~11Kb + 318 bytes percpu memcg: ~17Kb + 4692 bytes percpu memory: ------ Allocs Alloc $1*$2 Sum Allocation number size -------------------------------------------- 1 + 8192 8192 8192 (mem_cgroup_css_alloc+0x4a) Reviewed-by: Roman Gushchin Reviewed-by: Michal Koutný Acked-by: Shakeel Butt Reviewed-by: Muchun Song --- mm/memcontrol.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index abec50f31fe6..376734af8935 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -5064,7 +5064,7 @@ static int alloc_mem_cgroup_per_node_info(struct mem_cgroup *memcg, int node) { struct mem_cgroup_per_node *pn; - pn = kzalloc_node(sizeof(*pn), GFP_KERNEL, node); + pn = kzalloc_node(sizeof(*pn), GFP_KERNEL_ACCOUNT, node); if (!pn) return 1; @@ -5116,7 +5116,7 @@ static struct mem_cgroup *mem_cgroup_alloc(void) int __maybe_unused i; long error = -ENOMEM; - memcg = kzalloc(struct_size(memcg, nodeinfo, nr_node_ids), GFP_KERNEL); + memcg = kzalloc(struct_size(memcg, nodeinfo, nr_node_ids), GFP_KERNEL_ACCOUNT); if (!memcg) return ERR_PTR(error); -- 2.36.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vasily Averin Subject: [PATCH mm v3 7/9] memcg: enable accounting for large allocations in mem_cgroup_css_alloc Date: Mon, 30 May 2022 14:26:50 +0300 Message-ID: <3b524f9c-c078-1118-9385-7e57cb5a0347@openvz.org> References: <06505918-3b8a-0ad5-5951-89ecb510138e@openvz.org> Mime-Version: 1.0 Content-Transfer-Encoding: base64 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz-org.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:from:subject:to:cc :references:content-language:in-reply-to:content-transfer-encoding; bh=4e9cAQNYvP51hKc6KpBonPtXgR81jEqGpiEVOIyf/5s=; b=xizF6KRy3bFdr7qqwILsD9GKyKXrT5rRjnCMU+4tebhEx+64CxYJbtIbvsChGeZp9p eSNkgCkAudTzd3EKloNzUi0JiC3932qtJlaXk1tfWhx3CZo0+1/dlrPo2A0+4lDBNj1/ oy6OpdKdMux4+Yco38Cdoh1Ak2+Q7U0JVjDpaDnR9IQhAyAgrDsDlmf9XZ7w9jnPg8hZ 6lVTYkwk7E555m7EJX5Ebmj9BJHMo+oyNavkwL/xerfAMHsVuJKLEuhAr+reY72Zpvms GKxs7z2KmJmMOOMUjpCHbYKh3Q965rKnTT3EtDdZNmVh1yEu4+GEDLRkHsOXns+JVJmo onaw== Content-Language: en-US In-Reply-To: List-ID: Content-Type: text/plain; charset="macroman" To: Andrew Morton Cc: kernel-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, Shakeel Butt , Roman Gushchin , =?UTF-8?Q?Michal_Koutn=c3=bd?= , Vlastimil Babka , Michal Hocko , Muchun Song , cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Q3JlYXRpb24gb2YgZWFjaCBtZW1vcnkgY2dyb3VwIGFsbG9jYXRlcyBmZXcgaHVnZSBvYmplY3Rz IGluCm1lbV9jZ3JvdXBfY3NzX2FsbG9jKCkuIEl0cyBzaXplIGV4Y2VlZHMgdGhlIHNpemUgb2Yg bWVtb3J5CmFjY291bnRlZCBpbiBjb21tb24gcGFydCBvZiBjZ3JvdXAgY3JlYXRpb246Cgpjb21t b24gcGFydDogCX4xMUtiCSsgIDMxOCBieXRlcyBwZXJjcHUKbWVtY2c6IAkJfjE3S2IJKyA0Njky IGJ5dGVzIHBlcmNwdQoKbWVtb3J5OgotLS0tLS0KQWxsb2NzICBBbGxvYyAgICQxKiQyICAgU3Vt ICAgICBBbGxvY2F0aW9uCm51bWJlciAgc2l6ZQotLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLQoxICAgKyAgIDgxOTIgICAgODE5MiAgICA4MTkyICAgIChtZW1fY2dy b3VwX2Nzc19hbGxvYysweDRhKSA8TkIKMTQgIH4gICAzNTIgICAgIDQ5MjggICAgMTMxMjAgICBL RVJORlMKMSAgICsgICAyMDQ4ICAgIDIwNDggICAgMTUxNjggICAobWVtX2Nncm91cF9jc3NfYWxs b2MrMHhkZCkgPE5CCjEgICAgICAgMTAyNCAgICAxMDI0ICAgIDE2MTkyICAgKGFsbG9jX3Nocmlu a2VyX2luZm8rMHg3OSkKMSAgICAgICA1ODQgICAgIDU4NCAgICAgMTY3NzYgICAocmFkaXhfdHJl ZV9ub2RlX2FsbG9jLmNvbnN0cHJvcC4wKzB4ODkpCjIgICAgICAgNjQgICAgICAxMjggICAgIDE2 OTA0ICAgKHBlcmNwdV9yZWZfaW5pdCsweDZhKQoxICAgICAgIDY0ICAgICAgNjQgICAgICAxNjk2 OCAgIChtZW1fY2dyb3VwX2Nzc19vbmxpbmUrMHgzMikKCjEgICA9ICAgMzY4NCAgICAzNjg0ICAg IDM2ODQgICAgY2FsbF9zaXRlPW1lbV9jZ3JvdXBfY3NzX2FsbG9jKzB4OWUKMSAgID0gICA5ODQg ICAgIDk4NCAgICAgNDY2OCAgICBjYWxsX3NpdGU9bWVtX2Nncm91cF9jc3NfYWxsb2MrMHhmZAoy ICAgICAgIDEyICAgICAgMjQgICAgICA0NjkyICAgIGNhbGxfc2l0ZT1wZXJjcHVfcmVmX2luaXQr MHgyMwoKICAgICAnPScgLS0gYWxyZWFkeSBhY2NvdW50ZWQsCiAgICAgJysnIC0tIHRvIGJlIGFj Y291bnRlZCwKICAgICAnficgLS0gcGFydGlhbGx5IGFjY291bnRlZAoKQWNjb3VudGluZyBmb3Ig dGhpcyBtZW1vcnkgaGVscHMgdG8gYXZvaWQgbWlzdXNlIGluc2lkZSBtZW1jZy1saW1pdGVkCmNv bnRpYW5lcnMuCgpTaWduZWQtb2ZmLWJ5OiBWYXNpbHkgQXZlcmluIDx2dnMtR0VGQVF6Wlg3cjhk bm0reVJPZkUwQUBwdWJsaWMuZ21hbmUub3JnPgpSZXZpZXdlZC1ieTogUm9tYW4gR3VzaGNoaW4g PHJvbWFuLmd1c2hjaGluLWZ4VVZYZnRJRkRueUcxekVPYlh0ZkFAcHVibGljLmdtYW5lLm9yZz4K UmV2aWV3ZWQtYnk6IE1pY2hhbCBLb3V0bsO9IDxta291dG55LUlCaTlSRy9iNjdrQHB1YmxpYy5n bWFuZS5vcmc+CkFja2VkLWJ5OiBTaGFrZWVsIEJ1dHQgPHNoYWtlZWxiLWhwSXFzRDRBS2xmUVQw ZFpSK0FsZkFAcHVibGljLmdtYW5lLm9yZz4KUmV2aWV3ZWQtYnk6IE11Y2h1biBTb25nIDxzb25n bXVjaHVuLUVDOFV4bDZOcHlkbDU3TUlkUkNGRGdAcHVibGljLmdtYW5lLm9yZz4KLS0tCiBtbS9t ZW1jb250cm9sLmMgfCA0ICsrLS0KIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDIg ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbW0vbWVtY29udHJvbC5jIGIvbW0vbWVtY29udHJv bC5jCmluZGV4IGFiZWM1MGYzMWZlNi4uMzc2NzM0YWY4OTM1IDEwMDY0NAotLS0gYS9tbS9tZW1j b250cm9sLmMKKysrIGIvbW0vbWVtY29udHJvbC5jCkBAIC01MDY0LDcgKzUwNjQsNyBAQCBzdGF0 aWMgaW50IGFsbG9jX21lbV9jZ3JvdXBfcGVyX25vZGVfaW5mbyhzdHJ1Y3QgbWVtX2Nncm91cCAq bWVtY2csIGludCBub2RlKQogewogCXN0cnVjdCBtZW1fY2dyb3VwX3Blcl9ub2RlICpwbjsKIAot CXBuID0ga3phbGxvY19ub2RlKHNpemVvZigqcG4pLCBHRlBfS0VSTkVMLCBub2RlKTsKKwlwbiA9 IGt6YWxsb2Nfbm9kZShzaXplb2YoKnBuKSwgR0ZQX0tFUk5FTF9BQ0NPVU5ULCBub2RlKTsKIAlp ZiAoIXBuKQogCQlyZXR1cm4gMTsKIApAQCAtNTExNiw3ICs1MTE2LDcgQEAgc3RhdGljIHN0cnVj dCBtZW1fY2dyb3VwICptZW1fY2dyb3VwX2FsbG9jKHZvaWQpCiAJaW50IF9fbWF5YmVfdW51c2Vk IGk7CiAJbG9uZyBlcnJvciA9IC1FTk9NRU07CiAKLQltZW1jZyA9IGt6YWxsb2Moc3RydWN0X3Np emUobWVtY2csIG5vZGVpbmZvLCBucl9ub2RlX2lkcyksIEdGUF9LRVJORUwpOworCW1lbWNnID0g a3phbGxvYyhzdHJ1Y3Rfc2l6ZShtZW1jZywgbm9kZWluZm8sIG5yX25vZGVfaWRzKSwgR0ZQX0tF Uk5FTF9BQ0NPVU5UKTsKIAlpZiAoIW1lbWNnKQogCQlyZXR1cm4gRVJSX1BUUihlcnJvcik7CiAK LS0gCjIuMzYuMQoK