From: Harry Wentland <harry.wentland@amd.com>
To: Anson Jacob <Anson.Jacob@amd.com>, igt-dev@lists.freedesktop.org
Cc: Petri Latvala <petri.latvala@intel.com>,
Victor Lu <victorchengchi.lu@amd.com>
Subject: Re: [igt-dev] [PATCH i-g-t V2] tests/kms_plane_multiple: Start continuous CRC capture after commit
Date: Mon, 28 Jun 2021 09:50:44 -0400 [thread overview]
Message-ID: <3b6b2164-7eb9-7f7c-76ee-50c8509ddd49@amd.com> (raw)
In-Reply-To: <20210628131435.1070725-1-Anson.Jacob@amd.com>
On 2021-06-28 9:14 a.m., Anson Jacob wrote:
> From: Victor Lu <victorchengchi.lu@amd.com>
>
> atomic-pipe-a-tiling-none fails on amdgpu(Raven) because it fails to read the
> CRC when there is no CRC generated (zeroed framebuffer). Move
> igt_pipe_crc_start to be called after the first nonzero FB commit.
>
> Signed-off-by: Victor Lu <victorchengchi.lu@amd.com>
> Acked-by: Anson Jacob <Anson.Jacob@amd.com>
> Cc: Petri Latvala <petri.latvala@intel.com>
> Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Mark Yacoub <markyacoub@chromium.org>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Harry
> ---
> tests/kms_plane_multiple.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/tests/kms_plane_multiple.c b/tests/kms_plane_multiple.c
> index 93c6ea7d269d..4424b864b2d6 100644
> --- a/tests/kms_plane_multiple.c
> +++ b/tests/kms_plane_multiple.c
> @@ -288,6 +288,7 @@ test_plane_position_with_output(data_t *data, enum pipe pipe,
> igt_plane_t *plane;
> int i;
> int err, c = 0;
> + int crc_enabled = 0;
> int iterations = opt.iterations < 1 ? 1 : opt.iterations;
> bool loop_forever;
> char info[256];
> @@ -327,14 +328,16 @@ test_plane_position_with_output(data_t *data, enum pipe pipe,
> igt_output_name(output), kmstest_pipe_name(pipe), c,
> info, opt.seed);
>
> - igt_pipe_crc_start(data->pipe_crc);
> -
> i = 0;
> while (i < iterations || loop_forever) {
> /* randomize planes and set up the holes */
> prepare_planes(data, pipe, &blue, tiling, c, output);
>
> igt_display_commit2(&data->display, COMMIT_ATOMIC);
> + if (!crc_enabled) {
> + igt_pipe_crc_start(data->pipe_crc);
> + crc_enabled = 1;
> + }
>
> igt_pipe_crc_get_current(data->display.drm_fd, data->pipe_crc, &crc);
>
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2021-06-28 13:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 13:14 [igt-dev] [PATCH i-g-t V2] tests/kms_plane_multiple: Start continuous CRC capture after commit Anson Jacob
2021-06-28 13:50 ` Harry Wentland [this message]
2021-06-28 15:46 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane_multiple: Start continuous CRC capture after commit (rev2) Patchwork
2021-06-28 19:20 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2021-07-06 12:45 ` [igt-dev] [PATCH i-g-t V2] tests/kms_plane_multiple: Start continuous CRC capture after commit Rodrigo Siqueira
2021-07-06 13:47 ` Juha-Pekka Heikkila
2021-07-06 16:21 ` Vudum, Lakshminarayana
2021-07-06 16:02 ` [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_plane_multiple: Start continuous CRC capture after commit (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b6b2164-7eb9-7f7c-76ee-50c8509ddd49@amd.com \
--to=harry.wentland@amd.com \
--cc=Anson.Jacob@amd.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=petri.latvala@intel.com \
--cc=victorchengchi.lu@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.