All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
To: Himadri Pandya <himadri18.07@gmail.com>,
	benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 1/2] arch: powerpc/kexec: Add missing of_node-put() in default_machine_kexec_prepare()
Date: Mon, 25 Feb 2019 15:20:10 -0800	[thread overview]
Message-ID: <3b7ddc53-dc33-54e5-0826-9147b27ab02b@linux.vnet.ibm.com> (raw)
In-Reply-To: <20190225090056.19055-1-himadri18.07@gmail.com>

On 02/25/2019 01:00 AM, Himadri Pandya wrote:
> Decrement the reference count on device_node "node" while breaking out
> of the loop. Issue identified by Coccinelle.
> 
> Signed-off-by: Himadri Pandya <himadri18.07@gmail.com>
> ---
> Changes in V2:
> 	- Change subject line
> ---
>  arch/powerpc/kernel/machine_kexec_64.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/powerpc/kernel/machine_kexec_64.c b/arch/powerpc/kernel/machine_kexec_64.c
> index a0f6f45005bd..46edde582984 100644
> --- a/arch/powerpc/kernel/machine_kexec_64.c
> +++ b/arch/powerpc/kernel/machine_kexec_64.c
> @@ -65,6 +65,7 @@ int default_machine_kexec_prepare(struct kimage *image)
>  			end = begin + image->segment[i].memsz;
> 
>  			if ((begin < high) && (end > low))
> +				of_node_put(node);
>  				return -ETXTBSY;

I think the kbuild robot already caught this, but you need to add { } block
around this if now. Previously it was a one line statement, but adding the
of_node_put() makes it multiple lines that now require { }.

-Tyrel

>  		}
>  	}
> 


  parent reply	other threads:[~2019-02-25 23:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190224080209.15969-1-himadri18.07@gmail.com>
2019-02-25  9:00 ` [PATCH v2 1/2] arch: powerpc/kexec: Add missing of_node-put() in default_machine_kexec_prepare() Himadri Pandya
2019-02-25  9:00   ` [PATCH v2 2/2] arch: powerpc/hlwd-pic: Add missing of_node-put() in hlwd_pic_probe() Himadri Pandya
2019-02-25 23:21     ` Tyrel Datwyler
2019-02-25 16:09   ` [PATCH v2 1/2] arch: powerpc/kexec: Add missing of_node-put() in default_machine_kexec_prepare() kbuild test robot
2019-02-25 23:20   ` Tyrel Datwyler [this message]
2019-02-27  9:51   ` [PATCH v3 " Himadri Pandya
2019-02-27  9:51     ` [PATCH v3 2/2] arch: powerpc/hlwd-pic: Add missing of_node-put() in hlwd_pic_probe() Himadri Pandya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3b7ddc53-dc33-54e5-0826-9147b27ab02b@linux.vnet.ibm.com \
    --to=tyreld@linux.vnet.ibm.com \
    --cc=benh@kernel.crashing.org \
    --cc=himadri18.07@gmail.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.