From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52444) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bYE2i-0000jS-EE for qemu-devel@nongnu.org; Fri, 12 Aug 2016 11:06:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bYE2h-0002ie-E8 for qemu-devel@nongnu.org; Fri, 12 Aug 2016 11:06:40 -0400 References: <1470679640-18366-1-git-send-email-clord@redhat.com> From: Max Reitz Message-ID: <3b82042b-baf7-f42d-ade5-f28abdeb8a6a@redhat.com> Date: Fri, 12 Aug 2016 14:39:21 +0200 MIME-Version: 1.0 In-Reply-To: <1470679640-18366-1-git-send-email-clord@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="iCMQeFtImAUhGOJFH16sMSpEDRIbnOVe1" Subject: Re: [Qemu-devel] [PATCH v7 0/4] Dynamic module loading for block drivers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Colin Lord , qemu-devel@nongnu.org Cc: kwolf@redhat.com, qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --iCMQeFtImAUhGOJFH16sMSpEDRIbnOVe1 From: Max Reitz To: Colin Lord , qemu-devel@nongnu.org Cc: kwolf@redhat.com, qemu-block@nongnu.org Message-ID: <3b82042b-baf7-f42d-ade5-f28abdeb8a6a@redhat.com> Subject: Re: [PATCH v7 0/4] Dynamic module loading for block drivers References: <1470679640-18366-1-git-send-email-clord@redhat.com> In-Reply-To: <1470679640-18366-1-git-send-email-clord@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 08.08.2016 20:07, Colin Lord wrote: > One more minor revision from v6, no big changes. >=20 > v7: > - Add ifdef around qemu_iscsi_opts in vl.c (first patch) >=20 > v6: > - Fix bug so that users can specify a modularized driver on the cli > without qemu exiting > - Remove extra lines from Makefile > - Add patch to modularize NFS >=20 > v5: > - No format drivers are modularized, therefore the probe functions are > all being left completely untouched. > - Remove dmg from block-obj-m since it is not a target of the > modularization effort. > - Modify module_block.py to only include the library name and protocol > name fields in the generated struct. The other fields are no longer > necessary for the drivers that are being modularized. >=20 > v4: > - Fix indentation of the generated header file module_block.h > - Drivers and probe functions are now all located in the block/ > directory, rather than being split between block/ and block/probe/. I= n > addition the header files for each probe/driver pair are in the block= / > directory, not the include/block/driver/ directory (which no longer > exists). > - Since the probe files are in block/ now, they follow the naming > pattern of format-probe.c > - Renamed crypto probe file to be crypto-probe.c, luks is no longer in > the filename > - Fixed formatting of parallels_probe() function header > - Enforced consistent naming convention for the probe functions. They > now follow the pattern bdrv_format_probe(). >=20 > Colin Lord (2): > blockdev: prepare iSCSI block driver for dynamic loading > blockdev: Modularize nfs block driver >=20 > Marc Mari (2): > blockdev: Add dynamic generation of module_block.h > blockdev: Add dynamic module loading for block drivers >=20 > Makefile | 10 ++-- > block.c | 62 ++++++++++++++++++++--- > block/Makefile.objs | 4 +- > block/iscsi.c | 36 -------------- > configure | 4 +- > include/qemu/module.h | 3 ++ > scripts/modules/module_block.py | 108 ++++++++++++++++++++++++++++++++= ++++++++ > util/module.c | 38 ++++---------- > vl.c | 40 +++++++++++++++ > 9 files changed, 228 insertions(+), 77 deletions(-) > create mode 100644 scripts/modules/module_block.py I'd be happy to apply the series as-is, but I'll still give you some time to decide whether you want to extend patch 3's commit message by what Fam has proposed. Max --iCMQeFtImAUhGOJFH16sMSpEDRIbnOVe1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEvBAEBCAAZBQJXrcN5EhxtcmVpdHpAcmVkaGF0LmNvbQAKCRA7sUIC6Disrdpj CACD4/VF1w1lElQQY6OrTrSrsDdJiCw0oeRrT16upVDlWQ341HS0Lp677UJPVstM EM9q1CoIHy1iYfPLRwqjtVNRc3go8TMaJD/mKQPO0tC7IHTA8LWOnXdeqzmaZ8Q4 k4Hzo/seuAKjGZVjW4eam84hGEPyHjTjdrT89sU3q4TV+pW9xyKFUPPEGG69Y2nm tHzwuq2f6msjaGPTHFeajEpKlCe2H3DIRisWszNDjAUA9JK9NHAcJtgYA1XboxH6 MKJxvHCz+i1rySeYH2wnQE7Ir4pAqSZ/shhYlUwaJoJ1nGO9bloUGxlLn0saUI2E i/SUT1jYcEhikS+BIbdgKoZv =6f5z -----END PGP SIGNATURE----- --iCMQeFtImAUhGOJFH16sMSpEDRIbnOVe1--