From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>, Jan Beulich <JBeulich@suse.com>
Subject: Re: [PATCH v2] xen: report PV capability in sysctl and use it in toolstack
Date: Fri, 9 Nov 2018 11:25:54 +0000 [thread overview]
Message-ID: <3b880d86-2671-3101-3b68-cd2569e30d04@citrix.com> (raw)
In-Reply-To: <20181109112346.6258-1-wei.liu2@citrix.com>
On 09/11/18 11:23, Wei Liu wrote:
> 0e2c886ef ("xen: decouple HVM and IOMMU capabilities") provided a
> truth table for what `xl info` would report. In order to make the
> table work xen will need to report its PV capability.
>
> Replace cap_directio with cap_pv in libxl IDL. It is safe to do so
> because cap_directio has never been released. Revert to use
> cap_hvm_directio to mark the availability of IOMMU, to save us from
> providing a compatibility layer.
>
> Don't bump sysctl version number because we've already done so.
>
> Also provide a new virt_caps "pv", change "directio" to "pv_directio".
> The truth table is now:
>
> pv hvm iommu flags in xl info
> 0 0 x n/a
> 0 1 0 hvm
> 0 1 1 hvm hvm_directio
> 1 0 0 pv
> 1 0 1 pv pv_directio
> 1 1 0 pv hvm
> 1 1 1 pv hvm hvm_directio pv_directio
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
LGTM. Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-11-09 11:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-09 11:23 [PATCH v2] xen: report PV capability in sysctl and use it in toolstack Wei Liu
2018-11-09 11:25 ` Andrew Cooper [this message]
2018-11-15 15:08 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b880d86-2671-3101-3b68-cd2569e30d04@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.