From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jamal Hadi Salim Subject: Re: [PATCH net-next 0/8] net: sched: cls: add extack support Date: Tue, 16 Jan 2018 18:27:50 -0500 Message-ID: <3b96f69a-c5e6-f741-0743-dd3f847a8775@mojatatu.com> References: <20180116172027.22128-1-aring@mojatatu.com> <20180116134654.10d4fdef@cakuba.netronome.com> <20180116144158.5e2935b8@cakuba.netronome.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Alexander Aring , xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net, netdev@vger.kernel.org, kernel@mojatatu.com, David Ahern To: Jakub Kicinski Return-path: Received: from mail-it0-f67.google.com ([209.85.214.67]:38686 "EHLO mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751389AbeAPX1x (ORCPT ); Tue, 16 Jan 2018 18:27:53 -0500 Received: by mail-it0-f67.google.com with SMTP id w14so6266666itc.3 for ; Tue, 16 Jan 2018 15:27:52 -0800 (PST) In-Reply-To: <20180116144158.5e2935b8@cakuba.netronome.com> Content-Language: en-GB Sender: netdev-owner@vger.kernel.org List-ID: On 18-01-16 05:41 PM, Jakub Kicinski wrote: > On Tue, 16 Jan 2018 17:12:57 -0500, Jamal Hadi Salim wrote: >> On 18-01-16 04:46 PM, Jakub Kicinski wrote: >>> On Tue, 16 Jan 2018 12:20:19 -0500, Alexander Aring wrote: >> >> [..] >> >> I would say precedence should be Jiri's patches, Alex's patches >> and then yours: >> Alex's patches fix the core (cls_api.c) area with proper extack >> for the core and then he has one patch to cover a specific >> use case of the u32 classifier extack. Yours is only concerned >> with one use case - bpf which depend on the core (that is in Alex's >> patches) > > Our patches are concerned with propagating the extack to drivers, > and nfp (and netdevsim) make use of it. > > I'm miffed by the fact that you jumped out with this conflicting series > *after* we posted ours, and we got shot down on white space. I totally empathize with the general frustration. The general rule is we fix the core first then add users (classifiers in this case). Note: Alex has a _lot_ of patches that he has been trying to send for the last little while and this one is certainly not a new set (I actually had reviewed this set). There are others. And the rule of "fix core first then add users" has been imposed on him as well. cheers, jamal