All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joerg Vehlow <lkml@jv-coder.de>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 1/2] shell: Add checkpoints api for new lib
Date: Mon, 23 Aug 2021 06:36:05 +0200	[thread overview]
Message-ID: <3b97b712-f9d3-c5d1-66ce-0f98f5f1cb4f@jv-coder.de> (raw)
In-Reply-To: <YR+LAmVDEUcZ51Wt@pevik>

Hi Petr,

On 8/20/2021 12:59 PM, Petr Vorel wrote:
> Hi Joerg,
>
> LGTM, good idea.
>
> But I'd rename $LTP_IPC_PATH to $TST_IPC_PATH to follow conventions to new API
> (There are also some LTP_* definitions in the legacy C API which were renamed as
> TST_* in the new API).
This would also require changing the C API, because the environment 
variable is used for communicating with it.
I we want this, I guess it could be done in another changeset.
>
>
>> +	if [ -n "$TST_NEEDS_CHECKPOINTS" -a -f "${LTP_IPC_PATH}" ]; then
> nit (remove unnecessary {}):
Could be changed while merging.
>      if [ -n "$TST_NEEDS_CHECKPOINTS" -a -f "$TST_IPC_PATH" ]; then
>> +		rm ${LTP_IPC_PATH}
> and here:
> 		rm $TST_IPC_PATH
>


Joerg

  reply	other threads:[~2021-08-23  4:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-12  4:38 [LTP] [PATCH v2 1/2] shell: Add checkpoints api for new lib Joerg Vehlow
2021-08-12  4:38 ` [LTP] [PATCH v2 2/2] pec: Improve reliability Joerg Vehlow
2021-08-20 11:01   ` Petr Vorel
2021-08-23  4:31     ` Joerg Vehlow
2021-08-24  6:29       ` Petr Vorel
2021-08-24  7:27         ` Joerg Vehlow
2021-08-24 10:47           ` Petr Vorel
2021-08-20 10:59 ` [LTP] [PATCH v2 1/2] shell: Add checkpoints api for new lib Petr Vorel
2021-08-23  4:36   ` Joerg Vehlow [this message]
2021-08-24  5:47     ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3b97b712-f9d3-c5d1-66ce-0f98f5f1cb4f@jv-coder.de \
    --to=lkml@jv-coder.de \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.