From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH 04/10] s390/mm: force swiotlb for protected virtualization References: <20190426183245.37939-1-pasic@linux.ibm.com> <20190426183245.37939-5-pasic@linux.ibm.com> <20190426192711.GA31463@infradead.org> <20190429155951.3175fef5.pasic@linux.ibm.com> From: Christian Borntraeger Date: Mon, 29 Apr 2019 16:05:46 +0200 MIME-Version: 1.0 In-Reply-To: <20190429155951.3175fef5.pasic@linux.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Message-Id: <3b9956a5-d8da-65fa-a2f7-4f54087d91d6@de.ibm.com> Sender: kvm-owner@vger.kernel.org List-Archive: List-Post: To: Halil Pasic , Christoph Hellwig Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org, Cornelia Huck , Martin Schwidefsky , Sebastian Ott , virtualization@lists.linux-foundation.org, "Michael S. Tsirkin" , Thomas Huth , Viktor Mihajlovski , Vasily Gorbik , Janosch Frank , Claudio Imbrenda , Farhan Ali , Eric Farman List-ID: On 29.04.19 15:59, Halil Pasic wrote: > On Fri, 26 Apr 2019 12:27:11 -0700 > Christoph Hellwig wrote: > >> On Fri, Apr 26, 2019 at 08:32:39PM +0200, Halil Pasic wrote: >>> +EXPORT_SYMBOL_GPL(set_memory_encrypted); >> >>> +EXPORT_SYMBOL_GPL(set_memory_decrypted); >> >>> +EXPORT_SYMBOL_GPL(sev_active); >> >> Why do you export these? I know x86 exports those as well, but >> it shoudn't be needed there either. >> > > I export these to be in line with the x86 implementation (which > is the original and seems to be the only one at the moment). I assumed > that 'exported or not' is kind of a part of the interface definition. > Honestly, I did not give it too much thought. > > For x86 set_memory(en|de)crypted got exported by 95cf9264d5f3 "x86, drm, > fbdev: Do not specify encrypted memory for video mappings" (Tom > Lendacky, 2017-07-17). With CONFIG_FB_VGA16=m seems to be necessary for x84. > > If the consensus is don't export: I won't. I'm fine one way or the other. > @Christian, what is your take on this? If we do not need it today for anything (e.g. virtio-gpu) then we can get rid of the exports (and introduce them when necessary). > > Thank you very much! > > Regards, > Halil > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Borntraeger Subject: Re: [PATCH 04/10] s390/mm: force swiotlb for protected virtualization Date: Mon, 29 Apr 2019 16:05:46 +0200 Message-ID: <3b9956a5-d8da-65fa-a2f7-4f54087d91d6@de.ibm.com> References: <20190426183245.37939-1-pasic@linux.ibm.com> <20190426183245.37939-5-pasic@linux.ibm.com> <20190426192711.GA31463@infradead.org> <20190429155951.3175fef5.pasic@linux.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190429155951.3175fef5.pasic@linux.ibm.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Halil Pasic , Christoph Hellwig Cc: Vasily Gorbik , linux-s390@vger.kernel.org, Thomas Huth , Claudio Imbrenda , kvm@vger.kernel.org, Sebastian Ott , "Michael S. Tsirkin" , Cornelia Huck , Eric Farman , virtualization@lists.linux-foundation.org, Martin Schwidefsky , Farhan Ali , Viktor Mihajlovski , Janosch Frank List-Id: virtualization@lists.linuxfoundation.org On 29.04.19 15:59, Halil Pasic wrote: > On Fri, 26 Apr 2019 12:27:11 -0700 > Christoph Hellwig wrote: > >> On Fri, Apr 26, 2019 at 08:32:39PM +0200, Halil Pasic wrote: >>> +EXPORT_SYMBOL_GPL(set_memory_encrypted); >> >>> +EXPORT_SYMBOL_GPL(set_memory_decrypted); >> >>> +EXPORT_SYMBOL_GPL(sev_active); >> >> Why do you export these? I know x86 exports those as well, but >> it shoudn't be needed there either. >> > > I export these to be in line with the x86 implementation (which > is the original and seems to be the only one at the moment). I assumed > that 'exported or not' is kind of a part of the interface definition. > Honestly, I did not give it too much thought. > > For x86 set_memory(en|de)crypted got exported by 95cf9264d5f3 "x86, drm, > fbdev: Do not specify encrypted memory for video mappings" (Tom > Lendacky, 2017-07-17). With CONFIG_FB_VGA16=m seems to be necessary for x84. > > If the consensus is don't export: I won't. I'm fine one way or the other. > @Christian, what is your take on this? If we do not need it today for anything (e.g. virtio-gpu) then we can get rid of the exports (and introduce them when necessary). > > Thank you very much! > > Regards, > Halil > >