All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] scsi: snic: Fix an error message
@ 2021-05-06 18:38 Christophe JAILLET
  2021-05-15  2:41 ` Martin K. Petersen
  0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2021-05-06 18:38 UTC (permalink / raw)
  To: kartilak, sebaddel, jejb, martin.petersen, JBottomley, hare, nmusini
  Cc: linux-scsi, linux-kernel, kernel-janitors, Christophe JAILLET

'ret' is known to be 0 here.
No error code is available, so just remove it from the error message.

While at it, change the word "Queuing" into "Init" which looks more
appropriate.

Fixes: c8806b6c9e82 ("snic: driver for Cisco SCSI HBA")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/scsi/snic/snic_ctl.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/scsi/snic/snic_ctl.c b/drivers/scsi/snic/snic_ctl.c
index 4cd86115cfb2..703f229862fc 100644
--- a/drivers/scsi/snic/snic_ctl.c
+++ b/drivers/scsi/snic/snic_ctl.c
@@ -114,10 +114,7 @@ snic_queue_exch_ver_req(struct snic *snic)
 
 	rqi = snic_req_init(snic, 0);
 	if (!rqi) {
-		SNIC_HOST_ERR(snic->shost,
-			      "Queuing Exch Ver Req failed, err = %d\n",
-			      ret);
-
+		SNIC_HOST_ERR(snic->shost, "Init Exch Ver Req failed\n");
 		ret = -ENOMEM;
 		goto error;
 	}
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] scsi: snic: Fix an error message
  2021-05-06 18:38 [PATCH] scsi: snic: Fix an error message Christophe JAILLET
@ 2021-05-15  2:41 ` Martin K. Petersen
  0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2021-05-15  2:41 UTC (permalink / raw)
  To: Christophe JAILLET
  Cc: kartilak, sebaddel, jejb, martin.petersen, JBottomley, hare,
	nmusini, linux-scsi, linux-kernel, kernel-janitors


Christophe,

> 'ret' is known to be 0 here.
> No error code is available, so just remove it from the error message.

Applied to 5.14/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-05-15  2:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-06 18:38 [PATCH] scsi: snic: Fix an error message Christophe JAILLET
2021-05-15  2:41 ` Martin K. Petersen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.