From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D742DC433F5 for ; Mon, 7 Mar 2022 23:06:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3531F8D0002; Mon, 7 Mar 2022 18:06:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3026D8D0001; Mon, 7 Mar 2022 18:06:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 155318D0002; Mon, 7 Mar 2022 18:06:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0121.hostedemail.com [216.40.44.121]) by kanga.kvack.org (Postfix) with ESMTP id 04E3D8D0001 for ; Mon, 7 Mar 2022 18:06:31 -0500 (EST) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id A60F01828D83D for ; Mon, 7 Mar 2022 23:06:30 +0000 (UTC) X-FDA: 79219126140.31.506BE41 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf07.hostedemail.com (Postfix) with ESMTP id EF62440008 for ; Mon, 7 Mar 2022 23:06:29 +0000 (UTC) Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 227KtJYk028214; Mon, 7 Mar 2022 23:06:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : from : to : cc : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=s6YK6Oj02UzE6tmoSk2oSHmfHGKozYGsi8zX7cb8uug=; b=lTDxM7u3yGejI8RlQOdP31UPQQpWucanRNSrtZV1DzyGK3PzU4tC+T3Wv6txMW3ExP8P GhYK+YViyEzMeKaiA44GYsmhyoJRVJ7db3UQA81Ngtl69Fask1b/EpEYq4QTo083VA96 TyIMLoG7leIguJ2QQc8CNLfe+id7tNKZ5BG75ShKWLpEEc7kdE2qSHTvfUAvENgGZlOu LmnaK6yEeRVJzlWktOHsWVlNgMP5wjU9gt9hZ6a3uProXEFiDjcZWI8SiYD4CRpMmb6E Bc90GOwLhKVBOxCVy6Mg/VNiEFzGUDPP3C2bcO9JJmesKWAatI/CLNN0ZjDZwliEpcd8 nw== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by mx0b-00069f02.pphosted.com with ESMTP id 3ekxn2dfkj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 07 Mar 2022 23:06:13 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 227N0khX160524; Mon, 7 Mar 2022 23:06:12 GMT Received: from nam04-bn8-obe.outbound.protection.outlook.com (mail-bn8nam08lp2048.outbound.protection.outlook.com [104.47.74.48]) by userp3020.oracle.com with ESMTP id 3em1ajjgc6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 07 Mar 2022 23:06:12 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nZakQm21JxwPXbK4eVkV78UMTmgoUrbjBn7rywzv0LTu4dmemwr5DdpE1f14sCCFUdM232lVkN0Gmb0dhl6kG9fxxiBD6BpczS3ggRKpkWt3M4ewJZBZAU1ezvgncl+D/4+Ty4ChdpdBcl+770ho5Fx0/k1Nbl4WqrV3VbTbGzBDs+LsYD5fvj6qaiAGam1UmwOcicxvn80n3LHa+I5W+hxy/qi+DsSY4Ub5oeDUDVoIA6rQv+o6+6J7MNZxRoTkCClxI8UUJDU4oraMzLcarZSk0DeXmyCMZjJMmpuVp4tMU8hVXnrcE2xb5yscqhBYDWeqhD1lOq1gkAymhz5GlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s6YK6Oj02UzE6tmoSk2oSHmfHGKozYGsi8zX7cb8uug=; b=CmWmhVNt4ZOY6oelwEqLXs0zqOZNY+VzlKkytenRHqLyQIfMldf4uRd03msvFvGb4wBSdsAwiosKUpMih+cB9Glw0m5Apz7YuNz0HBkhGmbWMHpDorhRhfqWPTGPEfzQXML7P+1m5gnNXWogmA+NN1Uf8DJKQ+/ukjZ4+ieK1G8vgr/aqUnsq0bbUR7EmlK1supGXixYeZn1KKQ7gfZDDGQjIYmB5HUk/BJRskuHD2W/jNM/c0kvRiCmAad3+T0AVh/8NH6MbimS4cwvCkMX/znaF7hFGlm178Vi5oMlhEwfOoVg6YB1jqeX/pXdcnJO0NF/wy6x/trEqRgcV+FpEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s6YK6Oj02UzE6tmoSk2oSHmfHGKozYGsi8zX7cb8uug=; b=hu7sV+w7+U7mG+YeTLWkBbbdqA2KRc5kYn6xosj+m1uFffmie9gbWjqpxEQatF/2ZRMT80wpAKJB/sP98DiHLSUVSkM6ulFNuPrclncbdLzVLThJkZj/MB9a1fcXP8d4HBT5c229BJi358AkC3TtJ1CEMRf0PCmjucq+pnLliTg= Received: from BY5PR10MB4196.namprd10.prod.outlook.com (2603:10b6:a03:20d::23) by DS7PR10MB5181.namprd10.prod.outlook.com (2603:10b6:5:3a1::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14; Mon, 7 Mar 2022 23:06:10 +0000 Received: from BY5PR10MB4196.namprd10.prod.outlook.com ([fe80::51f1:9cb7:a497:f0f7]) by BY5PR10MB4196.namprd10.prod.outlook.com ([fe80::51f1:9cb7:a497:f0f7%5]) with mapi id 15.20.5038.027; Mon, 7 Mar 2022 23:06:10 +0000 Message-ID: <3ba18a1d-d5d8-558f-9576-8119c210e98a@oracle.com> Date: Mon, 7 Mar 2022 15:06:07 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: VM_BUG_ON(!tlb->end) on munmap() with CONT hugetlb pages Content-Language: en-US From: Mike Kravetz To: David Hildenbrand , "linux-mm@kvack.org" Cc: anshuman.khandual@arm.com, Will Deacon , "Aneesh Kumar K . V" , 'Catalin Marinas' , Peter Zijlstra References: <811c5c8e-b3a2-85d2-049c-717f17c3a03a@redhat.com> <993f1258-6550-e5d7-1e6f-72e2a24b60f0@oracle.com> In-Reply-To: <993f1258-6550-e5d7-1e6f-72e2a24b60f0@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MWHPR17CA0072.namprd17.prod.outlook.com (2603:10b6:300:93::34) To BY5PR10MB4196.namprd10.prod.outlook.com (2603:10b6:a03:20d::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9a057d1f-dec6-4eac-fa19-08da008f116b X-MS-TrafficTypeDiagnostic: DS7PR10MB5181:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2UywLbp5zgGjn2+1QGl/1pGoTo2uyPEVvxF+1iuQx8p4McsK/vjjGCCMdfwWenmWEylCGT3h7ntDSDY7NXFxZlpNYMuhgKLyTaqtOLHpZLkAeQTfY2J7+3wFXpVibASgFLL40CbxdLYedbXstkPYEKvY1cJDLDgSMhSBCbYXvdmEEUZdiwIanoeVeOvnVrg+3i1zstseTvzPB9yyaauWK35VNmNOoolEgtVcDzc7xhOxrDzu92nduqQavU5U3ygbG+hkNFTZlIlbB+X81tvf0d+bao2peDl7CrWMV4KqCQ9agN/6LFAGLZiVFUafux5VswRF6llMCSlSQMZMqYmPPuudydYtmjbxtq8Xj4No5qvaZwx4AsemlQgcMmRMcF/r/097N31Ecwhe7BkH82ZK45sWs/6svD3p06aXsfAtl9cvqHgPh4ncWvM6nmAgsbNa1UUvsSQA5kZWo7XJYW3xm1EQCnh//ZIV/UbVOKD7ZzdpdvDaAmRocw/I4RK/CNiClduLzVhQ7JmtV2Nz9VCydao36mWNqMhxBSFZXK83LcdBLzK5B55nPJRYshdOAW2HYV9pqkfeg+oS9yXR/fP2gZ6G0FxdNNf62dsA59y//hXdkRmJDxawb1sjOoG90HJ0eoYlhm0AXxgI/KRH6wO3FiRoF4e5VrjorpEyvnmeMFngKJb1VFRBJazYxA26txEHkVQ4+HjUDcSnIMcR5Tqu3DQ0MGRpbiPy8+49LMnthAT53yVoDZhdBRj6FpMdbdZntg+1udvuFHULTNADCJAmdw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR10MB4196.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8676002)(66946007)(66476007)(38350700002)(38100700002)(2906002)(53546011)(66556008)(4326008)(44832011)(54906003)(110136005)(8936002)(5660300002)(6486002)(45080400002)(86362001)(316002)(31696002)(508600001)(52116002)(6506007)(186003)(26005)(36756003)(83380400001)(6512007)(31686004)(6666004)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WGtiNHBPaHRYZUJNMHJnbXdIcVZpdGU1YWY3Y1ZEOFMxb0ZKR01kSkdjaVVq?= =?utf-8?B?L3RLbWlKSi8raExHaGkrbS81Z2RIcmV1RzA5MUlVL1hZeUxzdTU3LzJ4Q3Na?= =?utf-8?B?MzlKNzhBcWdzNDE0YlV6SnE5WURsNmhKMENOZFM3aWdnWXJDMi9rZ1cxK2pu?= =?utf-8?B?aVduVWloUW5GSklEZEVxQmIyNnF3TG0vbnFHMmg2MGhhQThmeGdNVkhpVm8w?= =?utf-8?B?bDhpSTJtOUlKZTdWN3N4K1ZIbjN0Y09NUCtJcUVuTVZOUzVqQkVBakJZaGtr?= =?utf-8?B?TE9iblF5L3JISmUxYlhLYTlpb2pUUnBXZTdBMC85eEkvemJyTVFZbmhhTU9O?= =?utf-8?B?dHhlNElzb2VRMHhUUXhsMkpNajZNZGxCVmdEY2Y2SU10Q3pLYmxrZjFpNkRL?= =?utf-8?B?VFdPekF5ZDcwRlNXeFdXK3A4ZmJPci9yYVQ2VEM1cnpSS00zSUozM1JhZjVJ?= =?utf-8?B?QmZtRHNsU2gvZWYzR3VYTFpxbmhMbyt3R01vWEdqaUhSRzRuTzJ5TlAxNXZw?= =?utf-8?B?c0NvdXRsL1BLMDJvRDVvL015dnQxMmFpSWFXUkN5QjRtK09GMnFub0RLaGlG?= =?utf-8?B?c0Y5RXhkYXJkR01mK3NTZ0RWQlVJSncwSFpQdm1jbEYwZjBoZGpMaDNvNXZS?= =?utf-8?B?YW9oZEp1Vk9hRytMQ3oyaTBBZEpobXBDV1NNam1TWldNYnh4a1doY25PWlgx?= =?utf-8?B?NS9WZWY4UmVNcTRaaHRWTXF0d3VqNHdadVR1dTNRQTZra3J6TWhnZVg2OTRt?= =?utf-8?B?dnZNTFEvSUwvN2JtanE0SDRKU1ZOTitmcXBPNmNpL1hSemlWZWRPREN5Y2c5?= =?utf-8?B?SUowdFRxRkZtYnZxdnZGL1V4Sit0UCtsRGQ5ZHlBNmhHZ2s4RDNUTjI0NENF?= =?utf-8?B?bVNlUm1sOWxkV1l4Yk1RMzlTVkhHdkdkczMzbXRVWXFtalhHTWpUOWdNWnN0?= =?utf-8?B?dmY1Y1piVUg0dWxxNk96WTBlOEZkcURMWXE0bUY2Z2JRU2podHlJZmNHM2FZ?= =?utf-8?B?bTdiZkVqVmZqMTJpeGdpTm9IQ3NBb3Y1eWlBMllxeFIyQkVoOSsvWXppcXRv?= =?utf-8?B?cHBVcTFGK0ZMZW9CTlR1MmJaZXpzYUFraUlzbkJoY2o1R0hpZDZ6QzRCTGRU?= =?utf-8?B?d1NZWGpXSXJZa2s4azk5b3ZJMFpJMzRPTW1SVXMrdk5JbmN4RFhKRUxkZ042?= =?utf-8?B?SnFvMFhLOCtadzZXM1BTbUlVM1VjZEprVThOZTZvc3dkQk1MUDY4c21Dd2NC?= =?utf-8?B?Skk0UDR0SVdnM2Z1MjZCeVlLZXluTzJqbWd3NXBxcnlSQlIrbzZFZ3NWT3F4?= =?utf-8?B?YVBTcEFheXVZTjRuTklqZTVKN3g2QXU0Um0zL3A4WjFyT1g3YXduQ2JoTVB5?= =?utf-8?B?S1lHZ0loRDNrT3JkcytMZWVMZXlJUzFFdm1obmt1MCtOMGsweHNrZ2VWYmxO?= =?utf-8?B?M0lJbkRxMzdFRkl5Z3djYUVsRlNCdVErT3BuTmg2US9sbGM2dFdXa2RvTmxl?= =?utf-8?B?MC9aZ2Z5N1pJc0FHOVhUSXA0bld6MVJEQTJndXRNSnZQeWFzYzB0TWx4QkQ5?= =?utf-8?B?Sm12cWp6ekRUNzZOWEF5Ri9MNjZ3ZnY1VURjaDFjbUUxTFpDR2JRbXlFL3dN?= =?utf-8?B?dEFEc0wreDM3eW9mbUpsc0xGdCtyTEYvWHR1K1hTcmpBeUlVN1k0Y2g2bGdH?= =?utf-8?B?S0dLNUNtUUI5RW9BdVZFLzNWUVZHWGxwL1pNVXErTWVmaU5CLzFyM0pTb3dr?= =?utf-8?B?aFNiaEpQY3RWWDNJcnlJQzA2OEFGUmZjTmd3b1hiNVk5ZXpNS1JENWt4Z0FE?= =?utf-8?B?bUx4VTZzRFhLazYzSSsvWmNza3IxYTZWOVJzNXlLNWNCeDVNTDhjaTRhbjg4?= =?utf-8?B?aFNjZFpEV242RUg3N3lWVlRaWnZMRE1FNXR6Qi9QZll0TnZWK3F4eHZyRkhq?= =?utf-8?B?dTRCWWNsYU5ubVFhTXF3WEFFbkNWMFhOSlhzQUttYkUwQWk4VW9BaUhsQmZ6?= =?utf-8?B?cDhUV1gwdmgzOTRtRkk3RS9MN0ErWGE0SzR1OC92V3VaSVNUTCtkbVVBNXp4?= =?utf-8?B?bnA3c3JxQnFhUkVpTGlzRmtocGwrdTNXOEFQbW1POHRsVCtNVmduRytxSWJS?= =?utf-8?B?cFE3c2xUaERpRWd2YkFYQ0xqNDBGSWI1MDczMHFJY1oyVVN0amVkVFpyM0ZT?= =?utf-8?Q?0ftylSIoaojDjo5ByZQEk3I=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9a057d1f-dec6-4eac-fa19-08da008f116b X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2022 23:06:10.0208 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Q+284mhbBpI+jZHX8v8IS9wLc8XV4nMDPwzamGjZx3hgV9sQev7SF6kHmUyOds7XRSU8a+y1gPAWZtRgYpRr9g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5181 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10279 signatures=690470 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 phishscore=0 bulkscore=0 malwarescore=0 spamscore=0 adultscore=0 mlxlogscore=426 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2203070118 X-Proofpoint-ORIG-GUID: 2iTEEPGzSRO6KcZgE_vfadJpnYs5fQNO X-Proofpoint-GUID: 2iTEEPGzSRO6KcZgE_vfadJpnYs5fQNO X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: EF62440008 X-Stat-Signature: cjjuob789ozma8rtchm43rqyq7k8qzuq Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2021-07-09 header.b=lTDxM7u3; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=hu7sV+w7; dmarc=pass (policy=none) header.from=oracle.com; spf=none (imf07.hostedemail.com: domain of mike.kravetz@oracle.com has no SPF policy when checking 205.220.177.32) smtp.mailfrom=mike.kravetz@oracle.com X-HE-Tag: 1646694389-779031 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/28/22 16:26, Mike Kravetz wrote: > On 2/28/22 07:39, David Hildenbrand wrote: >> Hi, >> >> playing with anonymous CONT hugetlb pages on aarch64, I stumbled over the following VM_BUG_ON: >> >> [ 124.770288] ------------[ cut here ]------------ >> [ 124.774899] kernel BUG at mm/mmu_gather.c:70! >> [ 124.779244] Internal error: Oops - BUG: 0 [#1] SMP >> [ 124.784022] Modules linked in: mlx4_ib ib_uverbs ib_core mlx4_en rfkill vfat fat acpi_ipmi joydev ipmi_ssif igb mlx4_core ipmi_devintf ipmi_msghandler cppc_cpufreq fuse zram ip_tables xfs uas usb_storage dwc3 ulpi ast udc_core i2c_algo_bit drm_vram_helper drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops cec drm_ttm_helper ttm crct10dif_ce drm ghash_ce sbsa_gwdt i2c_xgene_slimpro xgene_hwmon ahci_platform gpio_dwapb xhci_plat_hcd >> [ 124.823045] CPU: 16 PID: 1160 Comm: test Not tainted 5.16.11-200.fc35.aarch64 #1 >> [ 124.830428] Hardware name: Lenovo HR350A 7X35CTO1WW /HR350A , BIOS hve104r-1.15 02/26/2021 >> [ 124.840240] pstate: 40400005 (nZcv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) >> [ 124.847189] pc : __tlb_remove_page_size+0x88/0xe4 >> [ 124.851885] lr : __unmap_hugepage_range+0x260/0x504 >> [ 124.856751] sp : ffff80000f6f3ae0 >> [ 124.860053] x29: ffff80000f6f3ae0 x28: ffff00080b639d24 x27: ffff000802504080 >> [ 124.867176] x26: fffffc00210f8000 x25: 0000000000000000 x24: ffff80000a9e8750 >> [ 124.874299] x23: 0000ffff8da20000 x22: ffff000804f0c190 x21: 0000000000010000 >> [ 124.881423] x20: ffff80000f6f3cb0 x19: ffff80000f6f3cb0 x18: 0000000000000000 >> [ 124.888545] x17: 0000000000000000 x16: 0000000000000000 x15: 0000000000000000 >> [ 124.895668] x14: 0000000000000000 x13: 0008000000000000 x12: 0008000000000080 >> [ 124.902791] x11: 0008000000000000 x10: 00f80008c3e00f43 x9 : ffff800008404e60 >> [ 124.909914] x8 : 0846000000000000 x7 : 0000000000000000 x6 : ffff80000a8a4000 >> [ 124.917038] x5 : 0000000000000040 x4 : 0000000000000000 x3 : 0000000000001000 >> [ 124.924161] x2 : 0000000000010000 x1 : fffffc00210f8000 x0 : 0000000000000000 >> [ 124.931284] Call trace: >> [ 124.933718] __tlb_remove_page_size+0x88/0xe4 >> [ 124.938062] __unmap_hugepage_range+0x260/0x504 >> [ 124.942580] __unmap_hugepage_range_final+0x24/0x40 >> [ 124.947445] unmap_single_vma+0x100/0x11c >> [ 124.951443] unmap_vmas+0x7c/0xf4 >> [ 124.954746] unmap_region+0xa4/0xf0 >> [ 124.958222] __do_munmap+0x1b8/0x50c >> [ 124.961785] __vm_munmap+0x74/0x120 >> [ 124.965261] __arm64_sys_munmap+0x40/0x54 >> [ 124.969257] invoke_syscall+0x50/0x120 >> [ 124.972995] el0_svc_common.constprop.0+0x4c/0x100 >> [ 124.977774] do_el0_svc+0x34/0xa0 >> [ 124.981077] el0_svc+0x30/0xd0 >> [ 124.984120] el0t_64_sync_handler+0xa4/0x130 >> [ 124.988377] el0t_64_sync+0x1a4/0x1a8 >> [ 124.992028] Code: b4000140 f9001660 29410402 17fffff4 (d4210000) >> [ 124.998109] ---[ end trace a74a76b89c9f2d88 ]--- >> [ 125.002900] ------------[ cut here ]------------ >> >> >> I'm running with 64k hugetlb on 4k aarch64. Reproducer: >> >> #define _GNU_SOURCE >> #include >> #include >> #include >> #include >> >> void main(void) >> { >> const size_t size = 64*1024; >> unsigned long cur; >> char *area; >> int fd; >> >> fd = memfd_create("test", MFD_HUGETLB | MFD_HUGE_64KB); >> ftruncate(fd, size); >> area = mmap(NULL, size, PROT_READ | PROT_WRITE, MAP_PRIVATE, fd, 0); >> >> memset(area, 0, size); >> >> munmap(area, size); >> } >> >> >> >> I assume __unmap_hugepage_range() does a >> >> a) tlb_remove_huge_tlb_entry() >> >> -> for sz != PMD_SIZE and sz != PUD_SIZE, this calls __tlb_remove_tlb_entry() >> >> -> __tlb_remove_tlb_entry() is a NOP on aarch64. __tlb_adjust_range() isn't called. >> >> b) tlb_remove_page_size() >> >> -> __tlb_remove_page_size() runs into VM_BUG_ON(!tlb->end); >> >> >> Not sure if this is just "ok" and we don't have to adjust the range or if there is >> some tlb range adjustment missing. >> > > To me, it looks like we are missing range adjustment in the case where > hugetlb page size != PMD_SIZE and != PUD_SIZE. Not sure how those ranges > are being flushed because as you note tlb_remove_huge_tlb_entry is pretty > much a NOP in this case on aarch64. > > Cc'ing Will and Peter as they most recently changed this code. Commit > 2631ed00b049 "tlb: mmu_gather: add tlb_flush_*_range APIs" removed an > unconditional call to __tlb_adjust_range() in tlb_remove_huge_tlb_entry. > That might have taken care of range adjustments in earlier versions of > the code. Not exactly sure what is needed now. I verified that commit 2631ed00b049 caused the VM_BUG when it removed the unconditional call to __tlb_adjust_range(). However, I need some assistance on the proper solution. Just adding the __tlb_adjust_range() call to tlb_remove_huge_tlb_entry in the case where size != PMD_SIZE and != PUD_SIZE will silence the BUG. However, one outcome of 2631ed00b049 is that cleared_p* is set if __tlb_adjust_range is ever called. It 'seems' that tlb_flush_pte_range() should be called for the CONT PTE case on arm64, and tlb_flush_pmd_range() should be called for CONT PMD. But, this would require an arch specific version of tlb_remove_huge_tlb_entry. FYI - This same issue should exist on other architectures that support hugetlb page sizes != PMD_SIZE and != PUD_SIZE. Suggestions on how to proceed? -- Mike Kravetz