From: Felix Kuehling <felix.kuehling@amd.com>
To: Philip Yang <Philip.Yang@amd.com>, amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/amdkfd: flush TLB after updating GPU page table
Date: Thu, 29 Apr 2021 02:11:12 -0400 [thread overview]
Message-ID: <3ba303ba-c9f0-24c1-0b23-9b40e38d2935@amd.com> (raw)
In-Reply-To: <20210429015339.13047-2-Philip.Yang@amd.com>
Am 2021-04-28 um 9:53 p.m. schrieb Philip Yang:
> To workaround the situation that vm retry fault keep coming after page
> table update. We are investigating the root cause, but once this issue
> happens, application will stuck and sometimes have to reboot to recover.
>
> Signed-off-by: Philip Yang <Philip.Yang@amd.com>
This patch is
Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
> index d9111fea724b..a165e51c4a1c 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
> @@ -1225,6 +1225,9 @@ static int svm_range_map_to_gpus(struct svm_range *prange,
> break;
> }
> }
> +
> + amdgpu_amdkfd_flush_gpu_tlb_pasid((struct kgd_dev *)adev,
> + p->pasid);
> }
>
> return r;
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2021-04-29 6:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 1:53 [PATCH 1/2] drm/amdkfd: wait migration done only if migration starts Philip Yang
2021-04-29 1:53 ` [PATCH 2/2] drm/amdkfd: flush TLB after updating GPU page table Philip Yang
2021-04-29 6:11 ` Felix Kuehling [this message]
2021-04-29 6:10 ` [PATCH 1/2] drm/amdkfd: wait migration done only if migration starts Felix Kuehling
2021-05-05 17:54 ` philip yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ba303ba-c9f0-24c1-0b23-9b40e38d2935@amd.com \
--to=felix.kuehling@amd.com \
--cc=Philip.Yang@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.