From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D06DCC433ED for ; Mon, 10 May 2021 13:40:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 915B96142D for ; Mon, 10 May 2021 13:40:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236986AbhEJNl6 (ORCPT ); Mon, 10 May 2021 09:41:58 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:44298 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238635AbhEJNEh (ORCPT ); Mon, 10 May 2021 09:04:37 -0400 Received: from mail-qt1-f198.google.com ([209.85.160.198]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lg5ZB-0007DH-0P for linux-gpio@vger.kernel.org; Mon, 10 May 2021 13:03:21 +0000 Received: by mail-qt1-f198.google.com with SMTP id r20-20020ac85c940000b02901bac34fa2eeso10321700qta.11 for ; Mon, 10 May 2021 06:03:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=MbGqG1sl2bPlNa6+74LoXiACLGc6BiOtk88NxsSE+AY=; b=RoxRTBYr+e+JMfTauDH5R5sYyp+bEVfvFt/9BILt73x8xeo5KjLCbeqwRG+dRFyMME WSJCoputdJ6JihNTHkbp9uJOGjGe4nFWNfOL/d+l4QW3FWo3iGvmB9+krHZ6B2+sBPvQ VLngkOdbf8VJBFtg0sMCdj9Mikbu816BRVF56wRBKJS5RC9cf5umyyFurWmuJhIvNcrM wYIM5gxvNbLNB0/M91IKIq5mjVPapQi5Kh7b/4aA3zeRZ5tECS8k5LNC9h38u4VcMH7i makev00RfKDvPFPS0YHnx5/BSjtTEPvehpeBQWQYTImt4DAGiPgS8WCh4DyxGwynDwSc 1T2w== X-Gm-Message-State: AOAM531vGNywhsMiyUNltlk2/62Q2nbX4nudVKyXrRk1NWPhJq+c9TWO Qp88ZJMC8EM6qI4dzgeecBi1xq2C4PvLFcsdJQ6OK5pAcwfcjYKMVr2zop46rHOlhM62Tl5QCNh GuDz3HXM/mBl2UAFuU2hyVNaHjO/y/OsIHLycl9E= X-Received: by 2002:a05:620a:15f7:: with SMTP id p23mr21786082qkm.178.1620651800142; Mon, 10 May 2021 06:03:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzd8s28LSxq8tUMy7z9+LnTPfJPs32ao6LYW4bs5JpkeVNJFE9Gh7LFTqRifB+Q6AdPYAjS0w== X-Received: by 2002:a05:620a:15f7:: with SMTP id p23mr21786045qkm.178.1620651799761; Mon, 10 May 2021 06:03:19 -0700 (PDT) Received: from [192.168.1.4] ([45.237.49.1]) by smtp.gmail.com with ESMTPSA id q13sm11608797qkj.43.2021.05.10.06.03.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 May 2021 06:03:18 -0700 (PDT) Subject: Re: [PATCH 1/2] dt-bindings: pinctrl: Add DT bindings for apple,pinctrl To: Mark Kettenis , devicetree@vger.kernel.org Cc: Hector Martin , Linus Walleij , Rob Herring , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210508142000.85116-1-kettenis@openbsd.org> <20210508142000.85116-2-kettenis@openbsd.org> From: Krzysztof Kozlowski Message-ID: <3bad54b9-599a-91c6-48b8-dd1c494f61b5@canonical.com> Date: Mon, 10 May 2021 09:03:13 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210508142000.85116-2-kettenis@openbsd.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 08/05/2021 10:19, Mark Kettenis wrote: > The Apple GPIO controller is a simple combined pin and GPIO conroller > present on Apple ARM SoC platforms, including various iPhone and iPad > devices and the "Apple Silicon" Macs. > > Signed-off-by: Mark Kettenis > --- > .../bindings/pinctrl/apple,pinctrl.yaml | 103 ++++++++++++++++++ > MAINTAINERS | 2 + > include/dt-bindings/pinctrl/apple.h | 13 +++ > 3 files changed, 118 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pinctrl/apple,pinctrl.yaml > create mode 100644 include/dt-bindings/pinctrl/apple.h > > diff --git a/Documentation/devicetree/bindings/pinctrl/apple,pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/apple,pinctrl.yaml > new file mode 100644 > index 000000000000..cc7805ca6ba1 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pinctrl/apple,pinctrl.yaml > @@ -0,0 +1,103 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pinctrl/apple,pinctrl.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Apple GPIO controller > + > +maintainers: > + - Mark Kettenis > + > +description: | > + The Apple GPIO controller is a simple combined pin and GPIO conroller > + present on Apple ARM SoC platforms, including various iPhone and iPad > + devices and the "Apple Silicon" Macs. > + > +properties: > + compatible: > + items: > + - const: apple,t8103-pinctrl > + - const: apple,pinctrl What is the point of having very generic final compatible in the binding which does not relate to actual hardware? Let's say next SoC will be apple,x-abcd-foo-2323-whatever-nothing-in-common and you still have to use generic "apple,pinctrl" even though HW is not at all compatible? This looks like wildcard, not HW description. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA5CEC433ED for ; Mon, 10 May 2021 13:05:03 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 645C3611CA for ; Mon, 10 May 2021 13:05:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 645C3611CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ed1XTI9afxN3rB2ACyhZichZ8AMjpkFnAfWJt2Sn1JM=; b=AKc2mYtf/vmi3jwV+STn71qA/ IhYD0ax+93H7VbO6iokZYzA1Rdj9c51StFCbLEYKxaq+6S3lX0CIPegK2kEIW7L9fYRNB4sv6OIcy /XxeuEtt6HiNaCsNWZ2dzanQQFbbz64FSj0YZzYmZoPSEbH9HBM7YeHX2mBjVt1fL6lvFES8lphQw iYQ7cH4xumkIoQgQtzeydZVagoRZiu27EX76K6Yf7rV/cOgb2cHdE753I6Qql4s3K2PPO/Iw4fQ+K teLEzi3zxfMs/9Hxt9TxuBUe3PIVfgnNC7p4EgCP1OxRw+KjZfd1mNnWHUSO+ilHcbFUekEo6jfrT SrugD34ig==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lg5ZL-00ENxO-2C; Mon, 10 May 2021 13:03:31 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lg5ZI-00ENwy-5f for linux-arm-kernel@desiato.infradead.org; Mon, 10 May 2021 13:03:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=MbGqG1sl2bPlNa6+74LoXiACLGc6BiOtk88NxsSE+AY=; b=Z66sXcr7UViIxOZg8xQJvMuIvL 2p6fIP7VQeBELuJ5F73vcmAgHKyB2Q3WP4rqtGrtHWhhNko6xtY31sgP46BhPzHQe0QXEfE2SkM3p I+GBXqcaIJr28uDJlrFE/NJBx3bWeW/sUpMfqpXiS0+BNqBXM15DW9Vwn4naU9627xMThff2sKwvf uJm5C7dWQnCHgfMhWmDg7pjGnqX/7TfoUJbgMST92Eb5d/vQGtjuSbVHrp1iuOze5TVVkw/nKEv9E /+qCEhcts+gC7EzIt5S9X5SxvLl94zzw2E681KZZEwRkNSfhNmEEuJ+S6r4ynuj709LaFWfjGKWCq visJzAFw==; Received: from youngberry.canonical.com ([91.189.89.112]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lg5ZF-008j77-9y for linux-arm-kernel@lists.infradead.org; Mon, 10 May 2021 13:03:26 +0000 Received: from mail-qk1-f199.google.com ([209.85.222.199]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lg5ZB-0007DL-1z for linux-arm-kernel@lists.infradead.org; Mon, 10 May 2021 13:03:21 +0000 Received: by mail-qk1-f199.google.com with SMTP id 4-20020a370d040000b02902fa09aa4ad4so3062193qkn.11 for ; Mon, 10 May 2021 06:03:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=MbGqG1sl2bPlNa6+74LoXiACLGc6BiOtk88NxsSE+AY=; b=aNLocC+XcXIbRO0CkIUaEy17vjJcCLspTSeT8r6yTETCRFTonR7nrtc44Tlx+zaAck Em6c8oxU2GFKhfLGgjjvSLGkE0bBFz9IbX+73lF1OgUta1LVx1K+aPY95ujbReh3xgrc 067AENV25T+lC16HT9XLOG04FgG5QaypMyhwAMsF8rZMDgwse0FsSUQzdlNGRmc0Jn+0 2jwVs+DRv0iBzET5204RZYwTcpTYMWRVIzb8ekXauTxch+tfBCQKhqFfWaOxkoSafLTi IcPZg5PkHb9ketNOgnJgYHnjJzpLXjvfWhxnLPKFxEMi5O+HuZd1SbbkCskWaVtbBd/s H5hQ== X-Gm-Message-State: AOAM530K3lWl0Ieedmdo7IpZ/NY+T5W4d39gAZeCfvmtQDtebRNcGWBv vS9xWESPTj0ZTkin7/xjC0zk0CP10qHwkOXBCCK8kuAIEKlxRNmKlFAL5/6CA3kxCvwyOl30L6K TrQtuRILPZryXLPVmmApFm91ikE+U7xmSeRkJb+dGgwQ+KkM23iTJ X-Received: by 2002:a05:620a:15f7:: with SMTP id p23mr21786086qkm.178.1620651800143; Mon, 10 May 2021 06:03:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzd8s28LSxq8tUMy7z9+LnTPfJPs32ao6LYW4bs5JpkeVNJFE9Gh7LFTqRifB+Q6AdPYAjS0w== X-Received: by 2002:a05:620a:15f7:: with SMTP id p23mr21786045qkm.178.1620651799761; Mon, 10 May 2021 06:03:19 -0700 (PDT) Received: from [192.168.1.4] ([45.237.49.1]) by smtp.gmail.com with ESMTPSA id q13sm11608797qkj.43.2021.05.10.06.03.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 May 2021 06:03:18 -0700 (PDT) Subject: Re: [PATCH 1/2] dt-bindings: pinctrl: Add DT bindings for apple,pinctrl To: Mark Kettenis , devicetree@vger.kernel.org Cc: Hector Martin , Linus Walleij , Rob Herring , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210508142000.85116-1-kettenis@openbsd.org> <20210508142000.85116-2-kettenis@openbsd.org> From: Krzysztof Kozlowski Message-ID: <3bad54b9-599a-91c6-48b8-dd1c494f61b5@canonical.com> Date: Mon, 10 May 2021 09:03:13 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210508142000.85116-2-kettenis@openbsd.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210510_060325_377925_B28348CB X-CRM114-Status: GOOD ( 20.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 08/05/2021 10:19, Mark Kettenis wrote: > The Apple GPIO controller is a simple combined pin and GPIO conroller > present on Apple ARM SoC platforms, including various iPhone and iPad > devices and the "Apple Silicon" Macs. > > Signed-off-by: Mark Kettenis > --- > .../bindings/pinctrl/apple,pinctrl.yaml | 103 ++++++++++++++++++ > MAINTAINERS | 2 + > include/dt-bindings/pinctrl/apple.h | 13 +++ > 3 files changed, 118 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pinctrl/apple,pinctrl.yaml > create mode 100644 include/dt-bindings/pinctrl/apple.h > > diff --git a/Documentation/devicetree/bindings/pinctrl/apple,pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/apple,pinctrl.yaml > new file mode 100644 > index 000000000000..cc7805ca6ba1 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pinctrl/apple,pinctrl.yaml > @@ -0,0 +1,103 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pinctrl/apple,pinctrl.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Apple GPIO controller > + > +maintainers: > + - Mark Kettenis > + > +description: | > + The Apple GPIO controller is a simple combined pin and GPIO conroller > + present on Apple ARM SoC platforms, including various iPhone and iPad > + devices and the "Apple Silicon" Macs. > + > +properties: > + compatible: > + items: > + - const: apple,t8103-pinctrl > + - const: apple,pinctrl What is the point of having very generic final compatible in the binding which does not relate to actual hardware? Let's say next SoC will be apple,x-abcd-foo-2323-whatever-nothing-in-common and you still have to use generic "apple,pinctrl" even though HW is not at all compatible? This looks like wildcard, not HW description. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel