From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Florian Fainelli <f.fainelli@gmail.com>, Andrew Lunn <andrew@lunn.ch>
Cc: Doug Berger <opendmb@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, <netdev@vger.kernel.org>,
<bcm-kernel-feedback-list@broadcom.com>
Subject: Re: [PATCH] bcmgenet: add WOL IRQ check
Date: Fri, 14 Jan 2022 13:58:20 +0300 [thread overview]
Message-ID: <3bc2809a-b8b1-b6bd-139f-2a6000b6f8d1@omp.ru> (raw)
In-Reply-To: <184f55fb-c73b-989b-973e-e9562f511116@gmail.com>
Hello!
On 1/14/22 12:37 AM, Florian Fainelli wrote:
>>> The driver neglects to check the result of platform_get_irq_optional()'s
>>> call and blithely passes the negative error codes to devm_request_irq()
>>> (which takes *unsigned* IRQ #), causing it to fail with -EINVAL.
>>> Stop calling devm_request_irq() with the invalid IRQ #s.
>>>
>>> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
>>>
>>> ---
>>> This patch is against DaveM's 'net.git' repo.
>>
>> Since this is for net, it needs a Fixes: tag.
>>
>> Fixes: 8562056f267d ("net: bcmgenet: request Wake-on-LAN interrupt")
>
> I don't have strong objections whether we want to consider this a bug fix or not,
Formally, it's a fix -- as you shouldn't call devm_request_irq() with "negative" IRQ #s.
> but since the code only acts upon devm_request_irq() returning 0 meaning success, this seems more like an improvement rather than fixing an actual issue.
More like a cleanup (no, not improvement).
MBR, Sergey
next prev parent reply other threads:[~2022-01-14 10:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-13 19:46 [PATCH] bcmgenet: add WOL IRQ check Sergey Shtylyov
2022-01-13 21:00 ` Andrew Lunn
2022-01-13 21:37 ` Florian Fainelli
2022-01-13 21:47 ` Florian Fainelli
2022-01-14 10:58 ` Sergey Shtylyov [this message]
2022-01-14 11:03 ` Sergey Shtylyov
2022-01-14 11:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3bc2809a-b8b1-b6bd-139f-2a6000b6f8d1@omp.ru \
--to=s.shtylyov@omp.ru \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.