From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [PATCH] usertools/dpdk-devbind.py: add support for
 wind river avp device
Date: Mon, 12 Feb 2018 10:13:01 +0000
Message-ID: <3bc80bbb-155a-c9f7-1b9d-b6e26ca42e37@intel.com>
References: <1518342737-9244-1-git-send-email-xiaohua.zhang@windriver.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
To: Xiaohua Zhang <xiaohua.zhang@windriver.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id A25F61B31B
 for <dev@dpdk.org>; Mon, 12 Feb 2018 11:13:04 +0100 (CET)
In-Reply-To: <1518342737-9244-1-git-send-email-xiaohua.zhang@windriver.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 11-Feb-18 9:52 AM, Xiaohua Zhang wrote:
> Signed-off-by: Xiaohua Zhang <xiaohua.zhang@windriver.com>
> ---
>   usertools/dpdk-devbind.py | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
> index 18d9386..f488318 100755
> --- a/usertools/dpdk-devbind.py
> +++ b/usertools/dpdk-devbind.py
> @@ -22,11 +22,14 @@
>                 'SVendor': None, 'SDevice': None}
>   cavium_pkx = {'Class': '08', 'Vendor': '177d', 'Device': 'a0dd,a049',
>                 'SVendor': None, 'SDevice': None}
> +avp_vnic = {'Class': '05', 'Vendor': '1af4', 'Device': '1110',
> +              'SVendor': None, 'SDevice': None}
>   
>   network_devices = [network_class, cavium_pkx]
>   crypto_devices = [encryption_class, intel_processor_class]
>   eventdev_devices = [cavium_sso]
>   mempool_devices = [cavium_fpa]
> +avp_devices = [avp_vnic]
>   
>   # global dict ethernet devices present. Dictionary indexed by PCI address.
>   # Each device within this is itself a dictionary of device properties
> @@ -565,6 +568,9 @@ def show_status():
>       if status_dev == "mempool" or status_dev == "all":
>           show_device_status(mempool_devices, "Mempool")
>   
> +    if status_dev == "avp" or status_dev == "all":
> +        show_device_status(avp_devices, "AVP")
> +
>   def parse_args():
>       '''Parses the command-line arguments given by the user and takes the
>       appropriate action for each'''
> @@ -638,6 +644,7 @@ def do_arg_actions():
>               get_device_details(crypto_devices)
>               get_device_details(eventdev_devices)
>               get_device_details(mempool_devices)
> +            get_device_details(avp_devices)
>           show_status()
>   
>   
> @@ -650,6 +657,7 @@ def main():
>       get_device_details(crypto_devices)
>       get_device_details(eventdev_devices)
>       get_device_details(mempool_devices)
> +    get_device_details(avp_devices)
>       do_arg_actions()
>   
>   if __name__ == "__main__":
> 

Is there any particular reason why this device appears in its own 
category, rather than being added to one of the existing device classes? 
I'm not familiar with AVP but it looks like it's a NIC, so shouldn't it 
be in network_devices category?

-- 
Thanks,
Anatoly