From: Thomas Huth <thuth@redhat.com>
To: "Max Reitz" <mreitz@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Laurent Vivier" <laurent@vivier.eu>,
qemu-devel@nongnu.org, Qemu-block <qemu-block@nongnu.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>
Subject: Re: [PULL 5/5] m68k: add Virtual M68k Machine
Date: Fri, 19 Mar 2021 07:32:41 +0100 [thread overview]
Message-ID: <3bcc22b2-eb25-b0a0-f47b-72c747ca6f0a@redhat.com> (raw)
In-Reply-To: <82f6dc3e-18bf-f90a-7e43-5568b319767c@redhat.com>
On 18/03/2021 18.28, Max Reitz wrote:
[...]
> From that it follows that I don’t see much use in testing specific devices
> either. Say there’s a platform that provides both virtio-pci and
> virtio-mmio, the default (say virtio-pci) is fine for the iotests. I see
> little value in testing virtio-mmio as well. (Perhaps I’m short-sighted,
> though.)
That's a fair point. But still, if someone compiled QEMU only with a target
that only provided virtio-mmio, the iotests should not fail when running
"make check".
To avoid that we continue playing whack-a-mole here in the future, maybe it
would be better to restrict the iotests to the "main" targets only, e.g.
modify check-block.sh so that the tests only run with x86, aarch64, s390x
and ppc64 ?
Thomas
next prev parent reply other threads:[~2021-03-19 6:33 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 20:42 [PULL 0/5] M68k for 6.0 patches Laurent Vivier
2021-03-15 20:42 ` [PULL 1/5] hw/char: add goldfish-tty Laurent Vivier
2021-03-15 20:42 ` [PULL 2/5] hw/intc: add goldfish-pic Laurent Vivier
2021-03-15 20:42 ` [PULL 3/5] m68k: add an interrupt controller Laurent Vivier
2021-03-15 20:42 ` [PULL 4/5] m68k: add a system controller Laurent Vivier
2021-03-15 20:42 ` [PULL 5/5] m68k: add Virtual M68k Machine Laurent Vivier
2021-03-18 9:19 ` Philippe Mathieu-Daudé
2021-03-18 9:52 ` Laurent Vivier
2021-03-18 10:02 ` Philippe Mathieu-Daudé
2021-03-18 10:06 ` Laurent Vivier
2021-03-18 10:35 ` Paolo Bonzini
2021-03-18 10:40 ` Peter Maydell
2021-03-18 10:45 ` Paolo Bonzini
2021-03-18 11:10 ` Peter Maydell
2021-03-18 11:20 ` Philippe Mathieu-Daudé
2021-03-18 15:36 ` Philippe Mathieu-Daudé
2021-03-18 15:51 ` Laurent Vivier
2021-03-18 15:56 ` Laurent Vivier
2021-03-18 16:25 ` Philippe Mathieu-Daudé
2021-03-18 17:28 ` Max Reitz
2021-03-19 6:32 ` Thomas Huth [this message]
2021-03-19 9:20 ` Max Reitz
2021-03-19 9:29 ` Paolo Bonzini
2021-03-19 10:51 ` Laurent Vivier
2021-03-19 11:08 ` Paolo Bonzini
2021-03-19 10:50 ` Laurent Vivier
2021-03-19 10:51 ` Max Reitz
2021-03-19 10:57 ` Max Reitz
2021-03-19 10:55 ` Thomas Huth
2021-03-18 16:50 ` Paolo Bonzini
2021-03-17 13:34 ` [PULL 0/5] M68k for 6.0 patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3bcc22b2-eb25-b0a0-f47b-72c747ca6f0a@redhat.com \
--to=thuth@redhat.com \
--cc=laurent@vivier.eu \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.