All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael Opdenacker" <michael.opdenacker@bootlin.com>
To: nagesh shamnur <nagesh.shamnur@gmail.com>,
	openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH 1/1] fix compilation error when add libgloss under DEPENDS in recipe
Date: Wed, 28 Jul 2021 10:17:46 +0200	[thread overview]
Message-ID: <3bda3524-7dcd-9f8f-d22b-00a3034a4e8d@bootlin.com> (raw)
In-Reply-To: <CAA_JV5OinDTfVwtVN4hYexvr2c08NxL5=A-pAsiBquFqvEUPEQ@mail.gmail.com>

Hi Nagesh,

On 7/28/21 9:53 AM, nagesh shamnur wrote:
>  Dear Group,
>     When include newlib and libgloss under DEPENDS in custom recipe,
>  then newlib compilation is successful however libgloss compilation
>  fails since it is unable to find the needed include path under
>  recipe-sysroot/usr/include. This patch is to fix this issue by
>  including recipe-sysroot/usr/include while configuring libgloss.


Many thanks for your patch corresponding to the fix that you found for
your recent issue!

The patch looks good, but next time, it would be even better if you
could send it as an inline attachment (easiest to do with the "git
send-email"  command). This makes it easier for people to review your
patch and in particular directly quote parts of your patch and comment
or reply on specific lines.

I realize that the YP manual doesn't explain this requirement well. I'll
post an improvement to the corresponding section
(https://docs.yoctoproject.org/dev-manual/common-tasks.html#using-email-to-submit-a-patch).

Thanks again,
Michael.

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


  reply	other threads:[~2021-07-28  8:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAA_JV5PZwZh8mMw0ZoVBuCA1570ki0gqSi_Du=UqXfNtuG6P4w@mail.gmail.com>
2021-07-28  7:53 ` [PATCH 1/1] fix compilation error when add libgloss under DEPENDS in recipe nagesh.shamnur
2021-07-28  8:17   ` Michael Opdenacker [this message]
2021-07-28  8:37     ` [OE-core] " nagesh shamnur
     [not found]   ` <1695E67E3139B070.18968@lists.openembedded.org>
2021-07-28  8:44     ` Michael Opdenacker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3bda3524-7dcd-9f8f-d22b-00a3034a4e8d@bootlin.com \
    --to=michael.opdenacker@bootlin.com \
    --cc=nagesh.shamnur@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.