Re: [kvm-unit-tests PATCH 2/3] s390x: skrf: Add exception new skey test and add test to unittests.cfg

[Janosch Frank <frankja@linux.ibm.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1620 bytes --]

On 7/23/20 2:10 PM, Cornelia Huck wrote:
> On Tue, 21 Jul 2020 17:03:10 +0200
> Janosch Frank <frankja@linux.ibm.com> wrote:
> 
>> On 7/21/20 4:28 PM, Thomas Huth wrote:
>>> On 21/07/2020 10.52, Janosch Frank wrote:  
>>>> On 7/21/20 9:28 AM, Thomas Huth wrote:  
>>>>> On 17/07/2020 16.58, Janosch Frank wrote:  
>>>>>> If a exception new psw mask contains a key a specification exception
>>>>>> instead of a special operation exception is presented.  
>>>>>
>>>>> I have troubles parsing that sentence... could you write that differently?
>>>>> (and: "s/a exception/an exception/")  
>>>>
>>>> How about:
>>>>
>>>> When an exception psw new with a storage key in its mask is loaded from
>>>> lowcore a specification exception is raised instead of the special
>>>> operation exception that is normally presented when skrf is active.  
>>>
>>> Still a huge beast of a sentence. Could you maybe make two sentences out
>>> of it? For example:
>>>
>>> " ... is raised. This differs from the normal case where ..."  
>>
>> When an exception psw new with a storage key in its mask is loaded from
>> lowcore a specification exception is raised. This behavior differs from
>> the one that is presented when trying to execute skey related
>> instructions which will raise special operation exceptions.
> 
> s/psw new/new psw/ ?

Yeah that would align the naming with the pop one.

> 
> (And probably a comma after 'lowcore'.)
> 
> "This differs from the behaviour when trying to execute skey related
> instructions, which will result in special operation exceptions."
> 
> ?

Sure



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]