From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F61AC433F5 for ; Wed, 15 Sep 2021 02:53:29 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BB1DB60F6F for ; Wed, 15 Sep 2021 02:53:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BB1DB60F6F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oss.nxp.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8513980ECB; Wed, 15 Sep 2021 04:53:25 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=oss.nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="Lysz4FOH"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 38480812B6; Wed, 15 Sep 2021 04:53:23 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20613.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e1b::613]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9CF2E80EC5 for ; Wed, 15 Sep 2021 04:53:19 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=oss.nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=peng.fan@oss.nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NsmYSCiJaAjVc0Kz9XxBiR8EWuPjGNi1yh/a4Gq2A+MsY1szZGMHo48fdhqbSjL6Fx2PgQtVPMgVc29g/HVDQE6HXkXykkQJXmXe5suu50REejS752S7+g6pFcPbaJbLGdYWXG/m4i7wh/turWEQaarrsNLdnv096Hs1GKLhHyyLIpicJ27cU0zEkuDqlTdfSsMnrwx0Cps+49sJSSXKQBfkZ19nQZEiz1IZRmQ7s+YXSqwySoOdTGzb7MCkhsiWqDPFN4pHT7sIVhrcrtuRe6okX4o98yIi5HFfNQDlTQr9Uqsda4EIlTtbYWkJPQcEeGIad8QBADgEFWvotDumRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ZmGGWHkQj7MMQdtQg2GJzxBGk9mbA6K/vfrPGVYR7mg=; b=hBg5Fj2yuVrTrgDXhZ8pCXhyhtriUQk5YcwkYFub1T/KEZgC0LW+lEVEFshbNS+6pFfeDtUXxW5Kq3wZUNkIxZ4imIKGm+ALF034w2uQEThvtyRYM+KUw8N9h4WhKpnQmHYfYvaycjzthhymcALZbf+d07NLJ0rOSw0nfUlF+lIQ2WurioWts1FhIeyV8aiDqB6/MkKknTzHiPGBlJdJOxc04kcQcSmlnZ6WYVxj1wVxFbvVjNDi61fwomDBVz+VblpfiLGnkcdM0Ktqs393mrKOC3N9to+KAzZNX982AvtKaC9fiSL8LtAZAzScx6ihJIm+9v+qECkDZwc+516Wfg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZmGGWHkQj7MMQdtQg2GJzxBGk9mbA6K/vfrPGVYR7mg=; b=Lysz4FOHpQhFroAobqYAiYPTEyJQr8RNBDxIZ0rJ6nFCPV+QKSd3Jg1VzlY92zsttmmoYjFSOzr6r2cgG6RuDtOgesi4oJz9qL8QomQLwU/9m11ssoW5FwrdmoX9uFXfyfV6bpf4//i1XCLIYIJy+iyetXoH2juOwklB0MUh1Gs= Authentication-Results: walle.cc; dkim=none (message not signed) header.d=none;walle.cc; dmarc=none action=none header.from=oss.nxp.com; Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) by DBBPR04MB7659.eurprd04.prod.outlook.com (2603:10a6:10:209::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.16; Wed, 15 Sep 2021 02:53:18 +0000 Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::4868:6843:a39f:aa53]) by DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::4868:6843:a39f:aa53%4]) with mapi id 15.20.4500.018; Wed, 15 Sep 2021 02:53:18 +0000 Subject: Re: imx: imx8mq: mxc_get_clock for MXC_I2C_CLK is missing To: Heiko Thiery , "u-boot@lists.denx.de" , Peng Fan Cc: Fabio Estevam , Michael Walle References: From: "Peng Fan (OSS)" Message-ID: <3c009540-1e67-f828-32a4-f3eec6711757@oss.nxp.com> Date: Wed, 15 Sep 2021 10:53:09 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SG2PR01CA0135.apcprd01.prod.exchangelabs.com (2603:1096:4:8f::15) To DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [10.193.99.168] (119.31.174.71) by SG2PR01CA0135.apcprd01.prod.exchangelabs.com (2603:1096:4:8f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14 via Frontend Transport; Wed, 15 Sep 2021 02:53:15 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f41c3bdf-ad26-462d-7565-08d977f3f85f X-MS-TrafficTypeDiagnostic: DBBPR04MB7659: X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pmlUJWgmgp2bUPQDtIxi1P6oeyVeYFK5QVEJw97wXUx6CcQU+NxNCaiapdFGgLsAol8iQ6bgon+bPtkuntzucyslW5eSuJWkCamANJ9q4kEIBgsVYlO7F7ZegBy6Sau0Vxxddi38hJk0u0GgoOaVlA2qg5a2sKWyulA/N8vjwquNeUip2CaSZrJLw0cdONIvtr93XQ/SPY9dhQF7rDumK+221HABFkVABgli+mcfviW6vs9ejvBHrH8UlqEhrNQkaotQT83vbxaJ4QOtbNT2nkPIGJt/XNnkm5jcD5ZDeEy4/CVwFnb3WzkUxPjWGTwAcCZWQYdZPuO1N6TNwL0iNb98goNimcrTb1MQKpUWrA37PbNy7HbPQpOL8EEVEHM/u6V5SwJCo6FrdxlxN0vX1vSmhd1Aod8NWmTTmuoAy4q4DMQg/aYYZG+AdwbgmpvuPZe+O35S2jZKXpcn8dGVkFvMUKXOOGBT/8+j/xHQejgi1EBQMtsSOirZ5pFYi8EsSMfrKN5R+wSaAbdc7dtVzS087E0cUIphFlExVcgEJHHNtndH4HfmJEaDpN2j61Jku0I8auoMzQMwzACBEtZsvj1mgqndtcwcL7BYKjsoVNga5W46iT4G8IRtOvALV5fns5M35jRZ+xpr8Lpj/XS1vn/zoVVGsgP7GBTNT2xjuoWpMW5Rk2GsYPgJqoKDilKuDeSLqwyBSq4vzj++JTBUEQ5MYK3Cy4StNvuIc9RD08UdmNzOQgL6WbvMIL59mi90OHqzrTFAw814cTLiip7xQewfaq4XIKFrtSTfD6Szu/I= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0402MB2760.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(396003)(366004)(136003)(39860400002)(346002)(31696002)(316002)(4326008)(16576012)(66946007)(110136005)(26005)(53546011)(38350700002)(38100700002)(8936002)(8676002)(54906003)(956004)(66556008)(66476007)(6666004)(5660300002)(6486002)(83380400001)(186003)(52116002)(86362001)(2616005)(2906002)(478600001)(31686004)(70780200001)(32563001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cVJwblkyaEdwNzNUbk5ZNnd4ZGo5R25LUDFidEppNWdpQ2UvNmk1UUt6dHpE?= =?utf-8?B?bzZRbkMvbXVCQmdWaWVTdStlNTRGSmhsbm1ZY0hyY3B5Um03T0hWVVozSEVo?= =?utf-8?B?MlluVWtJclo0cmZwVFpOY1ovMy9UcDArczBIajduWTlvY092VGpZR3QvZWVT?= =?utf-8?B?ZVoxdEd5d2g0QVJsOEU2YytVSWRja1JqdHk0ZnFRTW13bjNkUVRUTVZYZjc0?= =?utf-8?B?TGNkeWMrSVI2QXBpODBTQ21kNFJENUJ5S2RDVXVnZWhTZXFBNzQzZFIyWjU5?= =?utf-8?B?SW9QWGJvenErY1ArWDZLSUo0cFhCZ3MwWWN5Z1E5Z0h2UkY5RWFTSEN1eVRm?= =?utf-8?B?ZUQzVVVBZGMyRXYyUHNQZ2UzSkY1V2NhV2pXSzVrY3VtUVNMcDJDZmRwSFAr?= =?utf-8?B?L2p0cjkyMTNRclJjcUtqSmw0dm1GV0VhNGQzOThBL2xieXQ5NHJ6ZFFLeldX?= =?utf-8?B?enh2TDRsUnRkellnUlJxT0gzeklURzgrV29MaFljR3pvM1ZWd3UrY2JuRzNK?= =?utf-8?B?SE5MS0w2UHJIZk11UzV2VklkMXoyR3VlWktISDVPNjJXMFl1dzJHWmxzaGJI?= =?utf-8?B?c3FXSllnbitycFkycnRZTDFma1VhMThwMnJTT2ZsKzZYMVhjRXd4dko5enRx?= =?utf-8?B?bU81VTNrUVpWbGdTRGRqNkxLZEQyY2p1VXZXNktUNWR6SFZPV0hFL2liNVM2?= =?utf-8?B?N3dXWlRxTnlZbWZKVE8wUkEzTUY2bnBBaTlhZFVNMVRSTVIxcnFiazJrbmJq?= =?utf-8?B?WEdOTkxvQkgvVDJXMUJPbjVzNnNjM2JEaWxVNUVMZ0lxNllUeWpNOXczL0I3?= =?utf-8?B?bzFRR01ISUp3YW5qRUdNTmJEUUw4SEtSWklQUW82LzliSXplSnhlTS9HOE1x?= =?utf-8?B?SGwvNjhuQ0xmQXpVRHRueVJPaTU1eVhMNmdBYnlhTFNjRFprVlRIRzlDK2VL?= =?utf-8?B?TTZCdEE3aHlsWVA3dTB3TTA5ZUp1T08xaW9nejZUOE1rT2FUZUU0RXdtQ3h6?= =?utf-8?B?dHA5ay9nYXEvVjJIRExUbVBmZTIrNkVVeVg2dGtMUFFIbkl4Tlo0MENOTDVy?= =?utf-8?B?amNoR0krUWROZjVkUzgvWkVva3RWMlBlbWdDcnFSazdPWkJyK3U5aStnaEZq?= =?utf-8?B?OHdMODhmMmlIaHM3LzEwSUk5M2dzQUtDZFJuL1BPY3l2bUlYVGF0anRuRUUv?= =?utf-8?B?dm92Snc4Sk9pN0hybGFoZUZxdTh4SjBibUNTdVk4dkltY3F0QWRqbW1BMFhC?= =?utf-8?B?eVhFVHJ4Q3hoV1AwVXE0TXlaN01mSmg4MHlwR21KaExpL1ZoYmJsK2huNzJF?= =?utf-8?B?OVhDSTlDWG9makxGRHNDLzdVUUZVNzgwMDg1TSt3KzBxaC9LUzJGRDFvRjUw?= =?utf-8?B?V3drRFJtM0NNN1NZTU5NdkFFWUpkZktaelE1U2RDbHFacXlaZGFUbWtnd0ln?= =?utf-8?B?eFo2eUdNNVcxV2pTeU0rSGhpSWVmMmZkM3NkaWNrTXdqV3ZQOVFXUENhMTNx?= =?utf-8?B?UTVzeW1yZ3lPMGtHWUwzb2dQY2pvWFBhd3lOMHc2OVczTkJLY0o4cW9uNERa?= =?utf-8?B?Qk44MFd2RGpSUEFDTGFEdmRYZDA1Q3JteitPSzhKaGJFRnFxZTMrcFhvQ1ND?= =?utf-8?B?K0FyeExjbmx6UzVCWDB4S1FFNVpOblYraHJYWDBRTzlmVFJYdnhZK0RRUTRp?= =?utf-8?B?bEFmSUJuY0kycytZdlBzSXRkNitWT3RXT1ljaDBQd2dPUVJQYnBjZ3E1RG85?= =?utf-8?Q?x5ZE4cCZJKP7pgJXvyeRKtXPDCJP4MRekPbHZ5H?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: f41c3bdf-ad26-462d-7565-08d977f3f85f X-MS-Exchange-CrossTenant-AuthSource: DB6PR0402MB2760.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2021 02:53:18.1267 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xTzot/nco1Zflx6iT129YZOyywT4mwXCN7UsqYazx9HEzg4yoGwcY5iFXawCuT/Yv5ravOEN55HZ3/4e60notA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7659 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 2021/9/8 21:08, Heiko Thiery wrote: > Hi Peng, > > I faced an issue with the I2C bus speed in SPL for the imx8mq. I > figured out that the bus frequency is set to about 1MHz. While digging > into that I found that the clk ID for the I2C is not returned for the > imx8mq correctly. > > Can you confirm that this is missing here. You are right! Thanks for spotting this. Regards, Peng. > > This is what I added and now it looks better. > > diff --git a/arch/arm/mach-imx/imx8m/clock_imx8mq.c > b/arch/arm/mach-imx/imx8m/clock_imx8mq.c > index 60e2218a3c..9e45ffd66b 100644 > --- a/arch/arm/mach-imx/imx8m/clock_imx8mq.c > +++ b/arch/arm/mach-imx/imx8m/clock_imx8mq.c > @@ -363,6 +363,12 @@ unsigned int mxc_get_clock(enum mxc_clock clk) > return get_root_clk(USDHC1_CLK_ROOT); > case MXC_ESDHC2_CLK: > return get_root_clk(USDHC2_CLK_ROOT); > + case MXC_I2C_CLK: > + return get_root_clk(I2C1_CLK_ROOT); > + case MXC_UART_CLK: > + return get_root_clk(UART1_CLK_ROOT); > + case MXC_QSPI_CLK: > + return get_root_clk(QSPI_CLK_ROOT); > default: > return get_root_clk(clk); > } > >