From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56B50C05027 for ; Sun, 29 Jan 2023 11:46:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233002AbjA2Lq5 (ORCPT ); Sun, 29 Jan 2023 06:46:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229637AbjA2Lqx (ORCPT ); Sun, 29 Jan 2023 06:46:53 -0500 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 527AD212BE for ; Sun, 29 Jan 2023 03:46:52 -0800 (PST) Received: by mail-wr1-x42d.google.com with SMTP id m7so8704000wru.8 for ; Sun, 29 Jan 2023 03:46:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=q7mkqEU4uSNcC/souhhQCKfdHQR1f/GwKbFACfeiSw8=; b=ZZiVMpPR4dCSS0JCrzqkIIP9+6EKR1VAw7I2B+SKearBzD6dhIhthOHbPJr6botL32 k2Wr11VSSmxu3YbPRhQ1B56kWn7xNCH9ftDdplBR34cXxHxo69Ma+2iS7iGhfiBoZXUR CZfU+Be/5zIUahSgTsEDCn9x04J+F3h4c6KRNltlCdzsVV8Y4aDcx6W3UFuAdTKcaJSc 1UkxNk6ixU4DJqKa+M2AxATMSkIL9wf17NPXNQinQ4SAEDyIBhxYXaPJ0J2a6KpPI7f9 7FuZeeedlPvMcFYrCV4h+AeKkjvLcaNICDyV1lM5iCyGgwFTXXTGOhfPc9VhfqaWh2eP EmKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=q7mkqEU4uSNcC/souhhQCKfdHQR1f/GwKbFACfeiSw8=; b=jx37b4yRQPW1L/JdWocGLbaRqYiiZB5aQovCXDhuMGsUGXespQ8moEDabTH2vpskYg 50elRrTCVjhclIvYADOXuJL7Ln34DCl6U+5ojuQT/giEE7fkHupHs2zycJ0wG0YRg6R9 SkHczgLGrUvlbi6MKhdju51cM0IsJwGomTL7po4lNUpxKZ1lSkXIjdvf9W+CDXSrH0DQ wDZMakZBor/BND5Zv6E5Gvg0N1ctVBsE+GzT0J5+H2gc3IFR5IMesffhyqnyYUM34/TR e/NHa+RPATMc9Lis/QX/aTt4xAPXAAoHJEl8HXrGeKuixj9eLIgsCMP9J0XLq+ZAguRr VuRA== X-Gm-Message-State: AFqh2kq6zVZ1HSPtrAuZaZdUM0IfgEKOnVf5KNrIm4r09laIXs6L1WsO 5MRhs7PcW58xaUFbGB2Wm06PYA== X-Google-Smtp-Source: AMrXdXssrHw6STGJ3GmPU/EnWu/3lii26xImgKRkdovDdo14zXU3VG6dhI/ytRUzw6RFBBRwulZPkg== X-Received: by 2002:adf:f0c1:0:b0:2bc:67d:c018 with SMTP id x1-20020adff0c1000000b002bc067dc018mr40432601wro.48.1674992810832; Sun, 29 Jan 2023 03:46:50 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id b11-20020adfe30b000000b002bfcc940014sm7736284wrj.82.2023.01.29.03.46.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 29 Jan 2023 03:46:50 -0800 (PST) Message-ID: <3c07b9bd-1981-2945-9efe-80afb0195de8@linaro.org> Date: Sun, 29 Jan 2023 12:46:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 1/2] dt-bindings: display: bridge: Add NXP i.MX93 parallel display format configuration Content-Language: en-US To: Liu Ying , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: andrzej.hajda@intel.com, neil.armstrong@linaro.org, robert.foss@linaro.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, airlied@gmail.com, daniel@ffwll.ch, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com References: <20230128034713.1530218-1-victor.liu@nxp.com> <20230128034713.1530218-2-victor.liu@nxp.com> From: Krzysztof Kozlowski In-Reply-To: <20230128034713.1530218-2-victor.liu@nxp.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/01/2023 04:47, Liu Ying wrote: > NXP i.MX93 mediamix blk-ctrl contains one DISPLAY_MUX register which > configures parallel display format by using the "PARALLEL_DISP_FORMAT" > field. Add device tree bindings for the display format configuration. > > Signed-off-by: Liu Ying > --- > .../display/bridge/nxp,imx93-pdfc.yaml | 78 +++++++++++++++++++ > 1 file changed, 78 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/bridge/nxp,imx93-pdfc.yaml > > diff --git a/Documentation/devicetree/bindings/display/bridge/nxp,imx93-pdfc.yaml b/Documentation/devicetree/bindings/display/bridge/nxp,imx93-pdfc.yaml > new file mode 100644 > index 000000000000..a84bfb46b01d > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/nxp,imx93-pdfc.yaml > @@ -0,0 +1,78 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/bridge/nxp,imx93-pdfc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP i.MX93 Parallel Display Format Configuration > + > +maintainers: > + - Liu Ying > + > +description: | > + The i.MX93 mediamix blk-ctrl contains one DISPLAY_MUX register which > + configures parallel display format by using the "PARALLEL_DISP_FORMAT" > + field. > + > +properties: > + compatible: > + const: nxp,imx93-pdfc Based on description, I have doubts this is a separate bridge device. Why this is not part of display driver/bindings? We do not create usually devices for single registers, because they are not a devices. Devices are a bit more complex - have some pin inputs/outputs, not a register only. Of course there are exception, but this one does not look like one. > + > + reg: > + maxItems: 1 Your driver tells different story: syscon_node_to_regmap(dev->of_node->parent); (which also points to fact this is not a separate device) Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 56E18C05027 for ; Sun, 29 Jan 2023 11:46:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 53A868903B; Sun, 29 Jan 2023 11:46:54 +0000 (UTC) Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6531E8903B for ; Sun, 29 Jan 2023 11:46:52 +0000 (UTC) Received: by mail-wr1-x42e.google.com with SMTP id r2so8695240wrv.7 for ; Sun, 29 Jan 2023 03:46:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=q7mkqEU4uSNcC/souhhQCKfdHQR1f/GwKbFACfeiSw8=; b=ZZiVMpPR4dCSS0JCrzqkIIP9+6EKR1VAw7I2B+SKearBzD6dhIhthOHbPJr6botL32 k2Wr11VSSmxu3YbPRhQ1B56kWn7xNCH9ftDdplBR34cXxHxo69Ma+2iS7iGhfiBoZXUR CZfU+Be/5zIUahSgTsEDCn9x04J+F3h4c6KRNltlCdzsVV8Y4aDcx6W3UFuAdTKcaJSc 1UkxNk6ixU4DJqKa+M2AxATMSkIL9wf17NPXNQinQ4SAEDyIBhxYXaPJ0J2a6KpPI7f9 7FuZeeedlPvMcFYrCV4h+AeKkjvLcaNICDyV1lM5iCyGgwFTXXTGOhfPc9VhfqaWh2eP EmKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=q7mkqEU4uSNcC/souhhQCKfdHQR1f/GwKbFACfeiSw8=; b=yvbYY6AplmtTnntAMzVweGWZQfwHoLZvKcU/4GDUO8vhp8c2MYW8Lf/4ws5pS/8BBv 5ZHx5akX5rLnzq9UJ/7yhkyU+fWFBMEo1UTRojKih1fO5HLLpuiYSR8D2NeO35wmiGAM ja2hGNPxmHjoiRhlCeWcM4vDoKN+Vc0AJODTi5LxTGwNupYGZcZEWmSEwmE8UognRZb0 vU5uKXQv9FaOHkgjfNxKbGOzWrObz+gGD/9gBCHq7lz6cin3UsEwN20tj7DaABodx6sn gziyG1hEg2pelbFSOSDpPtosV6o/0yGyiKa0ES/2lHvJY4Gp/t4JcjFD7+BrEOoN5at0 Ve0Q== X-Gm-Message-State: AFqh2kqDMyaCzzESn2WG0EhztbXXaV+6oAQq4896c+eRZiXdkPsIh+WA oHICWoJueQCQ6yDCKkA7N7gYcg== X-Google-Smtp-Source: AMrXdXssrHw6STGJ3GmPU/EnWu/3lii26xImgKRkdovDdo14zXU3VG6dhI/ytRUzw6RFBBRwulZPkg== X-Received: by 2002:adf:f0c1:0:b0:2bc:67d:c018 with SMTP id x1-20020adff0c1000000b002bc067dc018mr40432601wro.48.1674992810832; Sun, 29 Jan 2023 03:46:50 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id b11-20020adfe30b000000b002bfcc940014sm7736284wrj.82.2023.01.29.03.46.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 29 Jan 2023 03:46:50 -0800 (PST) Message-ID: <3c07b9bd-1981-2945-9efe-80afb0195de8@linaro.org> Date: Sun, 29 Jan 2023 12:46:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 1/2] dt-bindings: display: bridge: Add NXP i.MX93 parallel display format configuration Content-Language: en-US To: Liu Ying , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230128034713.1530218-1-victor.liu@nxp.com> <20230128034713.1530218-2-victor.liu@nxp.com> From: Krzysztof Kozlowski In-Reply-To: <20230128034713.1530218-2-victor.liu@nxp.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: neil.armstrong@linaro.org, krzysztof.kozlowski+dt@linaro.org, jonas@kwiboo.se, shawnguo@kernel.org, s.hauer@pengutronix.de, linux-imx@nxp.com, jernej.skrabec@gmail.com, robh+dt@kernel.org, robert.foss@linaro.org, andrzej.hajda@intel.com, kernel@pengutronix.de, Laurent.pinchart@ideasonboard.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 28/01/2023 04:47, Liu Ying wrote: > NXP i.MX93 mediamix blk-ctrl contains one DISPLAY_MUX register which > configures parallel display format by using the "PARALLEL_DISP_FORMAT" > field. Add device tree bindings for the display format configuration. > > Signed-off-by: Liu Ying > --- > .../display/bridge/nxp,imx93-pdfc.yaml | 78 +++++++++++++++++++ > 1 file changed, 78 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/bridge/nxp,imx93-pdfc.yaml > > diff --git a/Documentation/devicetree/bindings/display/bridge/nxp,imx93-pdfc.yaml b/Documentation/devicetree/bindings/display/bridge/nxp,imx93-pdfc.yaml > new file mode 100644 > index 000000000000..a84bfb46b01d > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/nxp,imx93-pdfc.yaml > @@ -0,0 +1,78 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/bridge/nxp,imx93-pdfc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP i.MX93 Parallel Display Format Configuration > + > +maintainers: > + - Liu Ying > + > +description: | > + The i.MX93 mediamix blk-ctrl contains one DISPLAY_MUX register which > + configures parallel display format by using the "PARALLEL_DISP_FORMAT" > + field. > + > +properties: > + compatible: > + const: nxp,imx93-pdfc Based on description, I have doubts this is a separate bridge device. Why this is not part of display driver/bindings? We do not create usually devices for single registers, because they are not a devices. Devices are a bit more complex - have some pin inputs/outputs, not a register only. Of course there are exception, but this one does not look like one. > + > + reg: > + maxItems: 1 Your driver tells different story: syscon_node_to_regmap(dev->of_node->parent); (which also points to fact this is not a separate device) Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5F407C05027 for ; Sun, 29 Jan 2023 11:47:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QQWE5Fh7UxJmIyaUyD5ISQxnrDNJ7U2hjMA1VLNl1lE=; b=Y/8tgbbdoaovkN bJi8cJqoDgfLztJdibvtf54UltxQ/nxVmKSraPiF/8+R90OnLiwVSMrQmd6nW6VlzgrN4EZrvSEsf utZCrt4DzuFIMy5yLVoKQGUN5fEYe2Z6KGjV+R/9XCRr9+Hi8aCb31TJ8Xi3HHuLhWkYM+SAehVU2 R+ylJnbpANwwznHf/I/VGONXn09HGXadbwRoXSctoTBZNn2tfp+sjK3tJFaJNwYyi76sZrnoKYWld aAGYhda0QaweLOS+Eq2T/nnAFiN/yYF/X5s4LDEgYcFPPLghldr8tyds7NcS7mzetYodSnhFw7omB 4oE2Z4aZFs4Dq3jYUT3g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pM69A-001ONB-Nn; Sun, 29 Jan 2023 11:46:56 +0000 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pM697-001OMJ-Po for linux-arm-kernel@lists.infradead.org; Sun, 29 Jan 2023 11:46:55 +0000 Received: by mail-wr1-x42b.google.com with SMTP id q10so8715114wrm.4 for ; Sun, 29 Jan 2023 03:46:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=q7mkqEU4uSNcC/souhhQCKfdHQR1f/GwKbFACfeiSw8=; b=ZZiVMpPR4dCSS0JCrzqkIIP9+6EKR1VAw7I2B+SKearBzD6dhIhthOHbPJr6botL32 k2Wr11VSSmxu3YbPRhQ1B56kWn7xNCH9ftDdplBR34cXxHxo69Ma+2iS7iGhfiBoZXUR CZfU+Be/5zIUahSgTsEDCn9x04J+F3h4c6KRNltlCdzsVV8Y4aDcx6W3UFuAdTKcaJSc 1UkxNk6ixU4DJqKa+M2AxATMSkIL9wf17NPXNQinQ4SAEDyIBhxYXaPJ0J2a6KpPI7f9 7FuZeeedlPvMcFYrCV4h+AeKkjvLcaNICDyV1lM5iCyGgwFTXXTGOhfPc9VhfqaWh2eP EmKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=q7mkqEU4uSNcC/souhhQCKfdHQR1f/GwKbFACfeiSw8=; b=oSAdZ0Qt16nW295eq8R3bhmN46ibM9j0CQ7LvN+P4KSATBKIab+dLjt8SN3gt5hqf+ df8Nanen5tW1NUXaB23lQxtRRHEJ25sy6V/sE8l4FV+Y7ydDMMEGnt09yXkNl3pvxUFq CETfsOqkLYzEa5AI1sVPUymrfJpki2yTrg95z9bczNNwBS8IHwzKfYiDYOMmivG2OAmw 4mu6w966w1x2qSnxQIKcoXHmMLssrX05ZpAFYtKTcJOGLQkhPSfXD5LW2UypnuukGGLd 3K5QVPMIMiHQ0GyZis9HI1bBg8Lo2N0sBYXYelHNewAhfSHVDhXmzyZRAqsnJvjB9GBE 9mqQ== X-Gm-Message-State: AFqh2krsmec6E7KsWTzgXzZBXxi82uRYw3q9HA8tnTzZA3cBylpRhkoh 73wB2G3lroAbIQIZV53n7qoRWQ== X-Google-Smtp-Source: AMrXdXssrHw6STGJ3GmPU/EnWu/3lii26xImgKRkdovDdo14zXU3VG6dhI/ytRUzw6RFBBRwulZPkg== X-Received: by 2002:adf:f0c1:0:b0:2bc:67d:c018 with SMTP id x1-20020adff0c1000000b002bc067dc018mr40432601wro.48.1674992810832; Sun, 29 Jan 2023 03:46:50 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id b11-20020adfe30b000000b002bfcc940014sm7736284wrj.82.2023.01.29.03.46.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 29 Jan 2023 03:46:50 -0800 (PST) Message-ID: <3c07b9bd-1981-2945-9efe-80afb0195de8@linaro.org> Date: Sun, 29 Jan 2023 12:46:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 1/2] dt-bindings: display: bridge: Add NXP i.MX93 parallel display format configuration Content-Language: en-US To: Liu Ying , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: andrzej.hajda@intel.com, neil.armstrong@linaro.org, robert.foss@linaro.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, airlied@gmail.com, daniel@ffwll.ch, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com References: <20230128034713.1530218-1-victor.liu@nxp.com> <20230128034713.1530218-2-victor.liu@nxp.com> From: Krzysztof Kozlowski In-Reply-To: <20230128034713.1530218-2-victor.liu@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230129_034653_873424_B66EE6BF X-CRM114-Status: GOOD ( 16.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 28/01/2023 04:47, Liu Ying wrote: > NXP i.MX93 mediamix blk-ctrl contains one DISPLAY_MUX register which > configures parallel display format by using the "PARALLEL_DISP_FORMAT" > field. Add device tree bindings for the display format configuration. > > Signed-off-by: Liu Ying > --- > .../display/bridge/nxp,imx93-pdfc.yaml | 78 +++++++++++++++++++ > 1 file changed, 78 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/bridge/nxp,imx93-pdfc.yaml > > diff --git a/Documentation/devicetree/bindings/display/bridge/nxp,imx93-pdfc.yaml b/Documentation/devicetree/bindings/display/bridge/nxp,imx93-pdfc.yaml > new file mode 100644 > index 000000000000..a84bfb46b01d > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/nxp,imx93-pdfc.yaml > @@ -0,0 +1,78 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/bridge/nxp,imx93-pdfc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP i.MX93 Parallel Display Format Configuration > + > +maintainers: > + - Liu Ying > + > +description: | > + The i.MX93 mediamix blk-ctrl contains one DISPLAY_MUX register which > + configures parallel display format by using the "PARALLEL_DISP_FORMAT" > + field. > + > +properties: > + compatible: > + const: nxp,imx93-pdfc Based on description, I have doubts this is a separate bridge device. Why this is not part of display driver/bindings? We do not create usually devices for single registers, because they are not a devices. Devices are a bit more complex - have some pin inputs/outputs, not a register only. Of course there are exception, but this one does not look like one. > + > + reg: > + maxItems: 1 Your driver tells different story: syscon_node_to_regmap(dev->of_node->parent); (which also points to fact this is not a separate device) Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel