From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E39BC433EF for ; Fri, 3 Sep 2021 06:59:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2EC4B61074 for ; Fri, 3 Sep 2021 06:59:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347504AbhICHAP (ORCPT ); Fri, 3 Sep 2021 03:00:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:59504 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346599AbhICHAO (ORCPT ); Fri, 3 Sep 2021 03:00:14 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 35FEE60F9C; Fri, 3 Sep 2021 06:59:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630652354; bh=Q4+XwPN+M1cvWkQuGrtu9reB+WwKcJKnoIF/ojmKBVM=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=XN2ippLWQO03bK2sMb6hqrkdTyYHIhPz9iZwFpJgB7QBDo8rWvQ4xqnbL5gU9Es2s 17jxFHAd/XT1DrU/jkwXtW363y+iTEMpxGiofl69XGp09ZR/v8OB0cLb2gy2y+fvQd jCQap+vXUfakWwWdbRWu31f+HpaqITe3E6TdfwEZaF3YbdSm8e6LXoEqmgO/OkZOmF V2pUpB+c5km+hBzOoSkrPfxcnoD/tqDq+E39QrFolaS4cJRsmRLCcqDeGwAs/BGCWx xZiel+RBUcWpHQ+RN7pS9FO8aydVvafLD0De1OWSP02PbRMMCwOXbqJIH5w4e2VV3j 67ghs2Cawuepw== Message-ID: <3c0a8a858a805789b9c71b7e54e316403fc41d5e.camel@kernel.org> Subject: Re: [PATCH v2] KVM: x86: Handle SRCU initialization failure during page track init From: Jarkko Sakkinen To: tcs.kernel@gmail.com, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Haimin Zhang Date: Fri, 03 Sep 2021 09:59:12 +0300 In-Reply-To: <1630636626-12262-1-git-send-email-tcs_kernel@tencent.com> References: <1630636626-12262-1-git-send-email-tcs_kernel@tencent.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.36.5-0ubuntu1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2021-09-03 at 10:37 +0800, tcs.kernel@gmail.com wrote: > From: Haimin Zhang >=20 > Check the return of init_srcu_struct(), which can fail due to OOM, when > initializing the page track mechanism. Lack of checking leads to a NULL > pointer deref found by a modified syzkaller. >=20 > Signed-off-by: Haimin Zhang > Signed-off-by: Sean Christopherson > Signed-off-by: Vitaly Kuznetsov > Reported-by: TCS Robot I'd drop reported-by. It's not a person (I guess) and the desc is self-contained already. Anyway, Acked-by: Jarkko Sakkinen /Jarkko